From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) by dpdk.org (Postfix) with ESMTP id 9C8F83DC for ; Sun, 18 Dec 2016 20:11:03 +0100 (CET) Received: from tarshish (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 8AD44440107; Sun, 18 Dec 2016 21:10:44 +0200 (IST) Date: Sun, 18 Dec 2016 21:11:00 +0200 From: Baruch Siach To: "Mcnamara, John" Cc: dev@dpdk.org Message-ID: <20161218191100.nzgn2w7465qnk26v@tarshish> References: <819ec07b51126e7877503b95fa30d7fd8da3a42a.1481623418.git.baruch@tkos.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161126 (1.7.1) Subject: Re: [dpdk-dev] [PATCH] doc: fix required tools list layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 19:11:03 -0000 Hi John, On Thu, Dec 15, 2016 at 03:09:32PM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: Baruch Siach [mailto:baruch at tkos.co.il] > > Sent: Tuesday, December 13, 2016 10:04 AM > > To: dev at dpdk.org > > Cc: Mcnamara, John ; David Marchand > > ; Baruch Siach > > Subject: [PATCH] doc: fix required tools list layout > > > > The Python requirement should appear in the bullet list. > > > > Signed-off-by: Baruch Siach > > --- > > doc/guides/linux_gsg/sys_reqs.rst | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst > > b/doc/guides/linux_gsg/sys_reqs.rst > > index 3d743421595a..621cc9ddaef6 100644 > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > @@ -84,9 +84,7 @@ Compilation of the DPDK > > x86_x32 ABI is currently supported with distribution packages only on > > Ubuntu > > higher than 13.10 or recent Debian distribution. The only supported > > compiler is gcc 4.9+. > > > > -.. note:: > > - > > - Python, version 2.6 or 2.7, to use various helper scripts included in > > the DPDK package. > > +* Python, version 2.6 or 2.7, to use various helper scripts included in > > the DPDK package. > > In addition to this change the note on the previous item should be indented > to the level of the bullet item. It is probably worth making that change at > the same time. All items are equally aligned as far as I can see. The 32bit on 64bit requirement bullets are sub-items of the previous item. Am I missing anything? > Also, the Python version should probably say 2.7+ and 3.2+ if this patch is > accepted: > > http://dpdk.org/dev/patchwork/patch/17775/ > > However, since that change hasn't been acked/merged yet you can leave that > part of your patch as it is and I'll fix the version numbers in the other > patch. Note that your updated patch[1] conflicts with this one. [1] http://dpdk.org/dev/patchwork/patch/18152/ baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -