From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 38839FA49 for ; Mon, 19 Dec 2016 17:17:00 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id d2so24724186pfd.0 for ; Mon, 19 Dec 2016 08:17:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0uQh5VyUcEWfL1Wxh/XytoX8kMRl9MmoyzLYS94l1fU=; b=t+7CpINtnhK6hPrRJvJoxvSksVjoyETckCKKZek0Gb99cKacxezxRQhX5weY1rZONd Wl0aJgB3GjnUKK9r42djyNbSm0Mkp4jO+Nw1F2lyvEb/6ueB2KUWwIiLSdUVPbrqJKV1 atM5pOOzTmLH6CmRloF5KPd5UcqLarVRcTFGrQzKhNtNI7xCOwPlgAEWfPm9HktyOTxI rohvZ/bFG9IFL7HH+1RJp5fCniSGlhkhEGZEhVEiaGeJwz4G4zm5GG21LkmnZH2hvqf5 Cjyb1DAPKC9C2zpffWZb3S43ohR4GWNnI5BOEddGm/BTkMIpHAhBBhutXUvO9EgypR4M Wr+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0uQh5VyUcEWfL1Wxh/XytoX8kMRl9MmoyzLYS94l1fU=; b=ZldK5KsKWKPv3ttRgkahkjeakP422mQSfAzRtT8Mq9ZdlRNiHclu/VDoNlxr7ak5pu ehhQegTdgXbQtwJzXOH/nAmoprZP8658XG/aGuMfl8ew9RKA9eSPQ/GUuLYe6wxQnd+K bmF0Wt9L1a8SewLvwQyOnbXZ4QSEd9cM+mt+XniGnOicFGrUu/iWdLWZV3RH8LwCC7yT pQRW/fN9FCycrp7ZiSwAJsBIK6zUSkiOKKyflDxvHqTIjVqu93BBPkFhFkW0XZD7OaX9 fUK/rXtGej+ZP6sUXH3ym2GK9ewotFWiI243YB62KoGw7hz+lVpSVUCjQztvJM3FtxyO +/Kw== X-Gm-Message-State: AKaTC01KnzlgQLzPgFFkaZEh9U0YHOyOAGRDZzsOCyF9MLaWjFwNCnNroB6d1y/yNZzq6g== X-Received: by 10.84.197.131 with SMTP id n3mr35472210pld.6.1482164219425; Mon, 19 Dec 2016 08:16:59 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id k25sm32580915pfg.84.2016.12.19.08.16.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Dec 2016 08:16:59 -0800 (PST) Date: Mon, 19 Dec 2016 08:16:51 -0800 From: Stephen Hemminger To: Hemant Agrawal Cc: , , , , , , Message-ID: <20161219081651.6482f6b1@xeon-e3> In-Reply-To: <1482180853-18823-2-git-send-email-hemant.agrawal@nxp.com> References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-2-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in rte_eth_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 16:17:00 -0000 On Tue, 20 Dec 2016 02:23:40 +0530 Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > lib/librte_ether/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 9678179..0b601e9 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1626,6 +1626,7 @@ struct rte_eth_dev { > eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ > eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. */ > struct rte_eth_dev_data *data; /**< Pointer to device data */ > + struct rte_device *device; > const struct eth_driver *driver;/**< Driver for this device */ > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ NAK I would rather that rte_pci_device be eliminated from rte_eth_dev_data and replace by more generic rte_device. I am working on a patch set to do this, it is not fundamentally hard.