From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 943C8FABC for ; Mon, 19 Dec 2016 22:59:58 +0100 (CET) Received: by mail-io0-f172.google.com with SMTP id 136so164445232iou.3 for ; Mon, 19 Dec 2016 13:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8Z/Tg+AO+xI+rGIXfKvw+lWeUIhqLKjv4Dk7ClvQRcg=; b=jn6QbNutHTJXbDNWvH1Ptknl1n78k1R6M+3fDtuN9+/Kt3kgJyIZaLAeIuLf8TqF0t 8DRYbaUFvVkWHaa3wEZt6IiwjyFQYsd4XFT6txxu5i2ub0/9P7BJINIQyJCDbNre0+Py Hj/GgdmUmFsMR3hVqVKL2moVl8oQuiz6wo642RiynzQDtMU7YapLqJhH9XSV+x3Vvt8o H9JfLem+OEfg2VcRjZLTvL+ICsZf9rSWnMoT/0gneipL6npP4s0/BpC8KK9qt9rT/uMg rq/99+18tiAMhUgXfSvFfiBhiHDZ+zA+a/TtG0C0PcTDL4W+n0s+BfxUC1u0IqVhPmCo 9zmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8Z/Tg+AO+xI+rGIXfKvw+lWeUIhqLKjv4Dk7ClvQRcg=; b=tYBekRbA/IR6k50EEefnpobdH2N0DX095+wyPh302rFYQlhCjh+MhaJuK551scvaa7 E+IWXLX8iSFuvEvrZX0W0I9+bM/KG/dA4Wvl6bqgvrhKUiETX4e8DkhxDEnSgZSbemq8 TzyxxR8T5yZLXve2uO9F2dMpuTklrWgMVinwtKW7Tg+64TLzY2/t2RKShTIjxGBVk2Yi Sxw/9E/PUbDdegGRcGVI3PjhemT8D53oMeQZZKJNgBgaK9korjFA3BSMKEoGD6igxV22 rD4RxJkzZWqDL6k/NCHQe9neAhoBxv+Mdk5JNUjlwGCfyIWXnoeLM4iKiLIil+JUzZwz JYnw== X-Gm-Message-State: AIkVDXK2mAB91L1tNjfH5UcSdeoaVT50os9//YSkVEd0251fpa842aawEE1k6ehBF2hw1Q== X-Received: by 10.107.178.148 with SMTP id b142mr18111354iof.69.1482184797957; Mon, 19 Dec 2016 13:59:57 -0800 (PST) Received: from xeon-e3.wavecable.com (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id p20sm8270581itc.2.2016.12.19.13.59.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Dec 2016 13:59:57 -0800 (PST) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 19 Dec 2016 13:59:36 -0800 Message-Id: <20161219215944.17226-6-sthemmin@microsoft.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161219215944.17226-1-sthemmin@microsoft.com> References: <20161219215944.17226-1-sthemmin@microsoft.com> Subject: [dpdk-dev] [PATCH 05/13] pmd: remove useless reset of dev_info->dev_pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 21:59:58 -0000 Since rte_eth_dev_info_get does memset() on dev_info before calling device specific code, the explicit assignment of NULL in all these virtual drivers has no effect. Signed-off-by: Stephen Hemminger --- app/test/virtual_pmd.c | 1 - drivers/net/af_packet/rte_eth_af_packet.c | 1 - drivers/net/bonding/rte_eth_bond_pmd.c | 1 - drivers/net/null/rte_eth_null.c | 1 - drivers/net/pcap/rte_eth_pcap.c | 1 - drivers/net/ring/rte_eth_ring.c | 1 - drivers/net/xenvirt/rte_eth_xenvirt.c | 1 - 7 files changed, 7 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 65b44c64..e0447fda 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -117,7 +117,6 @@ virtual_ethdev_info_get(struct rte_eth_dev *dev __rte_unused, dev_info->max_tx_queues = (uint16_t)512; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static int diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index ff450685..2951f86c 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -287,7 +287,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_rx_queues = (uint16_t)internals->nb_queues; dev_info->max_tx_queues = (uint16_t)internals->nb_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index a80b6fa9..74af6589 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1675,7 +1675,6 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_tx_queues = (uint16_t)512; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; dev_info->rx_offload_capa = internals->rx_offload_capa; dev_info->tx_offload_capa = internals->tx_offload_capa; diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 836d982a..b4f253ad 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -301,7 +301,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues); dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues); dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; dev_info->reta_size = internals->reta_size; dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads; } diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 0162f446..7253b9ad 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -559,7 +559,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = dev->data->nb_rx_queues; dev_info->max_tx_queues = dev->data->nb_tx_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index c1767c48..dc99a1fe 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -179,7 +179,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues; dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c index c08a0568..609824b6 100644 --- a/drivers/net/xenvirt/rte_eth_xenvirt.c +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c @@ -337,7 +337,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = (uint16_t)1; dev_info->max_tx_queues = (uint16_t)1; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void -- 2.11.0