From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46]) by dpdk.org (Postfix) with ESMTP id 5C68C10D21 for ; Thu, 22 Dec 2016 13:36:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KJgBp+kvZkRnzofJDnDLEaliTu/rDYtL7JC9e3DRuyo=; b=b1QVc2A3rz0zPaPkI7JbHTd3uoKlmAoIlWI89Q4+rNRSvkc9OlOITSfsBcW+CgrD9tf2+NGWiJMJlZFFo0kyFLZi5N0yy3O4j2VlRf15XxbH8P7oycnSRyVYPcod6TBLjLUIHKKe3gRnPR71lgVwv8N6EyVPr2LjqhckqxImXzc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from santosh-Latitude-E5530-non-vPro (106.209.175.104) by BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Thu, 22 Dec 2016 12:36:34 +0000 Date: Thu, 22 Dec 2016 18:06:16 +0530 From: Santosh Shukla To: Jianbo Liu CC: Jerin Jacob , , "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin , Helin Zhang Message-ID: <20161222123614.GA8868@santosh-Latitude-E5530-non-vPro> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1481680558-4003-24-git-send-email-jerin.jacob@caviumnetworks.com> <20161216044017.GA29607@santosh-Latitude-E5530-non-vPro> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161216044017.GA29607@santosh-Latitude-E5530-non-vPro> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [106.209.175.104] X-ClientProxiedBy: PN1PR01CA0074.INDPRD01.PROD.OUTLOOK.COM (10.174.144.142) To BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) X-MS-Office365-Filtering-Correlation-Id: 8af0de0e-de9b-48f4-3c5c-08d42a672c2f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 3:DS6GJfNVBYOgCquNjPJ/FmxoRVOpKAKXNi2T8atFozaIQUNu1fmtAoaeJEu2xxN752uguKngJ531t4oToHCWX16Yu3DDp4IwePo8A097g7qAq1EQJnr+IDEAFMimnR5zEJtotw8/BDSzwJPr+TelTWnVCDpXrvWvJIc2eQc9RDQIFzmfSmWsHmzR8ZPRfLPBYbCgUDIYkGL5JRoUKEL+q103kyhE/y/xseUSEoNjq7QZpQyWV4kWJVdw4chcbncLskFWALSjO3E5YWDUHwdt6w==; 25:Hhm3VFEWPPQoBbZmbtKrH35mBacGUpsphsXbGR6ydo2hAusA1L4UZ47UUGExhZxT3k/034bi8UV+xd0BR3ZkMjrVRwK9BCDNqFpGsO0z3AiTnlGlyywou9Kg4j5yUz8EJRMcO+SkuG76VkBQ3ZPbbgY5KhrWxgtWYxoFiXqh1xKVu+IWoNFWBR+tT0Kl3JcsmazdLbdgNJtDlM8aG1XQIXCE5748wVEGv+kDuj2GAZoD5Wb41mVMK0Hpp6AmXbLbdQirQjODglUsUMD8OyX6ggjxGwG8A59vYyjPn+3evpqDQkO+oYAPSsNGUhErLr3EBg5Of5++e2V/oFoR9BQ5Ex/ejqAAlftgyOmx4tPnivIny8D/kdUfn+V/jI6k9wal/ZrfVHVqFL2vSL1eDT2EU13CZokxoRAM8Hz/0VgDBZqTfid8a9pj05q+ggw4F86SUNLiKkDPqt4cH57HCcjJAQ== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 31:WbA/mEJ/tHwe66BocyXl34GsVsY34MGt3FJExRuz0akbtRecmVz72RYLnBdIL4QGn1EQ52hXnrbWitdg0giMu0mpFr1A8NQNf3rYWN5tqtuAh8oL4Hiis0gLCIEdmPPbeYHNsahJdaL7aAO27egxOVxau5YP5Uk7CWPO11ls6P92qXkYBy8AbHnlea2nAFkzL5+NCMVnZ3QMd412ALOhOft0jCxkyHHuUjBvaADXq4klhhKVEgPVLJhcDyeDJ4oYQYitzu7ogKhCuUUb0YyyNA==; 20:YMebdOAgHv6vq+mrR+iw19hdrTS5FrXezJHJp1NGOnB7A1o9M3Trhbo7GZj02idmsPuqs4IWYF98+EaEdldc/lvPNANiu2zDSL7qZ4dY39cawHXO13MiyFbOuMV6lO2sH89yg0eeWoRNQrDQAr7SS6siXaEq7VbuIL2ASgK+PCx5BN4wCTnxHeULf2AThKdVzCW+tdeA2g4BubyDHcyFGDbqocgwmjI8KyOrqqwWkfRZENwv++B7KIiMnaA6GDX5MUA00DOrqZelr1ZHAr4wobOrgoK9jdNn6HXJdaczYTKpTXuDxGR/FCL67wl/KscVytOBNOLN8JVFx5M2M4btUYgJNxye7WBrtv9qI/ifevU2xCR03GOfhQrxA8bGUeS6PuSAccyR0ygdpl8mHHJiSCe3EGFcnzXJCpstZfbZEc89scO5/4cnu5PklRHPzJhoBoaLgZXB6XdARz95YLjLe7yEIvBq3fkRdRz7yO/F352xF0qdddpECLNYSUPYRwEi0NIFOEh37s0I5zo+eTHJD3y4RKlvaUXqernv1kIEpenX+67hHWQ26alGdTw7/6iXvafcC7SdFkgkNfhaEDfkxJIglF7QriJHwz31r8c+fi0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148); SRVR:BY1PR0701MB1721; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 4:g33bLNmees6GneAuwnhPs58Vkk3CQgVwAmQ0X3MKhTreevelUChzYbPUJYi/2rYLb6SgSSzB2pWlJQwCbJ2R56ocw83aUOOdkqGbPIVnRaNsn/2zsAwaOt+Q/tI1lKCZfA8yNLT13qBYFAj+/ETJahTgRhak5lgdecuT5tOS3iu8bEdT5F4Zk7McP0oY7o3/6WGbIuLOKmP6jJrsRAoBmJfTY4HcVErbMCjzGREYIuicx67z8LbrW+0m8jkRcZ1fNyZOh9h//0FyKvHC+OEpokpK8I0xPBuXgyu8NiNHW2jkQj+BjcKLaxZXz/lNApaqENOwMWhalaLrcZ1LeftcSRKJfOz1s5rddNNmzo5h0xIQ4Us32hSxAoPXX7trWzIwyz31vG0Go6qCba0j0HQl5t5Azs6jwTtPjMx03l97z0hnBBnCsamnrrYftXpTghcGDq0a5IDDGqJD83DNYPEbVb/Q6OlzDDQiT3DUSs2Y6fgXlR4//epfu8uy4UlukHnDxITP2a5huhI5CoQqr9mnA7hHEIaqPjtfLOqlWpCitfJRAJGHs8sxDZb9Snd5NVcyP33pzzJZvBCFcJLnDqDjU+1Wu3fDmKrxHLNUnamGx/V8tPQAhSbgsxsWIox0CfG1Epv0DtbS8GF7HKpAUBbhXQ== X-Forefront-PRVS: 01644DCF4A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(43544003)(189002)(24454002)(46406003)(33716001)(38730400001)(3846002)(5660300001)(6496003)(23726003)(1076002)(6116002)(229853002)(93886004)(50466002)(9686002)(25786008)(83506001)(97736004)(68736007)(2906002)(4326007)(4001350100001)(189998001)(7736002)(92566002)(33656002)(42882006)(101416001)(2950100002)(54356999)(50986999)(105586002)(76176999)(106356001)(6916009)(110136003)(5009440100003)(81166006)(47776003)(81156014)(8676002)(66066001)(6666003)(42186005)(305945005)(97756001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1721; H:santosh-Latitude-E5530-non-vPro; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1721; 23:ANMM4iRAiNHHR5dnXoUleUZflHecmDS4dsSvHn9?= =?us-ascii?Q?Tw/vIejDhGtnPrX9YOsxVRaLlM4ViocXpe8Pp3wvHYsFovOEJ+4Gu8ScOjTy?= =?us-ascii?Q?NS/y547fWB+HDEeiTOnVBr1wrsHtv0AoAkArMUvjphK/F3xLZ1KTkp/dGfxY?= =?us-ascii?Q?k+xs2gIqVbzJVL+/NobenicxewjbPR+2gJKt3o+iHHRz8nStmn9of3zjdNas?= =?us-ascii?Q?nRlzpFv9wAfpJ+wUQ8i5sCysSz97jT7BN4OcrN3a5Ur8dYMwkk18Rmt/F+bi?= =?us-ascii?Q?fEdHPrqwFO3Bf/3Sktrua5uAuVeh+e7OulepLXvltik318aOpdjSZOuFgWgT?= =?us-ascii?Q?faJI+wC8rAXRwrGStYad7UvcY4xBqg1AUh0QzDgSPwUi765kpBMhzT8IjOdu?= =?us-ascii?Q?yvjllak8MX0fi1+wQwIwfIK98lAjr+aVzCCzUKxnJnV2RMWSzOrV38313aRr?= =?us-ascii?Q?VfM6KMMgf3LnXik2G2SfWhnb2LaP7FFypi4TkYj/LLQTFWK43zgVE3MHJ3pr?= =?us-ascii?Q?g9YubtQuh+k/clZvbdXQW4FlAY80fnXQbkY+o44kcJim3P+ZjdR7VSNabzWx?= =?us-ascii?Q?sKybM/LuZjoDCxFY8EsyhUtIprZo6zZOvr4iMaQtGl/8sW/WNifZMAKOKUa2?= =?us-ascii?Q?lFrzE8nuuRjW8oRscrntbYllvVLPC53v+CenjRyoU1Twup7odjVXXfT/iC4P?= =?us-ascii?Q?TfX8ZoX1J8zKCDVNZlg/e1qTIT9E155n8v9SvCRvltG6txTZLVJzwmxoB6vj?= =?us-ascii?Q?xltfOqK1U82ZHUpdsWjfQvxvF87mak2Bkd9A10R/HhWgafc2IyHMMHyTi2zg?= =?us-ascii?Q?0hVPy77VDcJZBfAl2jKpsV3yAaSSmwiJizxxjHzlVMASr4Kygri7+EPetCVI?= =?us-ascii?Q?iHut/piRi9TNhiw98KPq1Fbjv3GhiTGwF0W7VHDYmvRtDxTlZd0QJUP5YnoK?= =?us-ascii?Q?bgrmsOIji2ETGTdNDDyflHAxId0oQTTlZA6/TER0T5AR2puT/LI7smmzWHsk?= =?us-ascii?Q?URgRPDKAvlQQU6sf4rNNjH71A0EfwtycfWf+8j1clIpE8K3gc/cQ7Z7RrL0m?= =?us-ascii?Q?51ycDvnwDS7qIgKbW+uhD2dsz/mJNSuxlcFq4+ZGB54WYk3EckW6bDommSPS?= =?us-ascii?Q?YfWIow9cklh7ZG/FOiq5NTuVhEQMnykh/npa1ZUSC1ELeUlwosIwvIT2a37c?= =?us-ascii?Q?/qB+asdSb3ywhxRB/b1l6/hWR7TnLyMtUVW8ZQ5v056PsRZN37qewv5KuJxf?= =?us-ascii?Q?Rz8HdtT01cV9zE0uPa0b0Av2e2ikjcSXVVeG24DmHy3XxlrUp7dysst9rFjk?= =?us-ascii?Q?xwQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 6:s///Z0MtPTItaTt21zrbZhDfhnEnCKGwreAiyQMaaApyQzKrZqRUIpBWE0f1hA591OtO1S0IhvHn+iT9y34KF+vSchyfU05sj3c8+b8Acb6DMCV3+kOlZ/PiMmvuQTSe+GwGcd0Cio1/e5n75/SOCMw/BXxYmAA5E+IuFViJAOyZVNYLjCKnKOn5RcDz5lWAMidCEpWnYikTlTtKa8WWWR+h/RctE0V0Hzws1KUXNasGjfrtbT5uAzI/6sHhKpJ+ynixbwBqN2OjNkqBZ2B4BEV1amBtp4YZxpJLc1x7r2ZhEz2f+Tfs4GBJ9/0vBTnFsyFSFKRYQOBajdhRUlmzOO64G77gG2Mzt0P3nE/1xFBBOdwJQcaL6snSMYu0lUiQD+ZE6Y0+xGalMDqaqqrEAT8uyZtTlr19J2cNCFbfR4E=; 5:21XXdI682XdI4U1LAKZ9hT3wdZMLLh6RJ0Vw/MKDF0Q9yF1tzNbwi4+tOhMZUNYfRHfbHmfU+LHFdwHuFoGWgqMrsCiDOOwcwgrmSHDzFrKGKpNjbVVlJgXJXDEi9M3tFjdSY5Vxophzg3AztuAeLffqcrIgSGYqD4cu0hRHTp8=; 24:GTmTqOfKQafryk4lsRUhMv1CQ2+XrosYOhMtvXOkHEbwvDSOeWdy3J3Id46mjh0bKMIq38mKnVCICFFGo6jPuTcm9yD7wQgCVgAEnqa/XyY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 7:Uc7zoWAOc7klSZl6ojrZgit80HCZ1GWiPb3TDIv0QCyi8vP+mrWYvUgZ+XZR9mSt592+n6jeUQMEszSoZfnZalyhgLcAfaeqTF4a4t1+6qFXNlLx7Gfk5usa9EOoq28Qrj/3C8zqRMChq7ivORlAmWtyBwJzZsJWyMW/AUuJqz8U2GXFfuXAR/NzykXaNoLPm40QTzaDcaV6OMv8bOh2AtUnX0Hfqa00VkubFrh8S00FeVOF5vXM6pq5YP1gmFn0cd/EzZh8PBv1zWQ5T4gec+qrcFKbu5SQ6iPadSY4N0jqmsw0Olf2rQjKFmnuu4YK1mTtMa9vQEMVJ2/T/Ivh4nzoA3RVIs9ok8ISzw2sSscSnRQWKS09kRBx/OMPTSOgHzS+mS/Sop/AMO7hpv2dKooVdoy8xj66jPbvkHWm5K3mBy16UCH/y98r1E23U/6dUlzb9HT+7UYT6dfUmyORdw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2016 12:36:34.8360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1721 Subject: Re: [dpdk-dev] [PATCH 23/28] net/ixgbe: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 12:36:40 -0000 Hi Jiangbo, On Thu, Dec 15, 2016 at 08:40:19PM -0800, Santosh Shukla wrote: > On Thu, Dec 15, 2016 at 04:37:12PM +0800, Jianbo Liu wrote: > > On 14 December 2016 at 09:55, Jerin Jacob > > wrote: > > > From: Santosh Shukla > > > > > > > memory barrier operation is put inside IXGBE_PCI_REG_READ/WRITE in > > your change, but I found rte_*mb is called before these macros in some > > places. > > Can you remove all these redundant calls? And please do the same > > checking for other drivers. > > > > Ok. > > Thinking of adding _relaxed_rd/wr style macro agnostic to arch for ixgbe case > in particular. Such that for those code incident: > x86 case> first default barrier + relaxed call. > arm case> first default barrier + relaxed call. > > Does that make sense to you? If so then will take care in v2. > > Santosh. We spend time looking at drivers code where double barrier may happen. Most of them are in driver init path, configuration/control path code. So keeping double barrier won't impact performance. We plan to replace only fast path code with _relaxed style API's. That way we won't impact each driver performance and we'll have the clean port. Does it make sense? Thought? > > > > #define IXGBE_PCI_REG_ADDR(hw, reg) \ > > > ((volatile uint32_t *)((char *)(hw)->hw_addr + (reg))) > > > -- > > > 2.5.5 > > >