From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mirq@rere.qmqm.pl>
Received: from rere.qmqm.pl (rere.qmqm.pl [84.10.57.10])
 by dpdk.org (Postfix) with ESMTP id ACCB010DCA
 for <dev@dpdk.org>; Fri, 23 Dec 2016 02:47:53 +0100 (CET)
Received: by rere.qmqm.pl (Postfix, from userid 1000)
 id F1FB36082; Fri, 23 Dec 2016 02:47:52 +0100 (CET)
Date: Fri, 23 Dec 2016 02:47:52 +0100
From: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20161223014752.wicbgkvlotllsfc6@rere.qmqm.pl>
References: <f6d14b640928f69ab747793cd8749b48a1b74afb.1481590851.git.mirq-linux@rere.qmqm.pl>
 <cover.1481590851.git.mirq-linux@rere.qmqm.pl>
 <c0b4fbc916008d8c8e47707889eeac545a10eb0a.1481735746.git.mirq-linux@rere.qmqm.pl>
 <2601191342CEEE43887BDE71AB9772583F0F2997@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2601191342CEEE43887BDE71AB9772583F0F2997@irsmsx105.ger.corp.intel.com>
User-Agent: Mutt/1.6.2-neo (2016-07-23)
Subject: Re: [dpdk-dev] [PATCH] acl: remove invalid test
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2016 01:47:53 -0000

On Mon, Dec 19, 2016 at 06:48:52PM +0000, Ananyev, Konstantin wrote:
> Hi Michal,
> 
> > -----Original Message-----
> > From: Michał Mirosław [mailto:mirq-linux@rere.qmqm.pl]
> > Sent: Wednesday, December 14, 2016 5:24 PM
> > To: dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > Subject: [PATCH] acl: remove invalid test
> > 
> > rte_acl_add_rules() has no way of checking rule size.
> > 
> > This was hidden because the test effectively checked that
> > adding a rule with userdata == 0 failed.
> I suppose that changes have to be inside:
> [PATCH v2] acl: allow zero verdict.

The 'allow zero verdict' patch depends on this one if we are to not have
a breaking tests inbetween. Otherwise, it is an independent change.

I guess I can merge them, though, if you prefer it that way.

Best Regards,
Michał Mirosław