From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id AC80E2B86 for ; Fri, 23 Dec 2016 23:08:37 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id i88so45393234pfk.2 for ; Fri, 23 Dec 2016 14:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5uOSr6/A+Txjj7NFjyFN9uIyIznHZKBbQskT+JMg4eE=; b=ENJXepXaBWF/t3QqIsjqKxD/tHRAi2lM6EpX5z2lBZnYSLlZ7FhSUkmOHnsuSxMZEh n4d3kn1ARB2PA7MyHdeBhos95uGO5ETVTcrlVvabE1qiUnflYijuYivxnblrxz+i3Qh5 6Z4Xs7mEm3WIXOF6sqyPbw7a2cMs8XU6MoAK1xSzvPj+qnwFLKLGkFQH8DBm939AGPA6 +9YfvMc5vsspk/JAtKLIcE2CZ3dA23q1q7a0X+AUJX4udxKSjRRpdm9mkO23NV8sujFl bYN+3K+D0gxQDddEdiTWd45YDJ/LnuT1N52MF36vh8zkKlJ8JxDKpiJe4aBO7Gf2I29P A50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5uOSr6/A+Txjj7NFjyFN9uIyIznHZKBbQskT+JMg4eE=; b=pWi0XnhDG889JdgW1NEt//bnG8mXh1//qTBvNu3/K2vAn3oVODbXp1kM73nd1BSM0s NIPzbrFNWwia+06ZacMlsSWmemi9lPbl8lvBhU4jTweY8I0xTF+hKia9KqwHI2xOW/8s 95CBd5zQtzvQ07XXD0giocs4IkdSbyYEAUQCCQAgCNyXNIG2U0wtagDFo9Bbhn0npTAM nv8/C9Xgk/sereQVkQ77TFZQRio64zPEreIeeJPVE5+ZDddyFQEdgCGKiFthb51pbWdW tcIpbKWvA5V8YAMuV4WD2o4abpxZpyxdNHp/y4WIian31HMGZTuVrOSdyDZLHPETZBXq u1TQ== X-Gm-Message-State: AIkVDXJdGhtaZbZg8/g6ozk7CfPz6yvg6vniVfxPlmWnyxGUxzIxFGNxCkJkKlbDn8azmg== X-Received: by 10.84.217.199 with SMTP id d7mr33260539plj.165.1482530916914; Fri, 23 Dec 2016 14:08:36 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id e6sm45665238pgf.4.2016.12.23.14.08.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Dec 2016 14:08:36 -0800 (PST) Date: Fri, 23 Dec 2016 14:08:28 -0800 From: Stephen Hemminger To: Jan Blunck Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com Message-ID: <20161223140828.2232d1c8@xeon-e3> In-Reply-To: <1482508691-11408-4-git-send-email-jblunck@infradead.org> References: <1482508691-11408-1-git-send-email-jblunck@infradead.org> <1482508691-11408-4-git-send-email-jblunck@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 03/20] rte_device: make driver pointer const X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 22:08:37 -0000 On Fri, 23 Dec 2016 16:57:54 +0100 Jan Blunck wrote: > From: Stephen Hemminger > > The info in rte_device about driver is immutable and > shouldn't change. > > Acked-by: Jan Blunck > Acked-by: Shreyansh Jain > --- > lib/librte_eal/common/include/rte_dev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h > index 1708244..b17791f 100644 > --- a/lib/librte_eal/common/include/rte_dev.h > +++ b/lib/librte_eal/common/include/rte_dev.h > @@ -122,7 +122,7 @@ struct rte_driver; > */ > struct rte_device { > TAILQ_ENTRY(rte_device) next; /**< Next device */ > - struct rte_driver *driver; /**< Associated driver */ > + const struct rte_driver *driver;/**< Associated driver */ > int numa_node; /**< NUMA node connection */ > struct rte_devargs *devargs; /**< Device user arguments */ > }; Go ahead and add missing signed-off-by. I overlooked it on the original RFC set. Signed-off-by: Stephen Hemminger