From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DBD6E282 for ; Fri, 30 Dec 2016 07:42:53 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 29 Dec 2016 22:42:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,428,1477983600"; d="scan'208";a="47996407" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga005.fm.intel.com with ESMTP; 29 Dec 2016 22:42:51 -0800 Date: Fri, 30 Dec 2016 14:44:38 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, stephen@networkplumber.org Message-ID: <20161230064438.GL21789@yliu-dev.sh.intel.com> References: <1482996643-113253-1-git-send-email-jianfeng.tan@intel.com> <1482996643-113253-10-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482996643-113253-10-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 9/9] examples/l3fwd-power: fix not stop and close device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 06:42:54 -0000 On Thu, Dec 29, 2016 at 07:30:43AM +0000, Jianfeng Tan wrote: > As it gets killed, in SIGINT signal handler, device is not stopped > and closed. In virtio's case, vector assignment in the KVM is not > deassigned. What wrong could happen then? > This patch will invoke dev_stop() and dev_close() in signal handler. I will just say, it may workaround the bug you encountered, particulary, for this example only. If some people want to use the virtio interrupt somewhere at another app, he also has to do similar thing. Is there a more clean way to handle such case in the driver? --yliu