From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 144EB568B for ; Fri, 25 Mar 2016 19:50:57 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so26201211wml.0 for ; Fri, 25 Mar 2016 11:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0nPSRAozWOGlrJydnnwbJCKQo67hVSHp+9dsVY0KOVo=; b=o6tr6u0IU2fLFjjgOPBtrEVNvcTisJ9HR5Ilk512fRCaych4W2EZsWv+wkoijkki95 BXj1ZbHIn3hVeJ7S9hpGAvSRHI6SCJEE0qYvi+6QdPv8m/OLG9FaNEwVLz+7IppnOTBw GCk32j53mSmUasMudeodr8s9SNrUaObjVlsf9vB3+egmvnlEL+rGySG8YQBY4gdrs87R K3++LOGwKZcaKeQliKoOacU0mZVyZWvZU05uERNLG6ZgZ/IxG+/HbPR8N4sPsf4XK9D/ 4TNZ5SxdUqH9I8U5lDC6SXkqKEWMCaaUxRueZGOWh/+7u2f2YCjuaVXuCuaUWuhazl/O Egvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=0nPSRAozWOGlrJydnnwbJCKQo67hVSHp+9dsVY0KOVo=; b=X60Nsp7NJCzWey3YVKx5UZUapuCN1LWVwzoyJgQWPEyx/yEGeTFmmOpwgzGq3z9xLr jfq+S9G66Se3whmO212C49mm6ytWqoT8pY/kPp1I6lFSKare5vPjWA19J97Vpm0kQQq5 YqUMAslbU3lJOkmr47oeNFimiez2vb/xUWkHjlus7nekazbJCATyc64uL4xTWahUO+IO /4pdHyO6gFGJeWa7lvS0/+Jn9TMZ+H/7xLMFKsWcn23Tudfxf/u6eRxi45yFtX5rzGXa Sn2z1a9IWMz4EtVhafafqxRGT5UTERr3PXpzNF+5kk6++XajGVNYN7mKUhPyeHIb8Ggm pj3Q== X-Gm-Message-State: AD7BkJLjli/JH9Y6nY/rDeYUbWiFGyeZmYfpPN4p92Rd2Z18XlGJMe2N5hXggX1kbZGerILK X-Received: by 10.194.116.9 with SMTP id js9mr19172412wjb.112.1458931856960; Fri, 25 Mar 2016 11:50:56 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id ka4sm13025530wjc.47.2016.03.25.11.50.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Mar 2016 11:50:56 -0700 (PDT) From: Thomas Monjalon To: "Pattan, Reshma" Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Ananyev, Konstantin" Date: Fri, 25 Mar 2016 19:49:10 +0100 Message-ID: <2016370.aLXS1Y04Ta@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1458861061-11211-1-git-send-email-reshma.pattan@intel.com> <1458918824-15168-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix validation for queue id of config tuple X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 18:50:57 -0000 > > Added validation for queue id of config parameter tuple. > > > > This validation enforces user to enter queue ids of a port > > from 0 and in sequence. > > > > This additional validation on queue ids avoids ixgbe crash caused by null > > rxq pointer access inside ixgbe_dev_rx_init. > > > > Reason for null rxq is, L3fwd application allocates memory only for queues > > passed by user. > > But rte_eth_dev_start tries to initialize rx queues in sequence from 0 to > > nb_rx_queues, > > which is not true and coredump while accessing the unallocated queue . > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Reshma Pattan > > Acked-by: Pablo de Lara Applied, thanks