From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 47133AFDC for ; Mon, 5 May 2014 18:05:40 +0200 (CEST) Received: by mail-wi0-f182.google.com with SMTP id r20so2494026wiv.3 for ; Mon, 05 May 2014 09:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=BwcZkAsLq9GDVCecCtxlKEooDonr8UW2SkxxhiipJW4=; b=WOAE55HPoPESORnPxtWNzaHbh/rwx1QNQYg26XYVNVx/NxsY5E6qzWwLRSPn2FVH/g mZFvTTC2Qb5W2ibxaQ7b9mM1PBvWl+/CIBSE6LXXPVFzSPd65abQi7PbTJI7vrt4hGma FM2Ll7Gn+VrK0UnMg7qKVplXiUBwPp4KkyjbKSEzelWlFwsIUDSiBRcQ4QDb5gEU0KA8 K3U/AcPPJcDYMK8tJOC0ov+vhG2lW+QaA9xnTTlBAc94P/h+C/KL3/zBlJpeJ4ITtV4U 1Aj6I4T6CUL29eFa+7jp3z5j22P6E1jEO4rAO604TIPfGR54BZq3BXg2OACTjCYBz4rz EDgg== X-Gm-Message-State: ALoCoQm0kBa/D4pMevyeT6y51CnR05vhjlwy8GX5cOhsvxTh8euqPNwge9DbRTe9Z0uG+HN06ywW X-Received: by 10.194.120.68 with SMTP id la4mr3668495wjb.40.1399305945586; Mon, 05 May 2014 09:05:45 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id vc2sm17618424wjc.2.2014.05.05.09.05.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 May 2014 09:05:44 -0700 (PDT) From: Thomas Monjalon To: David Marchand Date: Mon, 05 May 2014 18:05:43 +0200 Message-ID: <2016976.lP8QZ899V2@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.2-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <20140418132323.GF4053@localhost.localdomain> References: <1397825888-24399-1-git-send-email-david.marchand@6wind.com> <20140418132323.GF4053@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: remove unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2014 16:05:40 -0000 2014-04-18 09:23, Neil Horman: > On Fri, Apr 18, 2014 at 02:58:08PM +0200, David Marchand wrote: > > There is no need for a 'magic' field in struct rte_config, as this part of > > the structure is local to each process. All threads of a process are > > synchronised because of the run_once atomic. > > So remove this field, as it is only adding confusion when reading code > > that > > references 'magic' field from struct rte_mem_config. > > > > Besides, there is no reference about the 'version' field, so remove it as > > well. > > > > Signed-off-by: David Marchand > > Acked-by: Neil Horman Applied for version 1.7.0. -- Thomas