From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 79C382946 for ; Wed, 4 Jan 2017 12:01:30 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 04 Jan 2017 03:01:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,459,1477983600"; d="scan'208";a="209500903" Received: from debian.sh.intel.com (HELO debian) ([10.239.67.170]) by fmsmga004.fm.intel.com with ESMTP; 04 Jan 2017 03:01:27 -0800 Date: Wed, 4 Jan 2017 19:00:30 +0800 From: Tiwei Bie To: Jerin Jacob Cc: Jianbo Liu , dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin , Santosh Shukla Message-ID: <20170104110030.GA22291@debian> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482832175-27199-15-git-send-email-jerin.jacob@caviumnetworks.com> <20170104100912.GB6578@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170104100912.GB6578@localhost.localdomain> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v2 14/29] eal/arm64: change barrier definitions to macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 11:01:31 -0000 On Wed, Jan 04, 2017 at 03:39:14PM +0530, Jerin Jacob wrote: > On Tue, Jan 03, 2017 at 03:55:45PM +0800, Jianbo Liu wrote: > > On 27 December 2016 at 17:49, Jerin Jacob > > wrote: > > > Change rte_?wb definitions to macros in order to > > > > use rte_*mb? > > IMHO, regex ? is appropriate here. > https://en.wikipedia.org/wiki/Regular_expression > The APIs you're changing are: > +#define rte_mb() dsb(sy) > +#define rte_wmb() dsb(st) > +#define rte_rmb() dsb(ld) If it's a regex, shouldn't it be: rte_[wr]?mb or rte_.?mb If ? is a wildcard used by shell, it should at least be: rte_?mb But rte_*mb is easier to recognize, and matches all of them. :-) Best regards, Tiwei Bie > > > > > keep consistent with other barrier definitions in > > > the file. > > > > > > Suggested-by: Jianbo Liu > > > Signed-off-by: Jerin Jacob > > > --- > > > .../common/include/arch/arm/rte_atomic_64.h | 36 ++-------------------- > > > 1 file changed, 3 insertions(+), 33 deletions(-) > > > > > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > > index ef0efc7..dc3a0f3 100644 > > > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > > @@ -46,41 +46,11 @@ extern "C" { > > > #define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); } > > > #define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); } > > > > > > -/** > > > - * General memory barrier. > > > - * > > > - * Guarantees that the LOAD and STORE operations generated before the > > > - * barrier occur before the LOAD and STORE operations generated after. > > > - * This function is architecture dependent. > > > - */ > > > -static inline void rte_mb(void) > > > -{ > > > - dsb(sy); > > > -} > > > +#define rte_mb() dsb(sy) > > > > > > -/** > > > - * Write memory barrier. > > > - * > > > - * Guarantees that the STORE operations generated before the barrier > > > - * occur before the STORE operations generated after. > > > - * This function is architecture dependent. > > > - */ > > > -static inline void rte_wmb(void) > > > -{ > > > - dsb(st); > > > -} > > > +#define rte_wmb() dsb(st) > > > > > > -/** > > > - * Read memory barrier. > > > - * > > > - * Guarantees that the LOAD operations generated before the barrier > > > - * occur before the LOAD operations generated after. > > > - * This function is architecture dependent. > > > - */ > > > > How about keep the comments for all these macros? > > lib/librte_eal/common/include/generic/rte_atomic.h file has description > for all the barriers.All other arch are doing in the same-way. > > > > > > -static inline void rte_rmb(void) > > > -{ > > > - dsb(ld); > > > -} > > > +#define rte_rmb() dsb(ld) > > > > > > #define rte_smp_mb() dmb(ish) > > > > > > -- > > > 2.5.5 > > >