From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0049.outbound.protection.outlook.com [104.47.33.49]) by dpdk.org (Postfix) with ESMTP id 9EEED2C37 for ; Wed, 4 Jan 2017 13:59:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CUjP5uX6ObmsH+U+4G9plefw8+VOOjvOaBOlb6Ce9UA=; b=Sc3Aw20L/l+Ffw0h9heD197YLF+2zr/3KJvpqb19Wdd2QQBr6yeJcXEK1+WnRM+qFQJlolchvfgA4dbnHxwLZxjw6C6Kpd1FeJPd6FbT8Q8q8xEYZZ/wtcKqsbgXpR5amINdjR3zV6tE1iD08MVL+hYyIm9WBOqv5moScttr880= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.172.178.75) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Wed, 4 Jan 2017 12:59:47 +0000 Date: Wed, 4 Jan 2017 18:29:26 +0530 From: Jerin Jacob To: Ferruh Yigit CC: , , , Message-ID: <20170104125925.GA19798@localhost.localdomain> References: <1482833398-30145-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482833398-30145-2-git-send-email-jerin.jacob@caviumnetworks.com> <20170104110144.GA8258@localhost.localdomain> <408187b4-83b0-603f-011b-583d5d0e9716@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <408187b4-83b0-603f-011b-583d5d0e9716@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.172.178.75] X-ClientProxiedBy: BM1PR01CA0046.INDPRD01.PROD.OUTLOOK.COM (10.163.199.18) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-Office365-Filtering-Correlation-Id: 4810a41d-ae52-4bc8-8da8-08d434a1916d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:GbF5jwp6rD0Ki1VnazgdksgoISnfGv3oQn3dl5YwfhCsUcsasnt0/5d2zeY1umaxcbsNy9aUo/PycW6wgC4emN6W/7FvlqCAS7Zunyl+TYEc+NlYPt8ZZ31OTlkCbrxAOGffO7uXgP0tngxzEvqTT47oCR1BjC7urU3PyomV0FFv4zLb0eg0WBU2DBWpyO8R0r6CWr0fgQuj6myRNcFrStWED/Mme7fN4CJyLSSPXg2UekmHFgTvqwXRSmNuJfmYwu7Q9EWGD5tldUND/D6stQ==; 25:6RT31Y3hehh1xrl9A5pE0MgJlvyr00xfoQLn1N0D0xvM5cGBczzY55xBqbqGgO/2uygrr4SIM45zBScxsVpaJ/3/O7H2Wf8R2muES0XJoEUBkSo6Ul4BrNf+u54tYq5r0QzcfKP9GAv+6k9r6B40Yx/TO+NyvniwUE2pbSn9cMXt1g4E+GSgrxq7JDKg6x6dbTVJcI01/mueq/mX2lzgNOpJL9sZbcX3GBBSxZoFZLgeP4Sy/4irDr2/YO4k+1xP1fkSxqJucfIaDCV5GL/gmTr9sHKhMLS6b8uSWBbh+hYUSyrIqQYxHWhtaHTqhVp4qd+4GqgQZ69bNkP9PumY+10ph5djb0p7EUmcKW+MfUrrl/mTk+2hKWnCaBX0dSR+DyonNk5Ju8mBVhOrmSKhSs7sZkKvIviSF7wpvrJLZ2MedxjmauoSuAEbMiTWDnj0+W4nm8yRgfrePEiijCg7Nw== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:3ID3SU7VhzBeu3pnTxIqWq82P/pvvugH0RzExb+Dq/HEsjCHHvVE1mJ5VqOjKgh1rdL0sSVWZ3ZU3Jt3BnTW/lhx6JqUreFfpEndIoezlHn2w+5RwdhwOWogJpkjrZDhXj7+OvZfPVxuywkj1t4Tf80QkdSxejhzIfp5ewGwxT5RTuHsJKeWIllaWgvY5tw4FcL4Ye3ugwoyViD2giQnUtX8aTKs4bIS30o+bdzYtmhtIuBcj3Ie6fBHm7HL2IAFkBcRkAc/8uFurNAxZNuUQ1wuWS+z5hfVlaeVkcsbV7k=; 20:QGUKG6OW0XLmSNUTJvPVEKQoHevO8Y70BVRuXpXtYAnb8gi11Wl0D5e30Ke0lYuEzdsWhFIihphebshyNEQhZY6E5Gc1JK3jenfHtMsvY0G7dsrPtw2QJaLTo2IyYT7jlxZFakMDGtCJPLizgP7sfp2I/PrZUufyyM7+nroRUytCkTkJ/GhL6oMjhjbdj/qVM0oEdsR/IX/Swk8UWY3mFwYdG2b9Q1egGOdc0GesQo/fLMh6g4wZHNRJAzdCEsaKbzyt7f1XXPvEwKhfML4I024nVpEiTPH14MK1dE+0K+ZnMeQEG79kM3ueWyr/N1Je51WSeNzdn7C2RO1O2NDxsfkEBhx9wS116Bf/slhP6570z/RpWgNiz905o8zDVqmC1+8fZC+yNHRnUUZbMNxHDL0MPwWyQUribGF+/TiYFl72QrYM2N51qandMhZvPzgfrhN11+0z3SlhPyQD/nNcgXWJBpwpXySSM3ax1cFJD/63sYKXyfmVFDBfPf8Bhq/Z4KSivGGmAXq1P2bYj1nAdAcCylrshJiKflWM+OwN9huO9/eFcvvY1/MgDU+97awRHjSQulZsUFFkKnBU5L2pwo5q/bc3hX/slU2qklQH9hs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 4:+mmU86Dnby1Hnm+5GrsElMBiH+IrX9xm1O24K9x9h/4m47X5VTYo89Iohnbt5QjRafb58oZTEkmUCeo+Jrgt/ToHvE0mBYwpYjjGGUknre5VD82aDk77M1fC2YxGyKJXU1yHx5rlErhF9xLK6R+oFLtaSjMMlpsrOPMZFeyLkCRRPEx5+rw845T3kDKKZ4tDgDvn1EaBkR21YIsZ7DzP9eBRDfBo+WU7QyjhZQwJgE4UmsOFKfqNSCgywr/vekMzems5r/yEw4pMeNUEtnIIxmnfl9BMBfMpPdPT9FpOpEm1kAldUVsOKfr+ffzKojijmVJKPDkYbQiIiQtS6VBOoLapCmwDEfKf81L6Fc2cWejhYEFlXztW+O5B204IRK6dO7z0anHJG4n1e8k8k3FnbdQK9z7GKHTAOtna1AUXxnk4OzdE07iodrhSsVfU3+O51seHqJ7+l6XrJWDJRgHJx7l285TE19Mq4kxfsVjhCLbE/wrPgl1E/7GU4daZ80siiJcr9SHf19B51jT2l2Wd8n/KhnWFbZdfs16Q7ROpPQCSb+znKEvpKgqWHgteyKpcK0bFbpLGlSMLc4UAEbdjBZEnCcuDFRAm+SLhlhQA8W4zITEAmOxWYIw8+992vvgD X-Forefront-PRVS: 0177904E6B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(189002)(199003)(377454003)(24454002)(5660300001)(6116002)(3846002)(97736004)(4001350100001)(9686002)(54356999)(97756001)(47776003)(42186005)(66066001)(189998001)(50986999)(101416001)(76176999)(92566002)(68736007)(61506002)(33656002)(55016002)(305945005)(93886004)(7736002)(42882006)(2950100002)(54906002)(6666003)(46406003)(25786008)(6916009)(229853002)(4326007)(105586002)(81166006)(38730400001)(106356001)(50466002)(110136003)(1076002)(6506006)(2906002)(8676002)(81156014)(83506001)(23726003)(575784001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 23:9sYlKlDMQwq4TRoOknVl9IO0cq9S7tURTFo0wKq?= =?us-ascii?Q?zJfMEe8Y8y8wQBN3VfWK0szgtKLM55W/QnKdHSuhdv6YuiD1TMxhWm04JihM?= =?us-ascii?Q?FPB+WWosVPwcTq3vE3+6sOPPto6YLxHfXNOnLjpVDYWqqgmS9fb5mU7jV0Bo?= =?us-ascii?Q?xRuvxHzhHTiqKkHLq1BVFLpOXnO//xgM9WEmBFX/tYONoWar612brHarZGqw?= =?us-ascii?Q?mQLWlJ1IQhvlJGgAYrmH9ils/Cea4F/dpKQ26P+wchyFLLza5uliVFz3pIKI?= =?us-ascii?Q?8khuK6Y39IE7mG50PRlJcZoheh5Okda5ddzGSBHZ5QwRoL583FCW9Crkfu+s?= =?us-ascii?Q?pizcxLc45JKsGdilR3DJnC2zo3rYCr8mCUKePzzzB6OCYULaaCspJC5I6WF0?= =?us-ascii?Q?y3AGFakV6VgGCw9JeOk+jstKVcnoRTbNjbO5cfDNYMhwHBQKUNMYtyyHVKI9?= =?us-ascii?Q?MbOl+TnhiWYgef7628wt7SDAFzka4EeVPKZnhyiNMWEFbXkvut03JSEMu1OZ?= =?us-ascii?Q?9kjR7YvI3mTe6Y3mPcbD7NdRunGSTUVhjFJ4sPka4V0D0VLZrXW5qwTW9nBE?= =?us-ascii?Q?kxn3kpbCLx7I27f9tbg7J+hf3wNYIRIvvEVoyTOACqA8N9DcRHvav5DYPVX8?= =?us-ascii?Q?PtenEqeREo9zu3KgrDGmyEtodyckBvYjdEq9tfjzxWkybgbJzvRMAcofsoQS?= =?us-ascii?Q?TK0jk2WnBx2kiXXRgPit499TYnd8OfB9IcSY4Q18fIBi7RPSq25edHELs7A5?= =?us-ascii?Q?PQhJG3lIGHMsBvAamhaEm23TORNl0JuCKEE1/xFWFfzwR0QvpdqJentsYK5J?= =?us-ascii?Q?nTqNosI9kIjX2myV4NqiaWdsFwAU2GYD6mbI0HPo50pv+gk+XJVHFfSIU53Z?= =?us-ascii?Q?2Xp7nhkeKn6/VF6XXpa+qzrAnpjSQi+EQ1b8wk2HgZt6CFGq8EVZBhM6P25l?= =?us-ascii?Q?WieCNJBgysrhfowntIEvWyAKb0OhYr0Z+gfZau6GzUoogtGqbvjLzFnpnbSl?= =?us-ascii?Q?S8D+e+xeQBY0VGChHfwYHcYFXlhJKodnR1qaesHjjq1v8FBS8lKoHq/JcWp3?= =?us-ascii?Q?y8mXP+xOjjhK4zAMDHokTHG8nb32VWh1zFpd4y7SsTDTd+hovfTOtAlWl31U?= =?us-ascii?Q?zYDTRDcJqDD6/p5UrOv7jrG7tIN1wH95UNAxc6tqwc6oRZJwpsys/2n6bzNh?= =?us-ascii?Q?o+KCoEKHxGrVw1OnE67lDzn+FpNAel9PmqPgThkZA6FDYx4pyzNexxySVtZs?= =?us-ascii?Q?+XOBPEyD0FCIHAFL/BVmShWWe9nWw73rKW0p85faLrpqOctDbz68+k63lrWb?= =?us-ascii?Q?6VP3C6Jg/Js+lHBvzGFp23/pchj3ztH0I6QDkVt6zlPP1?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 6:cdY0RJ5I6J3WpOxiN3lt6MGmKdChTKhvHo06DWiwdUthB1yxH/yIGo5Wi3h15BKNVAWDs0QowSaMrj9/LHOlccEjJwnmovSaBjtt2Uj29u5jasySUiMUP9SkTOyvNuD7idy/ovC/ucCn4mtgskbfe5Pr8JK+YlpSmbbqlBZ3xNK2rugwhJnoz5p/6UiMKi1rIBElj0lTp9e+Nm+CZBbXNJoI7M8MmMNa5EsOyD0G89PnqoPvu4Q1sqwrlmhflx3fXKWqirAxNpp8jRzVRe9gufcpyu/wWsXcvOXwT28dHPkE2uW/pVQKtEEqWu52ttgB62vR3yibe2yQ7L+fu1LS/+C1EXKOFNn3/ZDSLpzMaXfzoh5X2R+BwzBO/fXtCmxTG0QpsF+HkD+8yci5dzG/5NBRCzCiGit/oOTtgZu+rJw=; 5:+w3WNogBY5tS0mF152Lw48fFGRz5YOBupmDm0hLK5BHSlpNYGTRtF4mgdwCjggqFLsxVJf4WE/tGcG6JiBvCFs76RDamHPGFGsTBBRvCWhqw7cGNO8AQCn8QFxprRtwYT6R8RUc4eKBn/CK+ccGV+XoyDlQmNotbRt+ZUrdftx0=; 24:giQfrAeamBqplbwH/7LxtYfUNStwDgJoDQfVfrCkRq8skixjIGQOke2I/Mu7y/Ixh+LChWPZ3CjyURwy3yAA30ZgjF5BOXRMGlX8w9QgJmE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:819YR6qRmhKDMxRPEwS2SoKgWLnJtETP6FALLgNi8HjexmcblwnkP+AKcSdAly6r5pxmqCaxJTNhKpRAkg4Wmc9LPfrX4Y1u3K2TpUFozLN8L54zlYKhmrf5FgbkCYizNBEx3ZOqIwlJdYUTE7+gJpCLIOt5o6zJd4HDYE4oKEWTu4zzX0M5C6LSwj3wF23JA5MyBbOYX7yxjHZMbbmwH/HI+ABNujpdeTSv/lu733wk22VD8ilShC0BdR1KbDix03eTWwPig2l+au+/BgVwnoMEbYVN7SQufHhZQbNel1oxK9DAEKkMx8s5JeN0zTbOetc4acPZv2xOzOMDiAHtB9puQ0fgDZ4kewvSDoPs6NXYW+vR6u7PVg0lcI/D84x2ZYI7vL4SrKjFgHSNlTqPyMFlNelGUunM9/EbRf2w27MLpDbvtsan25GYhXRMNM6hPX3MjLMbFjlSfIxzq6l43g== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2017 12:59:47.2104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: remove explicit ixgbe link request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 12:59:53 -0000 On Wed, Jan 04, 2017 at 11:44:21AM +0000, Ferruh Yigit wrote: > On 1/4/2017 11:01 AM, Jerin Jacob wrote: > > On Tue, Jan 03, 2017 at 01:30:26PM +0000, Ferruh Yigit wrote: > >> On 12/27/2016 10:09 AM, Jerin Jacob wrote: > >>> Removed explicit ixgbe driver linkage request from > >>> app/testpmd makefile to mk/rte.app.mk to > >>> 1)Maintain the correct link ordering(from higher level libraries > >>> to lower level libraries) > >>> 2)In shared lib configuration, any application can use ixgbe > >>> exposed pmd specific APIs not just testpmd. > > ---- > > > >> > >> I believe it is good to keep it in testpmd Makefile, updating rte.app.mk > >> to have it will: > >> - link library to the applications which does not use PMD specific APIs > >> and want to load PMD dynamically. > >> - link library to the application that won't use driver at all. This may > >> break the distributed binaries, since testpmd will now be dependent to a > >> specific PMD. > > > > No strong opinion here as it is specific to ixgbe. But can we include > > ixgbe only for shared library in testpmd so that it won't effect any > > symbol generation in static build. > > I think this is better, I am OK with below patch, thanks. OK. I will post the v2 based on following patch then. > > > > > > > [dpdk-master] $ git diff > > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile > > index 5988c3e..050663a 100644 > > --- a/app/test-pmd/Makefile > > +++ b/app/test-pmd/Makefile > > @@ -59,7 +59,9 @@ SRCS-y += csumonly.c > > SRCS-y += icmpecho.c > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > +endif > > > > CFLAGS_cmdline.o := -D_GNU_SOURCE > > > > > >> > >>> > >>> Signed-off-by: Jerin Jacob > >>> --- > >>> app/test-pmd/Makefile | 2 -- > >>> mk/rte.app.mk | 2 +- > >>> 2 files changed, 1 insertion(+), 3 deletions(-) > >>> > >>> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile > >>> index 5988c3e..96e0c67 100644 > >>> --- a/app/test-pmd/Makefile > >>> +++ b/app/test-pmd/Makefile > >>> @@ -59,8 +59,6 @@ SRCS-y += csumonly.c > >>> SRCS-y += icmpecho.c > >>> SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > >>> > >>> -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >>> - > >>> CFLAGS_cmdline.o := -D_GNU_SOURCE > >>> > >>> # this application needs libraries first > >>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk > >>> index f75f0e2..aee235c 100644 > >>> --- a/mk/rte.app.mk > >>> +++ b/mk/rte.app.mk > >>> @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE) += -lrte_cfgfile > >>> > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt -lxenstore > >>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >>> > >>> ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > >>> # plugins (link only if static libraries) > >>> @@ -114,7 +115,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += -lrte_pmd_enic > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += -lrte_pmd_fm10k > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += -lrte_pmd_i40e > >>> -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4 -libverbs > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -libverbs > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe -lgxio > >>> > >> >