From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 13D2E37A6 for ; Thu, 5 Jan 2017 17:32:35 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id t79so490465026wmt.0 for ; Thu, 05 Jan 2017 08:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2t6E0/1xS1kExgeJ1BueATgoQ6u1K5bTimPtfz0tAm8=; b=b9wCjogG3AZ8lpbZ9TRCVz1OWaGaJzoHFH0RXJSgDevYYWb7BYM/kaNn29ocBRcrEP ajW2jXq2lmMRPKaLTJi0FS26y1iA9BEabdhnMdeEpNbtogEr11VdWO83B+MoMhuONQFJ 8BLyCwbQSMjaJIbrp1tx6oi8YrSXIO5XZlF72mFHF8htdqhRomlt4M8+1InsuObYyr1h 71YTt5s7JJPWNzYmmukOJFZM5mNmjt0ASHrYZvfQaeieFZhqOfLak4leHJF2VZuFwT5a B2TwLVaAu0y2TL6mlRxLCHwuRzrRnML8kzQnEZGbbeGciHqe05MbMx48CJfofualwSEj UY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2t6E0/1xS1kExgeJ1BueATgoQ6u1K5bTimPtfz0tAm8=; b=t/YFBIVuI7NiPPsSj69EuKbR06uwk1QN6GUZH2wiEFccaZZO+2fkhlD4TnajQzc8qV oQ8/1L74LqJLumTyYrEsNnwa6f/t17jjlh75nsMeTpcvzPK6qBZa2gn9gtojH3SqO3Dk oC9nC+fPINQhePjKuXWXZegX/lzzHERLurOxNRAkM7FzfvKfFlvV/sWzw0ttxrVy7FEb WjtfFtHiGHidYXRbuLPB5r8TcWyL/RP8VAp0jzP+MvWCvlJ3SbwLeAz3dodpb+K7VZde el6+0HV5pijlh8SZn4DsplvoOabJQrdibKvqlOHJ9qxMTNtGHF6SBsvZ5PsAI6gbqWOy 1pxw== X-Gm-Message-State: AIkVDXJe4TvmjCIdMNndRIqQ+UjRn6igfd2GOs4dgdBuk2pA+Jhe52gzfJDq2JSeyhddsw3c X-Received: by 10.28.28.19 with SMTP id c19mr59193106wmc.28.1483633954766; Thu, 05 Jan 2017 08:32:34 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id w79sm101010426wmw.0.2017.01.05.08.32.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 08:32:33 -0800 (PST) Date: Thu, 5 Jan 2017 17:32:26 +0100 From: Adrien Mazarguil To: Ferruh Yigit Cc: Nelio Laranjeiro , dev@dpdk.org, stable@dpdk.org Message-ID: <20170105163226.GP12822@6wind.com> References: <1481290078-4530-1-git-send-email-nelio.laranjeiro@6wind.com> <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 16:32:35 -0000 Hi Ferruh, On Thu, Jan 05, 2017 at 03:19:35PM +0000, Ferruh Yigit wrote: > On 12/9/2016 1:27 PM, Nelio Laranjeiro wrote: > > Too much data is uselessly written to the Tx doorbell. > > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > > > Signed-off-by: Nelio Laranjeiro > > Acked-by: Adrien Mazarguil > > > > Applied to dpdk-next-net/master, thanks. > > Is not CC'ing stable intentional, since this patch depends on a patch > introduced in this release? If not intentional, please CC stable. I intended to update the commit message for this patch as in the meantime we discovered it addresses a significant regression introduced in v16.11. CC'ing stable now. If possible, can you amend the commit log with: --- net/mlx5: fix Tx doorbell Too much data is uselessly written to the Tx doorbell, which since v16.11 may also cause Tx queues to behave erratically and crash applications. This regression was seen on VF devices when the BlueFlame buffer size is zero (txq->cqe_n == 0) due to the following change: - cqe = &(*txq->cqes)[ci & (txq->cqe_n - 1)].cqe64; + cqe = &(*txq->cqes)[ci & ((1 << txq->cqe_n) - 1)]; Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Fixes: e2f116ee3cac ("net/mlx5: reduce memory overhead for CQE handling") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Cc: stable@dpdk.org --- Thanks, -- Adrien Mazarguil 6WIND