From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 47EAA282 for ; Mon, 9 Jan 2017 13:02:59 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 09 Jan 2017 04:02:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="51103063" Received: from unknown ([10.237.221.61]) by fmsmga005.fm.intel.com with SMTP; 09 Jan 2017 04:02:56 -0800 Received: by (sSMTP sendmail emulation); Mon, 09 Jan 2017 12:02:56 +0000 Date: Mon, 9 Jan 2017 12:02:56 +0000 From: Bruce Richardson To: "Wu, Jingjing" Cc: Michal Miroslaw , "dev@dpdk.org" , "Yigit, Ferruh" Message-ID: <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com> References: <39ceb2bf1e5aa61e3957a8d8f9e5b2df28d6d2ad.1481590851.git.mirq-linux@rere.qmqm.pl> <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 12:03:00 -0000 On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Miroslaw > > Sent: Tuesday, December 13, 2016 9:08 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability > > > > Signed-off-by: Michał Mirosław > > --- > > drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++-------------------------- > > 1 file changed, 73 insertions(+), 125 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > > index 39fbcfe..4d73aca 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf > > *pf) > > pf->main_vsi_seid, 0, > > TRUE, NULL, NULL); > > if (ret) > > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > > - " frames from VSIs."); > > + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control > > frames > > +from VSIs."); > > } > > You are right, it makes grep easily. But it will break the coding style "Line length is recommended to be not more than 80 characters, including comments." > > Any comments from committers? > Being able to grep error messages is more important that having lines wrapped at 80 characters. I believe checkpatch ignores long strings when checking line lengths. /Bruce