From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rere.qmqm.pl (rere.qmqm.pl [84.10.57.10]) by dpdk.org (Postfix) with ESMTP id 62827F60C for ; Wed, 11 Jan 2017 11:14:14 +0100 (CET) Received: by rere.qmqm.pl (Postfix, from userid 1000) id 1BB916082; Wed, 11 Jan 2017 11:14:13 +0100 (CET) Date: Wed, 11 Jan 2017 11:14:13 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170111101413.nwfapc4grnrbzvmv@rere.qmqm.pl> References: <66806fbdd31de8610a0be5463d813eaf7b816e85.1481592848.git.mirq-linux@rere.qmqm.pl> <20161213012851.1F4A0388F@dpdk.org> <20161213010913.34C8B5597@dpdk.org> <539d7a893864e515b9bdc688ca9d7b975a6835f6.1481742624.git.mirq-linux@rere.qmqm.pl> <8d189949-27dc-b557-6fbc-f9d07fbd5296@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8d189949-27dc-b557-6fbc-f9d07fbd5296@intel.com> User-Agent: Mutt/1.6.2-neo (2016-07-23) Subject: Re: [dpdk-dev] [PATCH v4] null: fake PMD capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 10:14:14 -0000 On Mon, Jan 09, 2017 at 12:07:36PM +0000, Ferruh Yigit wrote: > On 12/14/2016 7:16 PM, Michał Mirosław wrote: > > From: Paweł Małachowski > > > > This allows for testing code which needs offloads to be supported. > > > > Signed-off-by: Michał Mirosław > > --- > > drivers/net/null/rte_eth_null.c | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > > index 836d982..e60516f 100644 > > --- a/drivers/net/null/rte_eth_null.c > > +++ b/drivers/net/null/rte_eth_null.c > > @@ -284,6 +284,9 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, > > return 0; > > } > > > > +static void > > +eth_dev_void_ok(struct rte_eth_dev *dev __rte_unused) { return; } > > + > > > > static void > > eth_dev_info(struct rte_eth_dev *dev, > > @@ -304,6 +307,19 @@ eth_dev_info(struct rte_eth_dev *dev, > > dev_info->pci_dev = NULL; > > dev_info->reta_size = internals->reta_size; > > dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads; > > + /* We hereby declare we can RX offload VLAN-s out of thin air (they are not there) > > + */ > > + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP | > > + DEV_RX_OFFLOAD_QINQ_STRIP; > > + /* We promise we will do any TX offloads before passing packets to /dev/null > > + */ > > + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | > > + DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | > > + DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_SCTP_CKSUM | > > + DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_UDP_TSO | > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | DEV_TX_OFFLOAD_QINQ_INSERT | > > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | DEV_TX_OFFLOAD_GRE_TNL_TSO | > > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | DEV_TX_OFFLOAD_GENEVE_TNL_TSO; > > What do you think reporting offload capa based on user provided devargs, > as suggested by Konstantin?And by default not report any. I can see use of it for people that want to test software fallbacks for their app. For those who need only a /dev/null port, it doesn't add any value. Best Regards, Michał Mirosław