From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0043.outbound.protection.outlook.com [104.47.42.43]) by dpdk.org (Postfix) with ESMTP id 37AE45A44 for ; Wed, 11 Jan 2017 16:52:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rHZPhiacVUoinS3yv/MqgPAPKf2GIu30/ENDnLfNtCc=; b=NF9AsnPkpzDZpRhDAxAgFCO/cawXbwZLgO/x/nHIQ4kjP800LIS7zHm18tG0owXbYgO+59Yflzb09/FsFfgjbaHg75KvHYaLttpaWQ3KvSw3yB0hY4Q6cx889aK0ZDxhKZYa18ZWrcU/IVHozzFaDS16GW0aldjvpEgYEE/l2EQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.36.30) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Wed, 11 Jan 2017 15:52:50 +0000 Date: Wed, 11 Jan 2017 21:22:28 +0530 From: Jerin Jacob To: Bruce Richardson CC: , , , , Message-ID: <20170111155227.GA30964@localhost.localdomain> References: <1480798539-13360-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482070895-32491-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161220111342.GA201880@bricha3-MOBL3.ger.corp.intel.com> <20161220130929.GA5901@localhost.localdomain> <20161220132251.GA211688@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161220132251.GA211688@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.171.36.30] X-ClientProxiedBy: PN1PR01CA0033.INDPRD01.PROD.OUTLOOK.COM (10.164.137.40) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: f43480b6-50b5-4c59-221b-08d43a39e6fe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:uCQ3tR4rAkYFwBClk+Hh2uc0vNfDRsqpUtgymU2cZGsEqOt19Dfd4scT4FPALfcAYS9Bewu5YK1dk0/Cf0xQIXMnVJMB88BkA63ucZhT6eb7DYuKgq8ULk43WbWnwXl7N2Vj8fusU452GJBXqyMM/8o95vQBRuBh80/PL6+aBcgHc79ncNQiaCYRQn7h9cF7yp9iv+8+Ptknb00uZxsE2eLogC7RWNQl4qol32YwGU+w/5SrIAi4cIPAzcbno2MR7X3THLglvOuzBP4I3/W1QQ==; 25:7q731ugRZuWx1mdcxL/ggvgQeQcCkylgBpyf6UtAbE2MM9Y56orMWjVWofkELzXkw7u3TQ72IRh+UqIYAA+Dju8sGVAqTPkMR+agakbuoiBYpsRshdt0+gbtzF1CGF/+GEoVJj647Pty3Te3S7yz46+4WPLBDMR7TntNv7n7e8LkfM8PzhA227Z+VdJCXEWR9DAfO7LmFDCjoKatTXRxNouXorZvYLPqJviUWpaL5Veq7fWw1ot6nDS81G8pLbbCP9N3wWM1oWwAoFKgwqqdpoNzW0jkf2ONNticndSqmn7hokjt8/bKiKadsnFU+VodaA7yAYfdTqBbvnLh8541EALfBPVx0QAG44lNWzBSqOKe971cI3g9JCbwvfa3KbLWNwHMx3/pFOeP2orsZGVaQvJqa9UnPVF/eTV/l6Phb1ZVZs4Npv9Zn/ktVqd6+SXQFikrVNjptz49LA2oDUQnUQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:9dG6WamIIERfKEiXakY39pP/AF+ByykEEvgVL2TyAbiaYtIj3VVdSjJH7A5aV2pkt9J1LAXD5gNtk8zGF35zxjcysdGYVhS+YNZpTqZPquH6dv9atbxPQK5WN7SFitIC821VzSdISNGvyyvgu7A21/zGesngRQt3XT2iCp+xzN+r5aK1uy9ni71p5BOaZzc8tK31Yfk90zZlVIRnhe9LSBtu3H6SXxWEd+j+bdSW9dhI32kCuniqDwOANaLMqJUAUdNZpSML9Bb5mMPv/+yoxQ==; 20:jZJhYz5zj9FhbOz959f6uaoTYecUtvPJzUW3CelN//irGcOCyKByJALmOS3cvcwEkknWUR8O8zlrxKKy/q52+eAATkRHmhBvfADioulu4TQNPaWumN6kILh0OHBlTmF4mFxHs6OLSDPjrbJ85kdHzfK2MBDeEi7s0sV0cAoX6zqG14Jgu+DntxGs7ykXvjMFbk+p1IAZ6FjS2wEopogsfDVJcOlFXCQ+a3MW0uMp261qzQDeLkLfokBZ7WNX9xhxrn4W94EU1CnHrIHFdLmvgS5DbqbDF/8RoV+x5JgQr/8kaoNuqAsq6asRm66g5svUONcRF/1hcD5iXqRb0f2vHv6so9wYC3l8CohFTz73GOQKqZSu/MM+1r6tvDfTk40V4NvKjJHeEey0MHsmO/5apZ/V87GBnr+Gasem1D824WlgMQqcNxbz1LEpXTFhkfN3bcOfh8a3wNmujmpdGSPsirwLzoLhvTFGRWJtNGmc5qAmmQvtEfjeVMDLsoxGGZ8DkrPfDaBCBbf2xoYZOrlcjC9G7vfz6qwsrZvWB4SblJJCaywOC3UE69ifTEsxbMzfMqcCxDPkd+F2YH4slJSuv695/Tecz/36/h4KkcQBgGQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:L7NipbagFkNkSehAnCHM80aoNfXgvYh3B5bX21RvLRgL4EI1Ur4VnAogfLUhyJlZFkm+Ul1Cv2EBVaKTIqOQRUzDWFlphB4F+4pPXyq3zgrmGeCVQM0BthbdWq64Ak4OB7H+8/r7eVIhDGeRq8cXe5iR/g1Ze0w7voChOmWPjUEBRjKLdr0f/FLb9yDHk5v19/40rAsKffaJxUPgVLHVBE5VkrVLswRLpK/R9TtVr+HbvhEFmcVcZPWyg7zFfwY3eNN0bnbG13xaX+0Szyw3Z8m//2MNkZGYtC4Q+MK+W3r5xZBl0YnOwi7sOpoT73WVn9ndOG4YfJVxKzXKtB/CbnUnzqxrsFFIW8HmXWVAXEhx20lT2So4wWZx6egQLcjYY9jojobt37QzpOY/lT5C6u2c0k7zoMGzoMzTV0iumSe/tsXdoJzb3f0BnouF6EHZOakijMfDPqN40FQOJODXzQY0OFc5a23OCWgEO17SeR5f/WVNLWlSz/cf4bsvfufeEU34ark1uFq+CJb9rxFKx4ET+n3UVWcIQMk/jQaLWXMvXAEnGAczRHw++7w+XILZnTe8x9xDQreMlkBLuWcKoA== X-Forefront-PRVS: 01842C458A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(189002)(199003)(24454002)(92566002)(2950100002)(105586002)(68736007)(42882006)(6916009)(106356001)(42186005)(4001350100001)(305945005)(7736002)(2906002)(50466002)(4326007)(5660300001)(97736004)(110136003)(6666003)(189998001)(33656002)(229853002)(46406003)(47776003)(38730400001)(6506006)(101416001)(54906002)(6306002)(93886004)(97756001)(1076002)(15395725005)(23726003)(6116002)(8656002)(3846002)(55016002)(9686003)(66066001)(81156014)(81166006)(50986999)(25786008)(76176999)(54356999)(61506002)(83506001)(8676002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:GBnVMx5zzDZ0tV49CstBCXpQKYFpd5vzrX/+MDD?= =?us-ascii?Q?u9PUKffER34t0iXdeGAJcUiW7wc3u0LXrpSkOEmyFxlTtz9OTaiE0+7NAvRY?= =?us-ascii?Q?JFlATBfx1EZk1HMxIyk9ktfdZwkSdFcv3DkCaKcCTZw0W3KASkzvQQRt3gA/?= =?us-ascii?Q?BGX5sKvGDCd1HGuI5G++ag8/Lk7zg6JrZ48xlcuS8CQMuDPk3Z1TiFxbnnwR?= =?us-ascii?Q?ay+Mvv16FOtd9H9gb+N16ZvVK3fS7yXKB07+0lSyCSri79UkuwjDDvEJGmYY?= =?us-ascii?Q?ArRcQyLWrB5E/am3g7pwecqSgt/7c1S/hTeUDhsH0MLKcD24LwSKTF2aBCYs?= =?us-ascii?Q?4XyRBMuX22U+yq17p4nupS+AqKJSzrENsm0MOKIJjCcniilGAHKGw5aLCD2S?= =?us-ascii?Q?AHWbr8Hk5sE84p0t3pC0YVu8vaO5WRK9HGPA8DrakharA0zMPEfZ1dH1+yIX?= =?us-ascii?Q?eCxRuRcnuwFYritxibvTb3VXc1jOVMC3NhxVviVOfrNxwEKMO94Um5TFJAx7?= =?us-ascii?Q?dqayHexB6fNWN/eY5BnnDLMjExjRnFtPWeS4Fn+Dv7ts63q4nc/A8Sk4prmN?= =?us-ascii?Q?ymzI0DHR/zBDWvSUP6Nek4Is4ywOAjk+LnfjBRhwg2C4K8vqOZErYH5KhdZG?= =?us-ascii?Q?Xj3eiTaybgGbfujzHNgL9mbPvuc9qWSxabTLQSTSZhz+yu1iZwoOzrNCIBcT?= =?us-ascii?Q?LBw6t8FrYrhTI+Z4nnSptG1jaWYwLtae/6d2D157J53iuxvg5EpJVPv29BKy?= =?us-ascii?Q?nDHypDe7MVqS4TtFWu3TjFiCgT2Y7j4q6CxTJmuitFNV4g+DJePTk/YV5kXx?= =?us-ascii?Q?01cuhYzioXMbGd/B8di17c9IxMTc/N5pC8ZPO/noJ4RmLS5rOe0LARlMuq8T?= =?us-ascii?Q?wz4du+GKw8o8p+TsZ1Gw6bPEA2PYplHdTJb8RODVCx66crzZb3XUZPsmRH2W?= =?us-ascii?Q?r3F/I1Obs+vWPzxf8ztMtlbjShLMswy/xYNwpraHcpBf/N8dEbt9A3LA2FeL?= =?us-ascii?Q?Ule4HQFxWdE3mfI1lF5GHjUBjQJA551+WAqzG6g9hb8efMhZNq1hiGxXQk5w?= =?us-ascii?Q?usnMhxOf0rawXI0ljUD7tBUcfTSJ7l31/+IZW5UhAhMh3a7QSt3xK3SJj1L5?= =?us-ascii?Q?f4kCmGhLr0MBbWJ5Ohf9AVyHyUce7XOvq/sKkScZbmyDdTnKclz/rAKQ+MTx?= =?us-ascii?Q?DHa0+xDoLo4lwMTrKwadxbPbfgG3eK0iTRdk8WPrgubHJBfDMesMZQh30HpE?= =?us-ascii?Q?T1O7BbUsydqwp1HV7lJgYkOD8vbSdakMCQrsrx2P2lUDijNjs/H93mCPd6Fs?= =?us-ascii?Q?UWe1HEjmCONHhX60M285qoLijQNSBoO1XEZhX1ocZMIRYXENxRYp+wZjtdPd?= =?us-ascii?Q?wJzcMAQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:7sqgOoyaB0ghvLoRksBGo7VhF9DFJr6l/IAR9Z91/sDwQ861cij1Hg+qeTh1Z/2i00eoPhavTmzrjp7Lexfp/3oa1Yx6uEq/C+OSaBYebdZdQ0fUPRyWLUJN8Ro2z8G/+X/SORxyExicy2zv4wtFlntw85bHZAIlVNHUcHPpzZ5vD+q7K/Qn+uIoS5R8jkOh2uzCFO7T2IkLGd2Wbk3v4kbsXcCZT9wivVHNkNzfAvq2MuiZQ2capYu+N8ijTonfO4/3iWgY8mDXf8qDLhx2uRD2KQ3C8zHqLhhlBy19LYtWx9CxaGKpT+wJtQDHA/XdTLJ69xx4T2ZBYsxwsjF0MfJu7X98o2dstmyIs4p19tnWzM5YYMFJK3Ot+4oEMVURzRYRyrv7xXQ3qBT7yJMcYUFrsMVGwOtdNVadOw4maSA=; 5:VZNN6GYF2Htlr/qyo0kgdh3sSo0n8pCEWu1QrX7WMQJuzgND6WBhr+w8wZ/2ZZiwKk/sJftOr/S8tL5vqOV44yUJHrgdwECrfm2hc5/CuF5Camiau7wuM3YBd04HCZa9KA3TviayuJTGqUAeOFQgDA==; 24:puafJ4PEyoYVEfCZELoQwQv8R96r7Yvh7Z3lmTm86Z5VBpgoKYQFDi4SeIoEZ3fJR7SHLHYnkqzt3WemE1uBhosHTCR54p7WpNLqbeWeSnk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:A6fZXEiAShL881aXL72s3GBeHexUgou4Z+jEIrhmlsdWGJYwNu1YP1syYK9WbvU6VxhbVAbcmNduB1Q9Sjl1NNhi04wD+WOBcvp0/uPrIrfvC5L4m/YAfHYOY2pZDRO2j97WoB4ooEMiwbSpYIEcS0bHoav7mO4/CqhJabV+yzbjJK9PHx1y1GB3HKgINAya/RBV0PT0IgdpYj15k3Q++yl2Fm4DM+IaiyReXa+t6VqjKmS2RZoj4gsNNi/JvBZnI1t0P/QRAOGFSCDI0SxjADFL4x8121Z/KalKnGLR5bBZhCBcx7vRm7as3Yt2mo5kgZaU/w0U8GEo4HnK0BW1njYjzmR3FoENhPewSYjC6WRsm8B4iYscc4qicgFXwJvxUcmuny0t7WRqDVjFKyA8EajiNN5vnTQyM7LiN3vkVYOd6S6o4JymqDlVft7ut2hECCem7lyLcvCQlfPVAM8KFA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2017 15:52:50.5452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 15:52:55 -0000 On Tue, Dec 20, 2016 at 01:22:51PM +0000, Bruce Richardson wrote: > On Tue, Dec 20, 2016 at 06:39:30PM +0530, Jerin Jacob wrote: > > On Tue, Dec 20, 2016 at 11:13:42AM +0000, Bruce Richardson wrote: > > > On Sun, Dec 18, 2016 at 07:51:29PM +0530, Jerin Jacob wrote: > > > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > > > > described in [3] (also pasted below), here is the first non-draft series > > > > for this new API. > > > > > > > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html > > > > [2] http://dpdk.org/ml/archives/dev/2016-October/048592.html > > > > [3] http://dpdk.org/ml/archives/dev/2016-October/048196.html > > > > > > > > v2..v3: > > > > > > > > - This patch set is check-patch clean with an exception that > > > > 03/06 has one WARNING:MACRO_WITH_FLOW_CONTROL > > > > - Looking forward to getting additional maintainers for libeventdev > > > > > > > > TODO: > > > > 1) Create user guide > > > > > > > > Jerin Jacob (6): > > > > eventdev: introduce event driven programming model > > > > eventdev: define southbound driver interface > > > > eventdev: implement the northbound APIs > > > > eventdev: implement PMD registration functions > > > > event/skeleton: add skeleton eventdev driver > > > > app/test: unit test case for eventdev APIs > > > > > > > Hi Jerin, > > > > Hi Bruce, > > > > > > > > other than the couple of comments I've made in replies to the individual > > > patches, this looks pretty good to me. Only additional comment I have is > > > > Thanks > > > > > that some of the macro names are a little long, and maybe we can shorten > > > them For example, you've added "_FLAG_" into the config flag macros, > > > and I'm not sure that is necessary. Similarly, I think we can drop > > > "_DEV_" from the PRIORITY names to shorten them. > > > > OK. I will remove the explicit _FLAG_ to shorten macro name. > > The _DEV_ in PRIORITY is not that long. So I would like to keep it for > > consistency and to denote it across priorities in event dev. > > > > > > > > Irrespective of these naming suggestions, once the other couple of > > > comments are taken care of, I think this set is suitable for merging to > > > the next-event tree. > > > > I will send v4 with fixes and your suggestions. If their is no further > > comment on that, we will merge to next-event tree > > > I'm not sure a v4 is needed, unless you especially want to do one. > Given the scope of the suggested changes I think you can just make > those changes on apply to the next-event tree. Applied to dpdk-next-eventdev tree. Thanks > > /Bruce