From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0065.outbound.protection.outlook.com [104.47.32.65]) by dpdk.org (Postfix) with ESMTP id 7D77E2BF3 for ; Fri, 13 Jan 2017 09:37:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gWvXXiCuo4jelrv/ttLjWADu/7Fc4PBwwJ/AmPbj53A=; b=L9TyVDvDAOK9z3DFTpxgfa6oiu5sxh8I/gUmq0br6TixJ4EwBwrs0v2543wf3boGEjD1Z/jF6LuxfGqu6xttjy6hzc/6pZ2d3ydtiNju+iChnU+93OlkwMnspZxl3pz8ldqTaQPs/TiJ7pmijM7OuXn7hwn+EDUNxKeuLtluLv0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.61.97.114) by BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Fri, 13 Jan 2017 08:37:36 +0000 Date: Fri, 13 Jan 2017 14:07:16 +0530 From: Jerin Jacob To: Ferruh Yigit CC: , , , , , , , Rahul Lakkireddy Message-ID: <20170113083715.GC19741@localhost.localdomain> References: <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-19-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [171.61.97.114] X-ClientProxiedBy: MA1PR01CA0008.INDPRD01.PROD.OUTLOOK.COM (10.164.117.15) To BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) X-MS-Office365-Filtering-Correlation-Id: 8fdecc37-7510-4d14-a968-08d43b8f6fcd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 3:xyVwSF3G0OXrKvxqiOhIJL57DXFxe0buslZu7jk8xa/KIJGRl6S6/5VeJx/TC7w4u/Osr91BgSuUPgDpdjQ808cc5vzMYOzV8S8qNJSV6KU3Ukt2pGRFN3SP2vpCMmix6CuFpZthMDJcwLbeM2dvO70Ssng4d30J8WejcQ65Ei/oUqLr9/089NeOT2CRO8mOPXC60Ok8TJLSw0/uEaOer1qw5Tp9bXLb3Y2ejZLU1ijp0PBIlPO7/duBWbwK5v0cF38PbmX9r5f5pO01b+zWng== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 25:DMpRyrxKwa5LLud3RPEAZE7LNiFV/pH9DudPS9/1v2qpWDZ3hCEh0vKiL+Ac1fGH3MRMlrzroYB1a/pcNs5Uval0YXHcZxxPyMnZr0adx2zUxfzM9qwfAKVZ/9Rqi2lCD2aaT3zfoVIjlMSewayA7LATW0FWBfOvJvN6saMCYomxM3Mqc4tiQeSo4CfVVJhXSJ8B04llCKSdZrFn8hwejd/Lef10ImU91n1e6vppJztxyn5i20MjvIFutIX82we0Ohc8FNS4wyLdHAr3jN5niHK53c4Zp336uvjS0CQSFFKUdYRPypAFsI68b6kxt9O/VlHWZLIrI5/acRr8iJCqqHCdWmOXhrBE6s5shXnXTBUvinO/BlMmO+0JdpXFzA4FDS54vx2Tc89fOyGpBKt2R1Myv3WBV5hAQ5w9jVpx6ubIb2MecYFvOXdhBr8PP9AgswOXDVKywNJoGspYmBtjVpTWcftcrSwhDD5iWFQotq7ciCcai91Q1XKHD5snNEoOUrl/uT5LRv01Iysge3v6HluP27jO3MiUzn8PKV+jfgBU7TrUg2oZvjvuYBoct7VXLv9tvidDj7UGn7slKjXDTUfRxVZ0tJOLYPykonGF2tpClq4MCCRTcXIqtFGdsY/eF6vmnPCoWPnjW/58//Imuc08SvFD7HG5ldfE5lFV9fCjCpySqUuOhEm+q9mksUx3WE05VQyexXJAfO1J2M0bYwjmjq9CSB1Ji4psc7OkS+PzJufNMvmcd9LCnFlUIiVDHpmy8P3cJzQsfX1wpzlm4JWJzvb5rhSM3VsTeS2ko8c= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 31:TvNT5vPuie2q0J7STnJkyxEhjZnA8dqXr1YJ15xiXG35u/477TBTrmaqXesy4F0G8CkU6VRdVVPPm2G9cBXgRMy1WG3qsimvAQbHV5qKubXBDu+b2zzbzdNlA4419eAThVhPZFg1zHCqHn1fBp1Z5/wYUkh2h3btYZdrHJfyflkmqY4JmZIGpT2volZ15UeTtliGF3cgjhFsKHLon4ky22vIly+mg7reMALI/gmL+HHJBnHlcxrdSsoZLh4GNTN2aaTeXrEGbFkbVdZ8bCwf1uMxjpIon70DR/4luFMRmSk=; 20:06wgIx+S/uDbF9uB2458lXGvVxSyPnXaVUuyhy7HVpxJIkYxnFAUHPG58asoYpUBrnZ6u8+f03UDsh9xBQcxvZ3FTMhW8X091608wfxvYnolBQXDgH6QkRhclbkW+0r+jEbOTSEmag59VUevFZ4EpXrV8ZjklvMETTmRc8nWS8Br4pBQWI5dJf09gJefksxnxxAvRzpGJG/b+LsQP4aFe7T+TrZRusx4OeqFsFbNQJPDGmasnVbBoT4uQRAjQP8jhmnnr/s75sBAMmI9FvpxO2KCu/3sm37mUzYL5NMgdrI3v2VTkX1JYQKqg4jMm36AguKefVKue+a4UrdQC12bKqnWRp70xgbn1oC8eBzQCfm1lkxs60x2H86ps2y2pBhIC+4kwp97XxmguFK+snNG5B0FteeN7i7c7tDaT2ZoTAQkqsW7s8Ox1/Vln2iscdTsrmC5zT0yPuIOcemEdcfecf51rLBMYcYRZqWN2Yioks/L83M5gknLBUiwkJb+LU294UgfZZ4LVZH51YRvnpvvlj1jD8L75EWQiBz4ODGJVsHjyeKnbl6l/NVHXEqnE9KJBAMMRnskJLM8xh34+FdgpDK3b4io7k88n7oHGlXK7wI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123558021)(20161123562025)(6072148); SRVR:BY1PR0701MB1722; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 4:0RydjelIdJRS4LHN/RmZjqwWhPEvQgp7/FqlfsGFoz4a29tee4Ze76Ucl+IQJglbpsXWaQqnOGJX1F0KcmqcZ7zYnbWqSVikEizPA+0Z9YWnzJP3q/i0/ybn6rQHp7I+N/FoXEs9IKiQokwwKssVnOj+ew7hek8EGfs0iec+SlUEexT+QZe6hnv8YJjuUDSet3sn3hoSICwpILx9rUTNgQjjWs+GoqrbEyfGPSmHWJ2uxVZS/y4xnYH4QGu81oJqRIW5Y4yNgPrtHC/4MPLqpDj74WnfLRBZkAafLWl33cCc/WCewwBqR0kpP67eVtxqcSHoECJHFCpGoLQ6c8R32exrRmVJ1qDXScJoIc2tzXnJEBXQf7MTDQgpnppRHGVGT9Cp+wLPplKnvKpBd+DQKL3VFyzL9HXyphUNt31K4/BKzgEmQjdPTD8MWtrlNjqi3+q4OOq3gf3iJGs6qF+neaQw8o1pqGTG1Gh68M7O8KcLFgLAmoZFFOiIK0iHr/8i3B8UQrXBFzGYaKoWhzfCOLex4EvaphqtDq0SGT8BXPN8l2PU316LkJ8khrYVMwfSG+okBpr/okhBVAW+RMoCmzXxxwK22Qqpg30RckKDq8A= X-Forefront-PRVS: 018632C080 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(24454002)(199003)(76104003)(377454003)(189002)(42882006)(2950100002)(6666003)(6916009)(46406003)(54356999)(101416001)(2906002)(50986999)(110136003)(76176999)(5660300001)(1076002)(6116002)(83506001)(33656002)(50466002)(9686003)(305945005)(92566002)(3846002)(23726003)(4326007)(7736002)(4001350100001)(97736004)(68736007)(81166006)(8676002)(81156014)(61506002)(189998001)(106356001)(42186005)(93886004)(97756001)(66066001)(47776003)(54906002)(55016002)(105586002)(229853002)(6506006)(25786008)(38730400001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1722; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1722; 23:Oo0LaVb47uzr03YA/VcijGLNzMYWX7hN46n9gl1?= =?us-ascii?Q?89PU69aHCgTo5pc8HWJiv479l8wJSHFhBI2+wTLI7Ju0ADW51wAgW6lYubpw?= =?us-ascii?Q?r6urL0FmCkGdkSCeOBCMBiW1CXlyuK6KI2PiDc6x4qZG41THxDr2JP4aALV+?= =?us-ascii?Q?2snZp+fOlMSMKB3fQc0T59v9WYt7TKswhn0wQhQiwOTXoP7XuxwzNmin1EQZ?= =?us-ascii?Q?678HtMOVuhLiv2DJKRGiZp+HsupzWoFPfYdWAmEMY0CcJXox6j8k7Py2QhVZ?= =?us-ascii?Q?VsLnUVDgXzAi5j4aaA92n5tW6y19ndTvAulzvYdevpoGEXQAucM4uNMXYJd3?= =?us-ascii?Q?AseiSPFctdmYd8rGxJWIZQNyM5fnPo8kxMCkSIMGzizIjnpE0YZv1LLZ/cGi?= =?us-ascii?Q?H9ZbOgjuG587+2icfsCM619ZstjCV17PDx7+NtUIBfHfTq35Jbs43dxnNKuV?= =?us-ascii?Q?v0Z3DW3g6pl0YtpbXyGeOdmqld/uIaZt9W82G/oA+vJscuw3SPRhzdx8Empm?= =?us-ascii?Q?4NX705NqFxBGeMZcf/BjAKUIoJyWy48GRG+1hnIkKxtSq13GxkBHPNpFZcjZ?= =?us-ascii?Q?+ap+iaNT6ktZIKocldwfJz9jtsTM+qd08HpfbkIqP0vxTYFhxvK0rNZNe2q3?= =?us-ascii?Q?+6fx+igpTMqMbt5h/qmmrn2u7QuS+5qN+r8PoG173yz527P0LVGKVZMrFBdk?= =?us-ascii?Q?cw3O14BaxgwoKgHyaZKWpstLkHhsd7y3jQMlTzdlSH9Elha6o6X9TNmp6IhW?= =?us-ascii?Q?QFyNo/AeCyzT+6CpXQd3089ybfEptRbt/+v7qNFnEK/325GK543GQ0cDHjsg?= =?us-ascii?Q?FbG+e7iKNKS3FFc13ZvqAPmzpDsZDKQaRNW+MajwH2ekFwGMp8RSC4QFm1w8?= =?us-ascii?Q?vuMQdQS7fTtJXOkleDRe5XsDwvCvmtxAyDoVwi9WjeG1wPmLwe2PFLRGm+XS?= =?us-ascii?Q?aOxiM1/JY352U7GyZlXThNgGoM48aZxdB9pONfpywDb4Cp2kHlt+V1X9duwC?= =?us-ascii?Q?c0wfVt62fcPpf14VEwW9FAGWZmWgPPk28ABnfSIFiYSH3ZoA2UAtqynz+LtT?= =?us-ascii?Q?B8MCGOnGlCQmL98bgWy5eHyLBB2oPkAEzc3IznuyAoEjzHgrSFIiKDUvKkZG?= =?us-ascii?Q?ETnkeaj+i3z9yR3c9Kv/jqrCVOwWtsrM7pkC5f5PcV5JXolexq8XfEc2IZw6?= =?us-ascii?Q?f8OHi7WT/9F7f1GWRk9bOpUI+Oc6E7mbSwUviZSRpst3xjMwm+Hcs0kNFXSl?= =?us-ascii?Q?XcA1iuci+uP/MA9x8KgwO9BIBZpm29TXCoDoJDDMK2uU68ZXxyrxV82yEWKy?= =?us-ascii?Q?C9QeV/E/cxa3nc7sZm89Vutas8mM7rg1PDMewI3o4YBfr?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 6:Imwm4RppeVLbORQcLLo6wRdoAvROYWEPpZzEOWuyZAaBv15d0J0payBHk5DTMkzvOi81l4v/ohUMYq7SMztzb+PwhrcCKna/cHNx9Q3VCJ4jU+YE4QhvW70osJItHKlt1jE/+DDJwjfp2i65ZuAkhEFxUSx44R//MoCy+pc9ew7QzMB2N/fghzkGiWGpY9NzOypVUT1eOjz9NepeQp8Sfvi7EMyJcPpSZ3AIaI0hfUN6q4EGHQJNRQUR+11LCZZGm8zLWfriu3fzsncn9v4nzGbzd8vEPzqLOuBbThrreA3zxnT4wkn5COcvTeLfIoSIhznM8KZPfTGW0oorNHObOz1rPOFeSX3cRIgG/Irled7mWa40LAWwFZd30hnOL0GBgd734vWCcyjYJoMto2Z99I+Uha45kncBnB/eC5vmeKg=; 5:ht/W75AkweQ24Exn/duO46Gjd4KRWkoifIEsf/itv2oCv0PUipThNTD/zeOp3L/bUap6sDx/VJqnfrib06kcPml8hDT7yqEoTjvH3s4cW3qvqewPpFsqW2T8qZAaDbNkNYXVYidnMLVSgJjBGfBRqw==; 24:QlZD9RLz96aaX3fERt0WfVmbWhOtaEWt2qWSZwvXoCf+gJ3JyrxerWLCQ+0J2AQaBZwTIEDLz99PdFl2bzC3CS94B5nIVdkGdMGDFCMy9AQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 7:UWeIpqmJyKdplC8RgZE5WySIRPxbZNl8ILsjKRIxV0DHo+/gaKuESIsekTbmQFBlv0LiSWO/J2zCUTCe5bWKSXh4gbXdRMkWr5FojRvcPqf+0Rq+mxri7UhcqTmVj1s6wRkFpqmtMbYHsHV7HfFY/6zhG5I209XPKqyVuVGTz3pIDVvr13KaK9Fdg6JDgWLVaT/iWjm7qDYyyJblfdeIPF1u8sh2vPKtHW6U2gClwpHojWy9o6IK+1wj6U2tei/hCx9/0vN0QEOr9CJ7Ozp23TMnbb8brKXulcTdyhZwqvWhsfx6ZerCIuG+xrr7XfzJgTIpVnKgN4DX3F3+yzYA1l/Tb948nHZQq5CSPo85vFCTStVwGu+ah5cSa701VBiR7YY0ps8KGIS/UXC7sQzBBpSDTmiGIix8MCt/H9zPqUulsEF+ynsNP9yT7uGrK7uZucGsa+QRbby4IOo+ajhEaQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2017 08:37:36.1695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722 Subject: Re: [dpdk-dev] [PATCH v3 18/29] net/cxgbe: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 08:37:44 -0000 On Thu, Jan 12, 2017 at 07:12:33PM +0000, Ferruh Yigit wrote: > On 1/12/2017 9:17 AM, Jerin Jacob wrote: > <...> > > > > > -#define CXGBE_PCI_REG_WRITE(reg, value) ({ \ > > - CXGBE_PCI_REG((reg)) = (value); }) > > +#define CXGBE_PCI_REG_WRITE(reg, value) rte_write32((value), (reg)) > > Almost all (if not all) PMD write macros' argument order is like > write(address, value), but rte_writeX has rte_writex(value, address) > > What is the common usage for this kind of function? Arguments order has been taken from Linux kernel readl/writel syntax. > What do you think reverting argument order? OMG :-). If it worth it then we can consider. IMHO, let it be in kernel syntax so that it will easy to port drivers from Linux kernel. > > As a similar example, dpdk ether_addr_copy(src, dst) function argument > order is revers according common usage, and keeps confusing people. > > <...> >