From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B66BD2E8A for ; Fri, 13 Jan 2017 16:19:58 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 13 Jan 2017 07:19:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,222,1477983600"; d="scan'208";a="48500899" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 13 Jan 2017 07:19:56 -0800 Received: by (sSMTP sendmail emulation); Fri, 13 Jan 2017 15:19:55 +0000 Date: Fri, 13 Jan 2017 15:19:55 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170113151955.GA201464@bricha3-MOBL3.ger.corp.intel.com> References: <1482381428-148094-2-git-send-email-david.hunt@intel.com> <1483948248-91364-1-git-send-email-david.hunt@intel.com> <1483948248-91364-2-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483948248-91364-2-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 15:19:59 -0000 On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote: > Now sends bursts of up to 8 mbufs to each worker, and tracks > the in-flight flow-ids (atomic scheduling) > > New file with a new api, similar to the old API except with _burst > at the end of the function names > > Signed-off-by: David Hunt > --- > lib/librte_distributor/Makefile | 2 + > lib/librte_distributor/rte_distributor.c | 72 +-- > lib/librte_distributor/rte_distributor_burst.c | 558 +++++++++++++++++++++ > lib/librte_distributor/rte_distributor_burst.h | 255 ++++++++++ > lib/librte_distributor/rte_distributor_priv.h | 189 +++++++ > lib/librte_distributor/rte_distributor_version.map | 9 + > 6 files changed, 1014 insertions(+), 71 deletions(-) > create mode 100644 lib/librte_distributor/rte_distributor_burst.c > create mode 100644 lib/librte_distributor/rte_distributor_burst.h > create mode 100644 lib/librte_distributor/rte_distributor_priv.h > Run a documentation sanity check after this patch throws up a few warnings: --- /dev/null 2017-01-10 10:26:01.206201474 +0000 +++ /tmp/doc-check/doc.txt 2017-01-13 15:19:50.717102848 +0000 @@ -0,0 +1,6 @@ +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:187: warning: argument 'mbuf' of command @param is not found in the argument list of rte_distributor_return_pkt_burst(struct rte_distributor_burst *d, unsigned int worker_id, struct rte_mbuf **oldpkt, int num) +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:199: warning: The following parameters of rte_distributor_return_pkt_burst(struct rte_distributor_burst *d, unsigned int worker_id, struct rte_mbuf **oldpkt, int num) are not documented: + parameter 'oldpkt' + parameter 'num' +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73: warning: Found unknown command `\in_flight_bitmask' +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73: warning: Found unknown command `\rte_distributor_process' Regards, /Bruce