From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 310EADE3 for <dev@dpdk.org>; Mon, 16 Jan 2017 20:16:11 +0100 (CET) Received: by mail-pf0-f172.google.com with SMTP id y143so55474374pfb.0 for <dev@dpdk.org>; Mon, 16 Jan 2017 11:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3UOCZWYfvwD/TE2a49Ye7FOyJ8bP40WGfqfkSu2yIns=; b=m2+bPPVQToWhjyzOmIzkHSCb1D7hSyLo4U7C2lf24hOBCzQKMCejYZH4ddSnyuWIic RzGaLulRd7LyIE8Bpl5Y/N7gBUQrcXrxdBdDq5wDUOpobFyQShPc5mauyH1BtmuoW051 LwR7+ISehHmT/311LRpr9cBgWah/sRiHvix9AY6DzUY3NKXbeqFfXLDPGhAds4cpmQ96 8out9/qXYL7GnElik3Mijz+lZ19MRWVj/4TRLpj8+pSnwm0sotrMD/MjhYiRcwKMrmah y9130P/PaG6bPjyaE49eC+vqRfZdtJMJKxwbnU/JbfZJs+/trb3fsfRc+toiSx2C8meq dE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3UOCZWYfvwD/TE2a49Ye7FOyJ8bP40WGfqfkSu2yIns=; b=O4e0P+jKQ1dUnUyX/UWERkNXqlLxVG1sJ5Q5Hyk3MSTKHzaH9sUGNT+esbXJDmk+Qk Xh41/XSG2HV18OHiHrAW7GFyGBOKHNUf6awj7CX7XQEf79c22DXNpM3NUjbcA6z2dS/z vevOV0xJyCGzcKxtm3uy4aCX8zY6zu/50d9wiy01kFuTrph2ovcS2qaId7i/iBxf3awZ +Ah9l073SzD7q/pjBtJF5FMyNtL9HnXCTB/kzdycyVYcdn6vRHFTZ8Htsk9qHXckWEUo 8t3Grcaq71OJgYvaSfYjbm08VKSOKjyAxxYQmFHc+pC32NSFz1lqR4gbPUqciNbanT6t gsVw== X-Gm-Message-State: AIkVDXL9fTYpoflGdFEeeRkz5WSJv0MJQlBslpv1dnKqoeNyHDMxtkFf6RlgS3XjqHLD5g== X-Received: by 10.84.217.68 with SMTP id e4mr18753435plj.99.1484594170529; Mon, 16 Jan 2017 11:16:10 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id r8sm12808723pfi.82.2017.01.16.11.16.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jan 2017 11:16:10 -0800 (PST) Date: Mon, 16 Jan 2017 11:16:03 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Jianfeng Tan <jianfeng.tan@intel.com> Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, lei.a.yao@intel.com Message-ID: <20170116111603.4f21a9fd@xeon-e3> In-Reply-To: <1484578022-92705-4-git-send-email-jianfeng.tan@intel.com> References: <1480810702-114815-1-git-send-email-jianfeng.tan@intel.com> <1484578022-92705-1-git-send-email-jianfeng.tan@intel.com> <1484578022-92705-4-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 03/10] net/virtio: add Rx descriptor check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 16 Jan 2017 19:16:11 -0000 On Mon, 16 Jan 2017 14:46:55 +0000 Jianfeng Tan <jianfeng.tan@intel.com> wrote: > + return (VIRTQUEUE_NUSED(vq) >= offset); Unneeded parenthesis in return statement. This is a style thing, Linux folks see it as unnecessary. BSD folks like it