From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A0B6E11C5 for ; Mon, 16 Jan 2017 17:40:12 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2017 08:40:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="1094795812" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga001.fm.intel.com with SMTP; 16 Jan 2017 08:40:09 -0800 Received: by (sSMTP sendmail emulation); Mon, 16 Jan 2017 16:40:09 +0000 Date: Mon, 16 Jan 2017 16:40:08 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170116164008.GB26296@bricha3-MOBL3.ger.corp.intel.com> References: <1482381428-148094-2-git-send-email-david.hunt@intel.com> <1483948248-91364-1-git-send-email-david.hunt@intel.com> <1483948248-91364-3-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483948248-91364-3-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow matching X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 16:40:13 -0000 On Mon, Jan 09, 2017 at 07:50:44AM +0000, David Hunt wrote: > Signed-off-by: David Hunt > --- > lib/librte_distributor/Makefile | 4 + > lib/librte_distributor/rte_distributor_burst.c | 11 +- > lib/librte_distributor/rte_distributor_match_sse.c | 113 +++++++++++++++++++++ > lib/librte_distributor/rte_distributor_priv.h | 6 ++ > 4 files changed, 133 insertions(+), 1 deletion(-) > create mode 100644 lib/librte_distributor/rte_distributor_match_sse.c > > diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile > index 2acc54d..a725aaf 100644 > --- a/lib/librte_distributor/Makefile > +++ b/lib/librte_distributor/Makefile > @@ -44,6 +44,10 @@ LIBABIVER := 1 > # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor.c > SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor_burst.c > +ifeq ($(CONFIG_RTE_ARCH_X86),y) > +SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor_match_sse.c > +endif > + > > # install this header file > SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h > diff --git a/lib/librte_distributor/rte_distributor_burst.c b/lib/librte_distributor/rte_distributor_burst.c > index ae7cf9d..35044c4 100644 > --- a/lib/librte_distributor/rte_distributor_burst.c > +++ b/lib/librte_distributor/rte_distributor_burst.c > @@ -352,6 +352,9 @@ rte_distributor_process_burst(struct rte_distributor_burst *d, > } > > switch (d->dist_match_fn) { > + case RTE_DIST_MATCH_VECTOR: > + find_match_vec(d, &flows[0], &matches[0]); > + break; > default: > find_match_scalar(d, &flows[0], &matches[0]); > } Will link not fail on non-x86 platforms due to find_match_vec not having any implementation on those platforms? /Bruce