From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0059.outbound.protection.outlook.com [104.47.37.59]) by dpdk.org (Postfix) with ESMTP id A9274108F for ; Tue, 17 Jan 2017 17:25:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vy/Ed4gZlKPEdVB9G5oSLEjmG5dbtRBocNlDvKJzgig=; b=l/GPKZlXFGfkyr4J7ElpieNsjU5F0SU0SrfONCmPk6hqfw/d/SaxSjcZ9QpAJoRHV8uXFIsb0Hm3yXdbgs4dYDjWUSjYMaRnADQ0sDE3Bv7hvuL2fJoNfeB2XTlZzVI3kO3ilzu0RSNa0Pnz+ao7DaZfX2kgUHONZt8Fe/3Vdk4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.185.94) by CY1PR0701MB1726.namprd07.prod.outlook.com (10.163.21.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Tue, 17 Jan 2017 16:25:31 +0000 Date: Tue, 17 Jan 2017 21:55:16 +0530 From: Jerin Jacob To: "Mcnamara, John" CC: "Horton, Remy" , "dev@dpdk.org" , "Pattan, Reshma" , Thomas Monjalon , "olivier.matz@6wind.com" , "Richardson, Bruce" Message-ID: <20170117162515.GA28925@localhost.localdomain> References: <1484583573-30163-1-git-send-email-remy.horton@intel.com> <1484583573-30163-6-git-send-email-remy.horton@intel.com> <20170117042935.GA32676@localhost.localdomain> <20170117123418.GA2611@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.167.185.94] X-ClientProxiedBy: PN1PR01CA0007.INDPRD01.PROD.OUTLOOK.COM (10.164.137.14) To CY1PR0701MB1726.namprd07.prod.outlook.com (10.163.21.140) X-MS-Office365-Filtering-Correlation-Id: 6a0058ca-4ccb-4813-948a-08d43ef577a1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0701MB1726; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 3:mIM9R0UIrZeqYVNXJQ53P5JnvfsE8pLcABxKJkVx/Pv4BAbfvksWjSle9y9GCqhPKAgJBlDqAtaG1v/fEeXmtYvOevJg9WtdfEAV9eit6j9ytW/fG4rI+jhq/7S7hpVLcJvBqKR3k3nAxJ2mqHC6cgRRyQekfRUR8d/XFSx857mvL6c4R5TBd3G7OL9ctzMjfMMrosYNsKmoiZIbSbKCM7qKL7UQf2PoEaKEyOnWJ5kVwT/nlLoB2zl/HlC9AkchqHmnV5vn7tX/VyqJpuvDsg== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 25:olX5VaIqk63uSJJQD5zTRRvi9fvLb6bXCIyml4WX7QoBb5Txo7WeBZa3CaiQ31PpHp98Kg7wJncIycMMFiJlkWg1AdsG8WJQx4tWT4bs2rVsaqRmqXLZK4NlpKg3MOgHOea6VKMumElpka8mpk1kF0m7mpu1slUj+URtkgfa/EaKqPVI5QaLADu/RPy6NbZK7+CWWqIGk98Z3oLJ0bPbyeiPqaTm0ai6xvDMpQcJENP6DXcRuroq2kuz1x/JgpqfksugGj4Ur+/0HTXM6foHOBjMULNHkcz7OUmG0OOZHHN7v41GsZ9mX1X2k+wyuh8b5A9Q+qZcZO7gCr6RYeZBwPa8xFAyr8OwQWMTaPJ8GP+uelCsNk0St0n5Eq+trk6v5wIhaClrVr+DWnIKeTXroxlk2aNfv1p6mAlM4Nj5h1rDsgXHppJEf4L3M4dqwCHiaZc+M2G+WPVwX+laiANVJ7w0Uc4TEXzQNe1AmBqTxWG0Pa5jmNmKZADafI9jWXa6AFe1xI6ODtmB7hNSeNAZvDeARYR1I9i/Wxc3mVcrxyHtilXxXXGApqVPFo9imrH7cUsqvEgraccQI4JfHsX9KgzXRBB8Od9aA9w1+GSGzFDDeU2A0058b0/I35PmmkwfaHf+V70kOHzf8ENicnoEobk9Vjl3nVGjyadY8OYr3GSzLJofyzeAQUuEXkM4/YQbDr7ZXCmYpLp1BSOHkjkEMvp1FR03Dzm7IKhPksNW89B9VAb/XhXFwiRfujRckMBUrZTT22Ahy29g7OvOte8cKd/wkLwInHTE4kXhcNLJ8IZiIja8qWmmoYWZt5//o418wbj2cCpAVAvamDKreeZAnzHpcWLMQwVvsQVMhtBu1bZRoIONxQESGIaQ4KcVo/2qKV3DObfNDjLlkAPXrgL3Sg== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 31:HUQVfzfGWrl8a6xAQuMevX5GQieNOY//Osf3ZuTALeL6Og7wgyAcu+YEOZ54s0VKzAJ/FoquupdD5uCmHP3Wa/OHXusqkHrV0QRvY6gkY5LiZfAwe76HhIlz7TH5QgpVelzKBLjWvLq9wuE/XjGsWWA/nSrvyrGVrzI/EM2xiKFCiRZzWMraigHfB2k9y7d3cQTcHKPOagjUi0O8DqqKD7OTsoPVDNKqlWTbXZhEzO2fhFCuYowxwGza6Pu13qa8HsOKadd3LuQjMtYYiYfuBRuBy6oWgkJxXsh249mdFl4=; 20:bUAEuZMyb1CgVvGUMofH0Yia1vC6x0S3EP6BdScwzKcckI3fDRBBBATuwJBvHAzpbOPh3Ur6raM/7ku5/OuptkPUpi1K2ZUkcyyVEUcxnNw4UYpoRclyMfFBeXoq6mUJY6B6uyWchfI3YQNaxitqYdNqTaIijeFobCDTtoa/gzx5G3ln0ZiMIgMyerZCh3i8d9q/Lwake4ha/OVg9G5p+Tjsei5or6crvKBE+TtngdIQS4ABT4ZC5KPorWqYpyN3U2U+7YxOBnkbQM7e0Cf/oGM2HGqgHb50rbiff8W7CZpLT+FfDxSlk1V/r50prFIgS717dDt7KTofF/91r2dPpH+gCMp8iF49Ajjolsb8lc8WizLH10C9vm4ZPphRkoTRBUd5aLY214BUALG8SnY6shcTrfKrtPaefs9g73NOuNJWCXvttWwy3HJmq2BxTsWuqJmqr85ezHWmUJ60t6gviQnl1nQnu0PVA2CbZ2332JYTN9CAdoQt78uQH4BylcGCZhhwNR+OQBPxzQpbMvJHnuqjPPBbfkVb/HB8JvnEpIZx2fHUa/lshetnx3nuZc+W+pm+5cO9k23RSc631G+XY3oVdStpHaCO90eoOX4U+dw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(100405760836317)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:CY1PR0701MB1726; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1726; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 4:aUVbyH13biTXFHHwUGkl6BcKf9hr2HSVQTFK2p8aEKTU41iI6qGt1v/Y2aDX+9bSkYTdoxFgwqfgZwGcAh2UtPJUvg2lBnpET5BeOgiMDtJMmdwSaq6e0iENseCLWpNQKaMv68Bdgs9s0ptuKyOd/tPZIB9Ul78h/Uhpr9PHHu10Jit9PFjmy3rL3c6qRHTWiPv4RN8oSjH8ltnsVzuSKap4vQ5OTdeRFxAQRqMNK4n7xEwFVkgND1PnU9eY6JfkN25FsjSAFEFYi4Xe38j8P+fL1eCS+uvwXx3LxdNnpYOJhCTcnRFOZruzgxlSaA/vNJ/K7MXwddeaTgZgXsrlW1QRXqW8opBn7wb8CyWWCSoaBbmS4+gq5Nfb3Zz5nJf265hkB9VTFfrLk5HcvlJUeE92tGBBYN7MCtqGtpVKkiYtgTobFRrMbTNQqzhfI5C+PFFnb8bXDkFvsaYLp/EWtSN4U6p+MlfoZ1vq5PFVYxcWTo2+QIwjcFHJ8TiVMjv8zDDq6Gb0E6jHLB+NmRVH+C7WLuj5la44OHFzA19Cop5w3E8KtcLnhgHZok9ByniNF7CuKHRb8JxUHlNwbpCiSspEeWVSxHHhN9I30+iWCPVJIrBvLxfZa7oDaJeqg3wGGjf7UK6fPHyERI49blpThw== X-Forefront-PRVS: 01901B3451 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(377454003)(13464003)(189002)(24454002)(199003)(8676002)(81166006)(81156014)(33656002)(23726003)(76176999)(42186005)(25786008)(68736007)(93886004)(5660300001)(92566002)(66066001)(305945005)(101416001)(6506006)(189998001)(97736004)(46406003)(7736002)(54356999)(4001350100001)(54906002)(6306002)(55016002)(50986999)(4326007)(47776003)(61506002)(83506001)(2950100002)(6666003)(6916009)(106356001)(15395725005)(1076002)(9686003)(42882006)(110136003)(3846002)(2906002)(6116002)(38730400001)(97756001)(50466002)(229853002)(105586002)(7099028)(18370500001)(2690400003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1726; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1726; 23:xnofkzfj4Z2OQrD/Vzk0rbR8X5Cyx74SR1uOCnG?= =?us-ascii?Q?N6nvwb/RWfsM6umCHch16g4OI0/PpkXom/9ikImuXAXkD/BFjT5Vy8mczIiK?= =?us-ascii?Q?TWOug5VjIvCsia/nSOcvC0DzjE+xSP6J33fEQFyTEXz1KlVbpKriu88PUNuG?= =?us-ascii?Q?d0BRYn9QA8kFvZpd3Zy2Aq319TuaeVR9wSmhWAxJMeTDbe4tcuRpD2aYeYZ/?= =?us-ascii?Q?BgqkQl6m/bDA5qcbfsRs43OqUcwD7sOxyTF03yaY535j5wG3HfLgKtbtr9Dx?= =?us-ascii?Q?Q5m4LgonA43mVvrjlfbjqo5kAhAKhNLmshFEr5YvXxuHNmmEgU/fM4YjsIbC?= =?us-ascii?Q?XYDJYudQd70ApCxUetMuA2w7AhodeV1ch3O9UP/VJI9sIXqrNbBWINRawQmM?= =?us-ascii?Q?icVa1c40sLtd8wBFaGvZ8gqqAxcM+SOfeQan6ygu3pkYSCsRLbnMDqEC6IEO?= =?us-ascii?Q?xrL04DRD9eyx99rbRcGp8qa/WYH5wPDOkjLGbuRc6rsyGoBxuDxqQguFaPxK?= =?us-ascii?Q?DopKkIjSs7YkUTnJowW6phxQiClX5LCQV4fAzbluJBnrGTFSJpnmszHm8wAu?= =?us-ascii?Q?9C/WquT5XTjloNKUaz1ItYpD2A7/q5CP4VmM8wm06KD1zYAvA4zFWiRiT5BF?= =?us-ascii?Q?bKHXL3SFZ1S7qesWoLxQ4rN4KZmZ4LtqEEeCeRsfEX8rwxVx2mbvam80TtlZ?= =?us-ascii?Q?6hYFi0LSxIfZxL+DNpwGFki477mDM9sjNRVcam0uKczHtfpN05D3G25P7E/W?= =?us-ascii?Q?LHk2QlEo6a0wAq2X+8zEEaupPMj62DnWYuzpBx/gnL/R8lpqrbDy8uSIAFrd?= =?us-ascii?Q?huKOBhvsiVwiH3P9JMwBHm4V7Wq7lh3QRfZWw+TLGlPN/URMkNPJKYCNnt/H?= =?us-ascii?Q?pAWkGHkZWIT4TamabcvrlZPS840BNqYzz8zO5Os0wLs5ixaFOZdjRu+LnmIE?= =?us-ascii?Q?KXJJP03lFPvs7p26RybbNs5JwVaCm/KPFuMw+WI5PZh5m3euWgGYeUTC4d+8?= =?us-ascii?Q?NQuDzHODsJM/PPiHiCcm95dA/fglQ+vRtS6vtaIAomnM6AGtwJsET3tj05Cn?= =?us-ascii?Q?L2FyxoC29xC5VBOgDv402ADYI3kt/+Kw+IfCXLJuO2q5+Crxn29dtDY40zye?= =?us-ascii?Q?jSwBHwVF+rJ7/snRz32IzbIGbWRVzBoqXDca/S72Uv2T8POm5S9wcoWpXRzO?= =?us-ascii?Q?v3IGhjpED9DtltWCexAWFRYlDVK7hT6aoOq8z1piQxKQeCrJ9fqpZeuuRrLg?= =?us-ascii?Q?LK74geiuvODekUFjBMRWr44rI8Q5W6IK7UvuMn6/clKdegk+tpCSbvmI5J9c?= =?us-ascii?Q?U+LMSHbRZgn6wr/+Fte5PfghrRDGRXydgfu7wl5opC/Z7/LwoI+LZ2O70JB/?= =?us-ascii?Q?po2NVSE3G7sLnU/BhHOmVRbC36oiWHs7xJjeLZHBGpx96BPuY3Ld4ncJBSJa?= =?us-ascii?Q?jULhVLCN6Pw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 6:t+lkAh1g4WBTD9iS++EO2wToVVHBRtWzfPbl6QUyHytvH/bl+JhrAO4t3qpUNa+2lFDb1Ox6FFj8UpGM0NYzwBvmImOzabjMiZ+8/ZvqvNoS8jb7KDubIbwAwojGA9L1eA200t9VLJtyYSKVSPv0ZGquFAwFQ/sTKPlMPfpPZlWnA+to8RGdL2W9gHiwTlQihfF7ue5keA3qLYInkN3MbVs3KnL9fnIsjPCaYWXibCTr43kxqe/3o4PSZHMLtff3cRKL3XpqW6mIJNGauBYnaYUWTEcuM5Y+gMMDJZUAQ5euiQZP2ob9zu+mSOC+MPhwQMGMdLlNw8aNx0uEI0UuRPHtZeSYBwsYoZt17sggmhksl/avY8Sl3+V9UrUiqXKQ0Nz2KMDGKIQGzixwnVOCB5qzpL86JtQK1be3m6ey7qk=; 5:swm0ldsBYsLLcpYQYeUh3kK0c7eIlkIJW5xN2AsvKF+CQ8X+AclLI9B2IssCIckL/dxbwpOQI8rJwa5jua3ytHMnZ+cXjQHI1P6SeNLgVcoZ1HeQbhY0sgDKLGqMh6Ipn4kbjZgXZga9SuV1t4g6lQ==; 24:YG5XjDiJvtJneKg49e+uI0+okJdpmENGUJXtjLYxVJh4iw9D1UNpbJBko0UpAeEr6h7R5ASLQ2DwbI/YJiBAmEpjlUcQCWAK7pTdc30pV9s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 7:NEM8nnsnEancN1mslpt4s5kZHxxURypqiWLvlWcIuO1WH1DwMjrMng1iKlWhmnpZlBBrbVS2jsI72SzWz+3pHR/OvzINmiObPxztM8aprt/eVZv+1vqajLW1zE+SrTzmjQphS8wk46hXIRWTd8CPpBl8ggOxA+9Iio9CU22f1Yv8//Uy8plJZTudSD3z1/yN4czsGYvX0ILh9ivBaosXdhvfz6iJiZ4r7iENuPXDkvpAFvoUzrY4hUtnw+qDfOegY13ozPnK/tBtWG1N7I/XvWvgLvKf6vB4VYDh7BYDsCQ1A+Pnth5EGY/WenVpeUYGbBlKrMO3qWDhjEG+Sfv7DH9cjS8B3ItZU5tHY4ZlVMtevgzu0E082aUIJLs7flj0coOtZ96pWvwM1KGIQwvOIbDT876zg1FE+ZRH1OENKAsqjQO2m6W5Ql5MJxyyDw8eiAvebuBYef3rvfIQQO0pHA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2017 16:25:31.6068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1726 Subject: Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for latency stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 16:25:39 -0000 On Tue, Jan 17, 2017 at 02:53:55PM +0000, Mcnamara, John wrote: > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Tuesday, January 17, 2017 12:34 PM > > To: Mcnamara, John > > Cc: Horton, Remy ; dev@dpdk.org; Pattan, Reshma > > ; Thomas Monjalon ; > > olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for latency > > stats > > > > On Tue, Jan 17, 2017 at 11:19:24AM +0000, Mcnamara, John wrote: > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > > > Sent: Tuesday, January 17, 2017 4:30 AM > > > > To: Horton, Remy > > > > Cc: dev@dpdk.org; Pattan, Reshma ; Thomas > > > > Monjalon > > > > Subject: Re: [dpdk-dev] [PATCH v7 5/6] lib: added new library for > > > > latency stats > > > > > > > > On Mon, Jan 16, 2017 at 04:19:32PM +0000, Remy Horton wrote: > > > > > From: Reshma Pattan > > > > > > > > > > Add a library designed to calculate latency statistics and report > > > > > them to the application when queried. The library measures > > > > > minimum, average and maximum latencies, and jitter in nano > > > > > seconds. The current implementation supports global latency stats, > > > > > i.e. per application > > > > stats. > > > > > > > > > > Signed-off-by: Reshma Pattan > > > > > Signed-off-by: Remy Horton > > > > > --- > > > > > MAINTAINERS | 4 + > > > > > config/common_base | 5 + > > > > > doc/api/doxy-api-index.md | 1 + > > > > > doc/api/doxy-api.conf | 1 + > > > > > doc/guides/rel_notes/release_17_02.rst | 5 + > > > > > lib/Makefile | 1 + > > > > > lib/librte_latencystats/Makefile | 57 +++ > > > > > lib/librte_latencystats/rte_latencystats.c | 389 > > > > +++++++++++++++++++++ > > > > > lib/librte_latencystats/rte_latencystats.h | 146 ++++++++ > > > > > .../rte_latencystats_version.map | 10 + > > > > > lib/librte_mbuf/rte_mbuf.h | 3 + > > > > > > > > It is a value added feature for DPDK. But what is the plan for > > > > incorporating the mbuf change? I have 8 month old mbuf change for > > > > ARM for natural alignment. If we are accepting any mbuf change then > > > > we need to include outstanding mbuf changes to avoid future ABI > > breakage. > > > > > > > > http://dpdk.org/dev/patchwork/patch/12878/ > > > > > > > > > > Hi Jerin, > > > > Hi John, > > > > > > > > As far as I know the plan was to reach some sort of consensus on the > > > mbuf structure at the DPDK Userspace 2016, during and after Olivier's > > > presentation and then to make those changes during 17.02. > > > > > > However, I believe Olivier had other work commitments in this release > > > and wasn't able to work on the mbuf changes. > > > > > > The above mbuf change (and addition at the end of the struct) should > > > have gone into that mbuf rework, along with your changes. > > > > > > However, since the mbuf rework didn't happen we need to add the field > > > in this release. > > > > So we don't care the mbuf ABI breakage in the next release. This wasn't > > the message I got earlier for ARM's mbuf change. > > > > http://dpdk.org/dev/patchwork/patch/12878/ > > > Hi Jerin, > > We do care about ABI breakage but I was under the impression that the > timestamp change wasn't breaking the ABI since it was at the end of the > struct. I also ran the ABI validator against the change and it didn't show any > breakage. > > http://dpdk.org/doc/guides/contributing/versioning.html#running-the-abi-validator > > The rearm_data alignment patch, on the other hand, does break ABI. I think > that is the main difference between the two patches. > > If the timestamp change does break ABI then it should also wait until the mbuf > restructuring. I agree on ABI part. If understand it correctly, Oliver would like to group all the mbuf modification in one version and postponed the rearm_data change. Here is the email --------------------------------------------------------- Changing the mbuf topology is something that should happen as rarely as possible, so I think we should group all mbuf modifications in one version. Your issue (mbuf->rearm alignment), the removing of uneeded fields (port id, maybe nb_segs), and possibly other things should be addressed for next version (16.11). I'll send a deprecation notice before the 16.07 is out if there is no opposition. --------------------------------------------------------- > > > > ... > > > > There is nothing against you or this feature. The only part concerns me > > that some set of patches can always override any rule and include in the > > release (even as marking as EXPERIMENTAL) because of its important for > > some set of consumers. > > Another set has to wait in the queue because its not important for some > > people. > > For me, it is not a sign of vendor neutral open source project. > > To be fair I don't think we are trying to override any rule here. > > Also, we aren't the only vendor looking for a timestamp in the mbuf. > Mellanox also submitted a patch: > > http://dpdk.org/ml/archives/dev/2016-October/048809.html We don't have any issue in adding timestamp in mbuf either. The point, I was trying to make some changes like rearm_data only need for ARM architecture.In those cases, postponing the changes due to some other non direct dependency change is not good a specific architecture/vendor. > > However, it is also fair to acknowledge that the rearm_data alignment patch > shouldn't have had to wait so long. I can't really answer for that directly. > My feeling is that it was targeted for the mbuf rework but got forgotten > when that work slipped. Oliver, Could you please suggest how to proceed further? > > John > >