From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
Cc: olivier.matz@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3] kni: use bulk functions to allocate and free mbufs
Date: Wed, 18 Jan 2017 17:03:33 +0800 [thread overview]
Message-ID: <20170118090333.GQ10293@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1484729515-2949-1-git-send-email-s.vyazmitinov@brain4net.com>
On Wed, Jan 18, 2017 at 03:51:55PM +0700, Sergey Vyazmitinov wrote:
> Optimized kni_allocate_mbufs and kni_free_mbufs by using mbuf bulk
> functions. This can improve performance more than two times.
>
> Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
> ---
> v2:
> * CSG fixes.
> v3:
> * Fixed issue with possible different mempools in buffer list.
> * Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
> processing in the kni_allocate_mbufs.
Hi,
Few thing to note here:
- You should Cc all guys involved in last discussion, but not just the
maintainers listed in the MAINTAINERS file. They gave your (valuable)
comments, show some respect to them.
- You can't simply grab the code from Stephen and take it as yours.
You don't even mention him anywhere in this patch.
You should at least add something like "Suggested-by: Stephen ..."
Or better, separate the patch into two: one to introduce bulk free
and mark Stephen as the author, and another one to apply it to KNI.
--yliu
next prev parent reply other threads:[~2017-01-18 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 8:51 Sergey Vyazmitinov
2017-01-18 9:03 ` Yuanhan Liu [this message]
2017-01-18 8:54 Sergey Vyazmitinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118090333.GQ10293@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=s.vyazmitinov@brain4net.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).