DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix queue wrap-around of multi-packet send
Date: Fri, 20 Jan 2017 17:56:47 +0100	[thread overview]
Message-ID: <20170120165647.GL3779@6wind.com> (raw)
In-Reply-To: <20170118005155.20192-1-yskoh@mellanox.com>

On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote:
> When the WQ is wrapped around, it wrongly checks the condition when
> resetting the pointer. It should be compared against the end of the queue,
> not the beginning of the queue. And this isn't even needed when the length
> of the copying data crosses the boundary.
> 
> Fixes: e5291c280c08 ("net/mlx5: use work queue buffer as a raw buffer")
> 
> CC: stable@dpdk.org
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Thanks for addressing this issue.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2017-01-20 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  0:51 Yongseok Koh
2017-01-20 16:56 ` Adrien Mazarguil [this message]
2017-01-20 18:43   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120165647.GL3779@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).