From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 83B7E2BA7 for ; Fri, 20 Jan 2017 17:56:55 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r144so53131097wme.1 for ; Fri, 20 Jan 2017 08:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0zHqQzBrPex+KWlsW4jVQ+5IKJJQsxtzLG7WH6FTNuM=; b=r8h4T9RLN8Rz6BbAmz45wM5mXCSZqBEc9ws6nx9D0P4tsl7IVGyjWukMCzADuKud91 CseeoPNkrFSbX3fsv9jqKLPcTBT6pyV8Si9PS8hU0anynBT6jeoV3OgLkCSBrZf+iVWS D48a5HkQ6QVetn/JJDsbsBKrRh9kFzxXvWLH7D180W3mmC6tRbgdJc1ps8g1KBHJKGJ9 5cvTJTE+8WY+KDT2YZDoMROtaaOMGlPZO/9OTOmZXzqq5IY/HBOV3vRWsK8xrc5t289D waOtqYNZGE/136wI0MyKPvTgadAvzywaI1s6bfbvUShFFts65q7bT+czkeGtA5bkaMrx fnVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0zHqQzBrPex+KWlsW4jVQ+5IKJJQsxtzLG7WH6FTNuM=; b=UqyycsruMoQOJmxqti5HhjHZAoqB/jS2TX2AWK6vY15k4rEcrjL+1dcQM5zJURhKWy SgxYn9n5cz7G6Df3+5B/w1btFQnLM/aW9MJauLTtxK3DL8LWpbkbqUV5Omgn9UxpcpA+ We0hvZZqGwV0xlAaYJTyYiyOFJfrJ6OYADt/7vbLDX+nh61/fQ18kVbyL3jQpI8LBWrz Z4WffFDfbC+4zGjXPX+iU12OQvuKzjMxfrdaphgzNDY9E/yc7+PEdhIsVVKa4zP3dR59 orvCMkD8akyQYe5CiVK1/2Z+SHa0vmKo+LEjzTdzINkx9dNqiaTBUZZ/HN7QRl2avjIu 7jtQ== X-Gm-Message-State: AIkVDXKkofu1bmIcv3ikaazEvtsp4nIL1MegSyC4pgD/1nO3P6XcfFw5uXcK3KgaYgRJgNzB X-Received: by 10.223.135.43 with SMTP id a40mr14360242wra.197.1484931415140; Fri, 20 Jan 2017 08:56:55 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l9sm6996144wmf.18.2017.01.20.08.56.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2017 08:56:54 -0800 (PST) Date: Fri, 20 Jan 2017 17:56:47 +0100 From: Adrien Mazarguil To: Yongseok Koh Cc: ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170120165647.GL3779@6wind.com> References: <20170118005155.20192-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118005155.20192-1-yskoh@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix queue wrap-around of multi-packet send X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 16:56:55 -0000 On Tue, Jan 17, 2017 at 04:51:55PM -0800, Yongseok Koh wrote: > When the WQ is wrapped around, it wrongly checks the condition when > resetting the pointer. It should be compared against the end of the queue, > not the beginning of the queue. And this isn't even needed when the length > of the copying data crosses the boundary. > > Fixes: e5291c280c08 ("net/mlx5: use work queue buffer as a raw buffer") > > CC: stable@dpdk.org > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_rxtx.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Thanks for addressing this issue. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND