From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A563C1023 for ; Tue, 24 Jan 2017 21:49:18 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id c85so37403718wmi.1 for ; Tue, 24 Jan 2017 12:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3+ljYy04GGjSWb0W8nuaSUj5Ixk1iyhyWVVw6FDm2LU=; b=R+XLiknOddUh5yzTMYuwAVy6J1+raNKDbcTU/wjrust+m8euWS2bv/zcgWn3pUbMRU xMz73er2Xu/EyC/dj2Evtgw6lESBd/peC/lZcCUY6GopAvvAIUG/rKU8PZUOqDZwKrEP dUEkfmPANzgdHIRidVd/wPLVDvdX22MlIUiU9tNDBKj3QJz1gFqSUpdqeS42BshwbiLG pUYE0dFgVcBWidrw6zluOh+YsdBbae/QO2iNX74jayeQ5AT4sSmGnLNRHIjKEnJaNLZ5 w0+bO6TbyWedJ7Bo2gyIdVXFXbNnYU6LXq5HGwlBEI/ayR646y9vfXV3it02mz8xb7oA 2FIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3+ljYy04GGjSWb0W8nuaSUj5Ixk1iyhyWVVw6FDm2LU=; b=RWaaT0HVNadwg35U6XZLrhpbNL7gQU510DmKi4UVog45PSO0hC0AwrXv3+51JEYpPx 3/mYZcqXM9p/aWYhjNt930rVD5qCUttghCzsYUQfdVVbW1SX9yhCoJx+jjKzBzqCmfZg SSnDoaDMKNOebUgK6TehAj/t74gVnKKGjiIpy9leJhjLcFHfxrCtM8hY8KCUZ+M6bLea 5iEgGQxYLFrZMEVoB/3RReadldrxyFnX/7jRZmQLcFbKZRUTN6QI9xLlQAQKBdTSggAZ 0S74wXRGxeuyPr6VGNGvoBnKxleK0ugVO8OicT7qwqdADtb4mcHbpxC0bcpGFxKevrRd 4cWg== X-Gm-Message-State: AIkVDXK/JM9Smzb0hKBx50+VhFxuth/2p/lrnbjMcp4eTmZNf98n7EYkOHvXrMSV5TaVWA== X-Received: by 10.28.8.130 with SMTP id 124mr18725416wmi.65.1485290957195; Tue, 24 Jan 2017 12:49:17 -0800 (PST) Received: from emmanuel-Aspire-E5-571.primacom.net ([185.44.151.141]) by smtp.gmail.com with ESMTPSA id w197sm28023606wmd.11.2017.01.24.12.49.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Jan 2017 12:49:16 -0800 (PST) From: Emmanuel Roullit To: rahul.lakkireddy@chelsio.com Cc: dev@dpdk.org Date: Tue, 24 Jan 2017 21:48:57 +0100 Message-Id: <20170124204859.8998-1-emmanuel.roullit@gmail.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 20:49:18 -0000 data value could have been garbage if VPD access timed out for VPD read request could not been issued. Found with clang static analysis: drivers/net/cxgbe/base/t4_hw.c:1577:22: warning: The left operand of '&' is a garbage value } while ((stats_reg & 0x1) && --max_poll); ~~~~~~~~~ ^ Fixes: 17ba077c5c54 ("net/cxgbe: support register dump") Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/base/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c index 7e79adf6d..c089b068d 100644 --- a/drivers/net/cxgbe/base/t4_hw.c +++ b/drivers/net/cxgbe/base/t4_hw.c @@ -1532,7 +1532,7 @@ int t4_seeprom_write(struct adapter *adapter, u32 addr, u32 data) { unsigned int base = adapter->params.pci.vpd_cap_addr; int ret; - u32 stats_reg; + u32 stats_reg = 0; int max_poll; /* VPD Accesses must alway be 4-byte aligned! -- 2.11.0