From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f195.google.com (mail-wj0-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 6B73C1023 for ; Tue, 24 Jan 2017 21:49:18 +0100 (CET) Received: by mail-wj0-f195.google.com with SMTP id ip10so3235207wjb.1 for ; Tue, 24 Jan 2017 12:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YYlAYP0NM1FL8pWPQv6I98DCca7Ncq8IigKyGMJZ/dc=; b=OnGAxeRYD23woudWr5b36n7LQVeFGIMGq9aQ3m6tFaxVnQRBR5i+cNjnqQ4ufXVOcB ak/7FaWZDFF9CIUrcjcWdtM+um4vem66sHPAOifaADy0XXAuC0mngNR367dbVHTM3Z2t 0kNPwiNr49AU1vZL1NaJ+AVB7EaQRad/d2/nAS7YD8RzD6yQiH8iDC6k3TRo6O68Tvlv 86ev7HUa+BlVO/vsmjT1g33jQsDC+73d8ziuD0zR0+2V2AWfw7LsA0Od0pDunkr87qMq p3ZvSpo3VkUQ2QxpJfmlNmRtVS8/F3HWgJc1jQbtNvTwpgg0k6wncZLti8R1nRlUfwSW RsTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YYlAYP0NM1FL8pWPQv6I98DCca7Ncq8IigKyGMJZ/dc=; b=aNpIiEKdcWEOQLGXSJTeQc41uuHmWPyxincMBzZDONXXpBeAxpZLKS0uUWPup2ysHM WEaT+gF5+IRjSf6TnYerACuABAM7G9WlZSTJjQvjLmIsGY/u3HAegQf7pFSF4qcstLih z991Jk62EaiTcj7/VyJ2UW9bNBQH3SEgJFNtVWM4UHxqlBTJt2Vo1T3Fe/9rWqA5l2Hr pcBLE2c84XMx94b+FZ6esyUiCYKsiVf9h+4OE94XS0KJ3cCYHmXpRff4IUW3IF5nXCHQ syog6WK7D40bcssAqkmOrWTyvUQA/TzEDOCLJ0PYcugCjGfpKRxR3g+5BgpLLczRWZBq RYuA== X-Gm-Message-State: AIkVDXLb65PR7+g0GynjnJG2OfYlSxximYnJDJCl3yLzOcOOOSdkgCodXBR6Bjzta4BOIg== X-Received: by 10.223.150.84 with SMTP id c20mr30232215wra.178.1485290958058; Tue, 24 Jan 2017 12:49:18 -0800 (PST) Received: from emmanuel-Aspire-E5-571.primacom.net ([185.44.151.141]) by smtp.gmail.com with ESMTPSA id w197sm28023606wmd.11.2017.01.24.12.49.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Jan 2017 12:49:17 -0800 (PST) From: Emmanuel Roullit To: rahul.lakkireddy@chelsio.com Cc: dev@dpdk.org Date: Tue, 24 Jan 2017 21:48:58 +0100 Message-Id: <20170124204859.8998-2-emmanuel.roullit@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170124204859.8998-1-emmanuel.roullit@gmail.com> References: <20170124204859.8998-1-emmanuel.roullit@gmail.com> Subject: [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 20:49:18 -0000 Found with clang static analysis: drivers/net/cxgbe/sge.c:900:3: warning: Value stored to 'in_use' is never read in_use += q->size; ^ ~~~~~~~ Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/sge.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index fc03a0c26..42051ca01 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drivers/net/cxgbe/sge.c @@ -891,14 +891,10 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq, unsigned int flits, ndesc; unsigned char type = 0; int credits, hw_cidx = ntohs(q->stat->cidx); - int in_use = q->pidx - hw_cidx + flits_to_desc(q->coalesce.flits); /* use coal WR type 1 when no frags are present */ type = (mbuf->nb_segs == 1) ? 1 : 0; - if (in_use < 0) - in_use += q->size; - if (unlikely(type != q->coalesce.type && q->coalesce.idx)) ship_tx_pkt_coalesce_wr(adap, txq); -- 2.11.0