From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 9EBDB98
 for <dev@dpdk.org>; Sat, 28 Jan 2017 14:23:58 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga103.jf.intel.com with ESMTP; 28 Jan 2017 05:23:57 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,301,1477983600"; d="scan'208";a="53282495"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga004.jf.intel.com with ESMTP; 28 Jan 2017 05:23:56 -0800
Date: Sat, 28 Jan 2017 21:26:21 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com
Message-ID: <20170128132621.GB20916@yliu-dev.sh.intel.com>
References: <1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1485399942-94705-1-git-send-email-jianfeng.tan@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: check value returned from
	malloc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jan 2017 13:23:59 -0000

On Thu, Jan 26, 2017 at 03:05:42AM +0000, Jianfeng Tan wrote:
> Value returned from malloc is not checked for errors before being used.
> This patch fixes following coverity issue.
> 
>     static struct vhost_memory_kernel *
>     prepare_vhost_memory_kernel(void)
>     {
>         ...
>         vm = malloc(sizeof(struct vhost_memory_kernel) +
>                     max_regions *
>                     sizeof(struct vhost_memory_region));
>         ...
>     >>>     CID 140744:    (NULL_RETURNS)
>     >>>     Dereferencing a null pointer "vm".
>                 mr = &vm->regions[k++];
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Coverity issue: 140744
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied to dpdk-next-virtio.

	--yliu