From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id A9C8A3989 for ; Mon, 30 Jan 2017 10:33:27 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id c85so205890750wmi.1 for ; Mon, 30 Jan 2017 01:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7xwkWShVTFoowUDrHqCU7NS6pl6GJElT5v6nbCcXjXY=; b=IEBG5kHHctnyMHxzdaHMLnUYnnba0uP92rR05/o8CWNeo1gAyIUvSVVgkhXmlsjpwI nL8xhcqPxi+h3fTNCp/9o8Tks3HlH0CIPyVZSfjszb7A/pmoEHx6+ihmXR/e1AtQgLfc 69WD7kXp+j7Rk2rafLBy2VHqkuMlDtfRG74rTvGCQ5ORro0E9cyLQ0uc/4B65WFhg3Xu dVlpGziYXSWsQ2ims44JL/X8VbRjqXJFcrTKLLgi2eOHCEWD4UE0f3HfomQcOJyM6wUT 23vZ0lwZdhgLjb7O0PUhX24/PETvDKEsWilZEXhHMvjKuA5APS5IglgBO1Sl0O4p/i9x arGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7xwkWShVTFoowUDrHqCU7NS6pl6GJElT5v6nbCcXjXY=; b=PKDX5MTyqZlr2Dxl7e9zdVCOmyR9MMWBVZAzKYtJPz1lUy/ZyqJszvmEnHni037QMN XUj2Zqc5YBmL/UpDRM5MvNc4SpJOUWsnYopJZns8Voqbm2TA3N63NFUFQedu+plQKvkc jz7mFV+eTs1vECmDB4v6FpDpcPRYf7OioJ6mobCzy1wVDRelivkDqRVZwssMK0OOITbH A9JiTeDZJ1eqr1p0iv1IGUAjubzFl314v7oCqm5rW+lCNL0wQc0dASiNhnorksnm1SYE yHWGGMnMAMFGo6FPRKL7O31oOqhBJeVw+csaYEFXqxqJQ4KiBfiF/Ry8gAUw4Tu8sODf 0pUA== X-Gm-Message-State: AIkVDXIdiivsYoOwIrE9i2shgoPCf4MpFBSnlLL1fC3TYZASGl2H6fQu3txz6RojoWuNWO3c X-Received: by 10.223.130.204 with SMTP id 70mr17112416wrc.128.1485768806638; Mon, 30 Jan 2017 01:33:26 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l140sm17815036wmg.12.2017.01.30.01.33.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 01:33:25 -0800 (PST) Date: Mon, 30 Jan 2017 10:33:18 +0100 From: Adrien Mazarguil To: Pablo de Lara Cc: jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20170130093318.GB10133@6wind.com> References: <1485522948-210951-1-git-send-email-pablo.de.lara.guarch@intel.com> <1485528898-53283-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485528898-53283-1-git-send-email-pablo.de.lara.guarch@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 09:33:27 -0000 Hi Pablo, On Fri, Jan 27, 2017 at 02:54:58PM +0000, Pablo de Lara wrote: > Free memory when port flow entry creation fails. > > Coverity issue: 139600 > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > > Signed-off-by: Pablo de Lara > --- > Changes in v2: > > - Removed unnecessary conditional > > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 5834498..467932f 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -954,6 +954,7 @@ port_flow_new(const struct rte_flow_attr *attr, > goto store; > } > notsup: > + free(pf); > rte_errno = err; > return NULL; > } > -- > 2.7.4 > I think this is a false positive, which is why I did not address it during the last round of Coverity issues. As a two-pass function, errors are checked during the first pass, when pf is not allocated yet. During the second pass, intermediate functions are not supposed to return a different result and "notsup" cannot occur. I think assert()/rte_assert() would make more sense and should fool Coverity into understanding the expected behavior. The commit log should reflect that we are addressing a false positive since there is no problem with the code logic (of course unless I missed anything obvious). Thanks. -- Adrien Mazarguil 6WIND