From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f172.google.com (mail-wj0-f172.google.com [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id D5D51DE3 for ; Mon, 30 Jan 2017 16:25:58 +0100 (CET) Received: by mail-wj0-f172.google.com with SMTP id un2so7054854wjb.0 for ; Mon, 30 Jan 2017 07:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hKCJvsNqiUOUTXGyBVTaZ606UDAPizRK34Bief6MBN4=; b=yvWKzwvxllwmPYMABTLybi/bHtjuJdLwXn7V0UkaVSZ31wqxrLyeh2q4ABHp3XUbNY nOUA0qC6X+IddPW9/U/1zm8gbPGIBANFKoig7CjQno139BZzrh4xfxa8O8UHvGiiC9/T 1yggvj9ThYiUKXb8hfYsLEqzbvvt5nhsWNyE03mYX+Bj2Bi0LtmF7PElwLq1C2GXqDH5 NOyT9aA4j6w6ZmWIjesPDASIg2kJw5Jg4cdMgGJiBu0jqQkGLjvZ/GIs6ivs7NiJf6T6 dvmrqMBF12iRruc34K+F7vbd6letEoDgZ82l4HIvSizL7pdvvTvzrPNXNH708aSI+TYt aAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hKCJvsNqiUOUTXGyBVTaZ606UDAPizRK34Bief6MBN4=; b=ti/vhaMtWqclUtq28+RsNOhguJM5/xdipJysVJkqtoFUkQOl9s4v97pgpbgeGQyrS8 i76NLAzkVHfGij5mDtGBkshaoR2DrZi+/qHVZg1IzHLJfHozyLCC1kOzGPBkV33lCkuv bW510uIgunK1c+n3R2b8gTrDdDa22oux4qCkuzhGh3ZMEgMl/kks7qgHyAxLEDAQBE56 1PIkajs8hJac/+BKjYKdHrglin6nSOvVlHZ0OInjEZr3iKKpM6YiScdHEiBn1hGgjj1Z W2e/j8VmOTAZNgbPjju99j4/939y9pLsos0moLtgB6rvLNNgUlYuAuBDPZiuaAHg5sIE rIxA== X-Gm-Message-State: AIkVDXIcdYeB7ytZUcTtf6YYW9Ui/m0bjlreF3gvaFBV7sudACt/do0nQJV/cIUA4BtMVRQT X-Received: by 10.223.173.80 with SMTP id p74mr18318891wrc.168.1485789958503; Mon, 30 Jan 2017 07:25:58 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o42sm23275396wrb.18.2017.01.30.07.25.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 07:25:57 -0800 (PST) Date: Mon, 30 Jan 2017 16:25:50 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: Adrien Mazarguil , dev@dpdk.org, stable@dpdk.org Message-ID: <20170130152550.GB6737@autoinstall.dev.6wind.com> References: <1485348178-43771-1-git-send-email-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1485348178-43771-1-git-send-email-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix link status query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 15:25:59 -0000 On Wed, Jan 25, 2017 at 02:42:58PM +0200, Shahaf Shuler wrote: > Trying to query the link status through new kernel ioctl API > ETHTOOL_GLINKSETTINGS was always failing due to kernel bug. > The bug was fixed on version 4.9 > this patch uses the legacy ioctl API for lower kernels. > > Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") > CC: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > while the ETHTOOL_GLINKSETTINGS API was introduced on kernel v4.6 [1] > the bug was fixed only on kernel v4.9 [2] > > [1] https://github.com/torvalds/linux/commit/3f1ac7a700d039c61d8d8b99f28d605d489a60cf > [2] https://github.com/torvalds/linux/commit/8006f6bf5e39f11c697f48df20382b81d2f2f8b8 > --- > drivers/net/mlx5/mlx5_ethdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 8efdff7..e77238f 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -46,6 +46,7 @@ > #include > #include > #include > +#include > #include > > /* DPDK headers don't like -pedantic. */ > @@ -697,7 +698,7 @@ struct priv * > > /** > * Retrieve physical link information (unlocked version using new ioctl from > - * Linux 4.5). > + * Linux 4.9). > * > * @param dev > * Pointer to Ethernet device structure. > @@ -707,7 +708,7 @@ struct priv * > static int > mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) > { > -#ifdef ETHTOOL_GLINKSETTINGS > +#if KERNEL_VERSION(4, 9, 0) <= LINUX_VERSION_CODE > struct priv *priv = mlx5_get_priv(dev); > struct ethtool_link_settings edata = { > .cmd = ETHTOOL_GLINKSETTINGS, > -- > 1.8.3.1 Hi Shahaf, This function embeds some HAVE_ETHTOOL_LINK_MODE_* to handle the different version of Linux Kernel where those link speeds were added. With this patch, they becomes useless. It could be great for configuration and compilation time to remove them from this file and the Makefile. Regards, -- Nélio Laranjeiro 6WIND