From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 43A733237 for ; Tue, 31 Jan 2017 11:32:07 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id t18so18329442wmt.0 for ; Tue, 31 Jan 2017 02:32:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=euSfn3qIapxuw9WtVVbmV7LW70dygqqgysfVEvEyQBQ=; b=wEFYJb+0l3eD7D3q8Rdp84cI+t9I/FBOp3caaMkRWggnMeKRQnalJteD4g2bKX3AsA eLserqumDpbwMESxIWB/Ky7ek1R/t75DNgUJXx0zp8BtpKiNVCpNh+r/aV/hk67J4I9M XXSDW3Se/8zzjT00WFO3kj3zu6Dx4y+bHbTSPoXGfIUb8wp0uFOVooaI5zmPKnLO6efG kxyhtZxe6CCLWDLbcsimyUTTCxsxS+Zh4spbyPrb47ISSoaya7cz7fbExFcz4oU17m+q Po9nBTwoe+igT8uxAoQyQ93Gz+QBPk29gZ9sYejl7KnTi0QfTxffcBS7uYwQMYN/IUxn 6FHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=euSfn3qIapxuw9WtVVbmV7LW70dygqqgysfVEvEyQBQ=; b=qgUXFTGtfvI8zpiSD5YeLQwx9c18qUzXBAIrrMBPwyGarmghBsej3YtErD7CsAqwi6 jLr6MYMtQm4GJorjHLHCIJTbUquO9+z8JsQUZzpnSnLdCXtWaDMFF8tc7YUdpM4hLEJ9 C2ALc/j2N/Mrf8bbBtBwZBXWR5Vah4ghwErFZHsdKaH67EsFaw17qdbwHRfr7jQ4qvAk U/18bIKs2VVjN9wJDh2GPKtyjExhiZ2+sRpJXJzj5r1wbfGp/6/WQQEkXgIUTduqXimE tbFR3El7Hrify+tOMYKs7utpeygwmRhy8h3J//c0SFlG4ow0drA8fAE7IQbxCwv2rBom PUGg== X-Gm-Message-State: AIkVDXJRcWYbdKHjZYKGHcWiBV/7fFpoUhNBz+DimYjI+sX03ZQZvdZrOzdkvtiDNUSxs+UR X-Received: by 10.28.157.16 with SMTP id g16mr720025wme.16.1485858726914; Tue, 31 Jan 2017 02:32:06 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id q12sm23191587wmd.8.2017.01.31.02.32.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2017 02:32:06 -0800 (PST) Date: Tue, 31 Jan 2017 11:32:04 +0100 From: Olivier Matz To: Santosh Shukla Cc: Hemant Agrawal , Message-ID: <20170131113204.5d3b3df2@platinum> In-Reply-To: <20170117133121.GA27592@santosh-Latitude-E5530-non-vPro> References: <1484678576-3925-1-git-send-email-hemant.agrawal@nxp.com> <20170117133121.GA27592@santosh-Latitude-E5530-non-vPro> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: use pktmbuf helper to create the pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 10:32:07 -0000 Hi Santosh, On Tue, 17 Jan 2017 19:01:23 +0530, Santosh Shukla wrote: > Hi Hemant, > > On Wed, Jan 18, 2017 at 12:12:56AM +0530, Hemant Agrawal wrote: > > When possible, replace the uses of rte_mempool_create() with > > the helper provided in librte_mbuf: rte_pktmbuf_pool_create(). > > > > This is the preferred way to create a mbuf pool. > > > > This also updates the documentation. > > > > Signed-off-by: Olivier Matz > > Signed-off-by: Hemant Agrawal > > --- > > This patch is derived from the RFC from Olivier: > > http://dpdk.org/dev/patchwork/patch/15925/ > > rte_mempool_create to _empty/populate OR rte_pktmbuf_pool_create > changes missing for mempool testcases. do you have plan to take them > up Or shall I post the patches? Not sure we should add something in test_mempool.c, since we are converting to a mbuf api. As far as I can see, rte_pktmbuf_pool_create() is already tested in test_mbuf.c. Regards, Olivier