From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id D23AFFFA for ; Thu, 2 Feb 2017 09:20:35 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id b65so78413499wmf.0 for ; Thu, 02 Feb 2017 00:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ygYXLJlP3xaEgiK9fRjajpGYpmUoC3DEHNpkpSnUoCY=; b=pyD9883zlgq6GP3I1wveQ////u+nefgKMbwRMfG8287GqdLFe61WXw97yotrqCc57V DZXgyIVkC/S5nXIY/dTDJZJl+rFiadmfm4SoDjhqKIjCkoEl0Naxo7s1n4tdU5J4PiZM VkdJQUBveIae6OX/r5vwYLo6tdDlDpE3uk9vjeY/iirlKwl4ffjFSrRA9lfOkUnTO+cc Pl43NYptANGuVHErlNi2G8s69Yo2k8lnBfUAuh1ctPED7UjWIxrl4fITpy3daHF9NOPw FDeyR50Qc9lequby6LNRMZ43KDfarEaIi04EkkIhCQVc74usJFUAidZT40LXpTNIh3kG vmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ygYXLJlP3xaEgiK9fRjajpGYpmUoC3DEHNpkpSnUoCY=; b=H5KDXuRhUTlCdqzdqYKeaiuZ/RVOEWcskv//oQkr96Tn5mOU9xMPTfiAOGOyfGvtzw QxaiqB5qtGV/1QuOqyUKdx+iVadCSGePX1NXG3N9e9mREVtYdgXxpmm722U84LIGPneh yxtV2/wxNLNgo4lr2tf8OR2K/+epBMqhWX/868TEB7d3QH30vQ0+n5Fkx3+GcHCpGUe+ teedftRIR2+hT/WTSQt598rJNI0ZyGjixbLe+MY7kPhhcdKMOEDoWuU6qCXSRJeeOOn0 CKAetCV9DMs37GznOTM/n05M5qA0zAwj5HlQfTxcgH38h1GJiGFO8JpFCp+wWzOkGIcb PFqA== X-Gm-Message-State: AIkVDXKr2WizYkzI7XSMOG8+fryKVbWfiFotJxec0MCPDRdNP9eiFQHUJdWand/zhEZNkfLC X-Received: by 10.28.144.135 with SMTP id s129mr6202794wmd.18.1486023635473; Thu, 02 Feb 2017 00:20:35 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a35sm38633108wra.21.2017.02.02.00.20.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2017 00:20:35 -0800 (PST) Date: Thu, 2 Feb 2017 09:20:27 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Shahaf Shuler , adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170202082027.GL16389@autoinstall.dev.6wind.com> References: <1485348178-43771-1-git-send-email-shahafs@mellanox.com> <1485863129-6326-1-git-send-email-shahafs@mellanox.com> <20170131154201.GC16389@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix link status query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 08:20:36 -0000 On Wed, Feb 01, 2017 at 06:31:17PM +0000, Ferruh Yigit wrote: > On 1/31/2017 3:42 PM, Nélio Laranjeiro wrote: > > On Tue, Jan 31, 2017 at 01:45:29PM +0200, Shahaf Shuler wrote: > >> Trying to query the link status through new kernel ioctl API > >> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug. > >> The bug was fixed on version 4.9 > >> this patch uses the legacy ioctl API for lower kernels. > >> > >> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") > >> CC: stable@dpdk.org > >> > >> Signed-off-by: Shahaf Shuler > > > Acked-by: Nelio Laranjeiro > > Applied to dpdk-next-net/master, thanks. > > (Updated kernel version check to: > "+#if KERNEL_VERSION(4, 9, 0) < LINUX_VERSION_CODE") Ferruh, The issue is fixed in 4.9, so <= 4.9 is correct. Am I missing something? Regards, -- Nélio Laranjeiro 6WIND