From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B6EE5F72 for ; Thu, 2 Feb 2017 14:58:44 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 02 Feb 2017 05:58:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="929378318" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga003.jf.intel.com with SMTP; 02 Feb 2017 05:58:40 -0800 Received: by (sSMTP sendmail emulation); Thu, 02 Feb 2017 13:58:40 +0000 Date: Thu, 2 Feb 2017 13:58:40 +0000 From: Bruce Richardson To: Nipun Gupta Cc: Jerin Jacob , "dev@dpdk.org" , "thomas.monjalon@6wind.com" , Hemant Agrawal , "gage.eads@intel.com" , "harry.van.haaren@intel.com" Message-ID: <20170202135839.GA195928@bricha3-MOBL3.ger.corp.intel.com> References: <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-3-git-send-email-jerin.jacob@caviumnetworks.com> <20170202113419.GA186604@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v4 2/6] eventdev: define southbound driver interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 13:58:45 -0000 On Thu, Feb 02, 2017 at 12:53:17PM +0000, Nipun Gupta wrote: > > > > -----Original Message----- > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Thursday, February 02, 2017 17:04 > > To: Nipun Gupta > > Cc: Jerin Jacob ; dev@dpdk.org; > > thomas.monjalon@6wind.com; Hemant Agrawal ; > > gage.eads@intel.com; harry.van.haaren@intel.com > > Subject: Re: [dpdk-dev] [PATCH v4 2/6] eventdev: define southbound driver > > interface > > > > On Thu, Feb 02, 2017 at 11:19:51AM +0000, Nipun Gupta wrote: > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > > > Sent: Wednesday, December 21, 2016 14:55 > > > > To: dev@dpdk.org > > > > Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant > > > > Agrawal ; gage.eads@intel.com; > > > > harry.van.haaren@intel.com; Jerin Jacob > > > > > > > > Subject: [dpdk-dev] [PATCH v4 2/6] eventdev: define southbound > > > > driver interface > > > > > > > > Signed-off-by: Jerin Jacob > > > > Acked-by: Bruce Richardson > > > > --- > > > > lib/librte_eventdev/rte_eventdev.h | 38 +++++ > > > > lib/librte_eventdev/rte_eventdev_pmd.h | 294 > > > > +++++++++++++++++++++++++++++++++ > > > > 2 files changed, 332 insertions(+) > > > > create mode 100644 lib/librte_eventdev/rte_eventdev_pmd.h > > > > > > > > > > > > > > > > > +typedef int (*eventdev_port_link_t)(void *port, > > > > + const uint8_t queues[], const uint8_t priorities[], > > > > + uint16_t nb_links); > > > > > > I think having event device as input parameter to the port_link & > > > port_unlink will be required so that queue configuration can be fetched from > > the event device. > > > > > Or each port structure in each driver can have a pointer back to its containing > > eventdev. That is what we have done in our SW eventdev driver. > > That's one solution, but I think having device in the API will be more cleaner here, just like > it is provided in other configuration API's? > > Thanks, > Nipun > Sure. Will you do up a patch to make this change, since the code is already applied to next-event tree? /Bruce