From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0054.outbound.protection.outlook.com [104.47.42.54]) by dpdk.org (Postfix) with ESMTP id ED115FFA for ; Thu, 2 Feb 2017 15:32:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DIsgzKOUuUQp4jpv8pqYCB8USaBJGk+UEXFtw7uGXss=; b=Ngppz4tcn2S/2mqcHf6RfQ9udRneSp1kltyww8tjyWpBONm8RXOcJLjmyLjTJo25CrreC+drXnPvJEpwYkW/jWdFbYexNm9+FaRaLnKGBOX0VLqJbX8j/Io7e2p4FN6JnQB4BZfxnwFmHdUag+QUGr1G+ro4ZCM/yGNAMXoZp9w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Thu, 2 Feb 2017 14:32:31 +0000 Date: Thu, 2 Feb 2017 20:02:16 +0530 From: Jerin Jacob To: Nipun Gupta CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , Hemant Agrawal , "gage.eads@intel.com" , "harry.van.haaren@intel.com" Message-ID: <20170202143215.GA28028@localhost.localdomain> References: <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-4-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0040.INDPRD01.PROD.OUTLOOK.COM (10.164.136.140) To BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) X-MS-Office365-Filtering-Correlation-Id: c2b7cee5-092b-47ab-5a10-08d44b7853d0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 3:aEiCPKI+K00Hyng2P/u2QtXuxd85P+1K2H1bzs2doj1p3ojsS+bOfogiDQhfvMXN52e/ED6XeerKLCxSyd1ZrsVfi4hivjPAN5O/51VV3PDc6MHDCZs4ruYQWp1DJG93kTxDa41aLPglC+uYZEAlRKwliOU1IEVIniS2iLd7//X0kWTPppMALyL50HRl4vEe7WN5iH89gOMOsvie2pGBoSASyLkLqonUpqI6+xUR7/CvJkeHBjApIUrpaZRcQfJEdAhCPKzH+KOwsQQfZxhHiQ==; 25:F3CsuV31INKhB/P7yt6lmtGobBcHi27/DnDdm5PB18lMNl7Bb4GRHyWFtmPag1yz3a+6QZn95w8u+urEVb2FVTrjxt/Eqn2UxXxEoifXCLCvORzWyxDF3CbREb+mTblPtuq6zY6kLK2K465blUK+fEl1Atc3bIzO9lh9vhKhZwpJVLiNVJ7gkHG23OMExKTQBMUukIi71kBCObLlIu1SthThu13fZWd9V7usS8CoPT3QzsZc21CG+WWdCpQ1hwGGl77YQiQJb83LcykNVaPuWeNr5VyrZiDJuliLUqvnaFgwqAPonmkvdL14+JUpvWxZEy2tJWlsg4YYiii2ex4pDMqKiiooKmF7jTdZraukADGUrst/G8ACo/xH9ZrYBApSNmwkrOc9it4wXYueZ+qANSsGMT1r3mlvEtYBYWf85JH0PNLnrJ1Zp/LA8w10nckdqsMs9Os5TeJYleR5mU/xOA== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 31:1d7E2nh/zdC/+RNXIT/cJmO3eOes5nIGs0PWzLbbfpVCBfbjSAEmIZO9WIMK/fAHJ21xn5WKhcNqVVagAe84+8ekf5ZeaS/HNVGR2AKQixyCJ5jeGPOdlqhXNNETiD7yRNleexuULAf7w7kPblEyNUvEXeWJIL1UaCWrFXZw47GDxYak3+kiufV0v1p6MqSriCPTwpri4ir02Zyar/CmTScwJ33H3x99JTkmhokyuOUC2Uw5bKgEdBpTmkwtBCKiWqadOCZpHRmrj3kTkBrp6w==; 20:xCQ2NOTRzofPdyg8I/dJ6BqnJPE7Gr/M3CVl4ZehvjaL3jyvXRo6ZgON0Oq8clNzsG2c8a2lT0gIX8l5ZtwWkvVkKEG3USbZdl2xmPzNl7/mB9n7dqo3chF0zF7ZioM7HVAW5LgRLgEGVD440xw6UugbnRbmJRvrfAyX/A1jYt/n5Ijl5eiYCOz+ICq5uD1j7kfzTcEuk4+XW8MIayiXNzSFv8Mj22ZBvt1Z1NtFGYWs5BPXcEpuG1LGMOEbNWkgCG9kHFCoE1vE7z//E2U4sGa9tScO4s5HzcgtdYmlnd4Q+Ab5lrunVnGRT1OM4MYAEpbOd2mX2VhGlUg4sReB3hTcRbdtNbEAymHk2mqfWVMvE+BK9xlCEJGB0K+lIroSoasszX6G+YYKbXTXeYZQaF9ymKC3+3eNuryUNVToReHtrrFzzBCkjBg1BYGnNZtbJjOkYDFwtem4d2TlcQOnj8WYzYnKTANtd4F0GuENQT3t9QhyYJ3hqGEMBtIMl/7Wzj3A1J16DCSNDyQJQVBT5tCDJDqK0AGlrGsm4cNGzqxaQTpijYCp1fHaFQJE3izaH+mpLnyaIA3Kp5Z1DQBaFCTNr83qhG5FkMUp3XRqWqM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:BN3PR0701MB1720; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 4:sHOeLBKvXBoDGR8ru6/XgySaO4J8MhBjWu6+IMPqcjFJ5c3/iOLRdvv2OScLMixchiuQ2bauYD1WtRrlImcplvAf8Oc1LmP/+A/JLMUWOKTGy6xXd4jjSS1Qu+01r+apT0Avpb5mfXQttH8CJqVdGZsFijZlh5t6HTGkDIyvl/eHKJ0J+BCKkNMzC8gQrumcjfV7mFfEtOveM8iLMgCRfDp1EY/OcbJl7MaXqGNNqe+jwY2J04bDbioHdjNv1w4fhvfWI8T+kCSi/r3BHb7N3QCh2K8/U8P+yK6rb71xOgIGe4bYlBPCmse/SG1fRzBTz2aaw11Fy0YY8SiYkzWIkNJH0jybwEkx6LrXiz2AOwhBMJ67BMS5wWd7Zobt2SdCKF7IjP6sdGX8Y/WQjphl31EoaBkQqkj6U9/ix0eC+oTPWJrgwLAj1f85Aam8YJDRKOjbHVwlER7EMKjmz3gj09qyOzqMPcAtHLgX6LbqAR8SpqJtXX7XLr5Y/ig/cEsWY8PqwOlLUL11Z1V4dtDoqVpy1HQA0QDF/OP4B6Zqw/ZJa2fNo647CXNrgXZyIXBRbOEw0PstsSh2AWuSqxXXQzp/PNvPOEDcoqQIV2I8U9aVCYiywfQdf99Ij+ZiJvIs8fKUXCsIjLi0ppU14NLe/Q5LdU3N3HHypWUBSwIICKXbdBDFxpjEEvWFDUr+I4sq X-Forefront-PRVS: 02065A9E77 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(13464003)(24454002)(189002)(199003)(9686003)(53936002)(97756001)(2906002)(5660300001)(50466002)(106356001)(105586002)(101416001)(8676002)(81156014)(4326007)(76176999)(1076002)(50986999)(46406003)(54356999)(54906002)(47776003)(83506001)(110136003)(93886004)(4001350100001)(3846002)(97736004)(6666003)(23726003)(2950100002)(6916009)(33656002)(6116002)(81166006)(42882006)(189998001)(66066001)(61506002)(38730400001)(6506006)(229853002)(55016002)(305945005)(8656002)(92566002)(25786008)(68736007)(5009440100003)(42186005)(7736002)(7099028)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1720; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1720; 23:+Y44Z9wQhi8FhlGp00aiXBn79n9ICqkCdEkJWjF?= =?us-ascii?Q?mFKBjY1mhdSmU9DK3KG+Xzldg6U2mM/690dhCep1f04TCZFFiKfzoi39GkPd?= =?us-ascii?Q?yIon/OUhL0AHRM53+L3Udmo0Tgzc0h/dDQu11H+fbq4/WetPdYr8bWYn2Sym?= =?us-ascii?Q?A6WVG2StmNdSNg7ppFAa1UnUmuwuGoR8brL3GvGcdqNxXOqiE9WEP/y1XzQe?= =?us-ascii?Q?04yjQDBxSPj9QlG0Prls2OoF1FCJrWz5PrYf6/QyMpWebRmDg7mlDdjeSmud?= =?us-ascii?Q?DtyxpHhDPidgGvzIQylMHmFV+OXp01x9pPQzu7CiFjN4SuPxCnAnm7xtaNYU?= =?us-ascii?Q?vNo2rNOOoz+p2iCqLr61IDFAYKEFMQhDnzzpAfVYvp9/tEWOC2jNDWqZl/RK?= =?us-ascii?Q?S7/UgbU5wRw8ZriqQtcqZnb9oyMXC0VzwpoJKtz0UomY6a5aXu8tLotEtuqF?= =?us-ascii?Q?DDkEXxPrae25Fmq1cea5YrMk4PJyOeS4nr36u8Jeg2WgT66MpOID2OXsIgrt?= =?us-ascii?Q?dimY4C/ofaITvYMpl30bi9hwhbeM//ktYUWO868aTLf1aD8cbrz2a4VhUZ/0?= =?us-ascii?Q?jUdjmYrIKbKuXddIkj0i8qBMht++R9Tv0lQQTCJvbh0Ll8MExRn1PGEN9oDX?= =?us-ascii?Q?/8R0ZXtvvsPtgALpHUM27IvkzgTAYXxDPTr6ZIXW+ohsB5g3SQUvrhgrh7r7?= =?us-ascii?Q?qQxMamf/Ec9o/Qj6ZRb5J3405ya8z+UvHXmYuwoC8NB4aUVZo3E5Kt/5M6Ss?= =?us-ascii?Q?g7zcxEb/3PUHGGmzH+cGXehbJDjk4yH56PA5lNe0QrfCIGHvmq3cY4cou6c4?= =?us-ascii?Q?jPJaRdG4BTtsCA6E52wThb0Qjg4iQ05ccyBNeVApvzFfhlKMc/z5Xfll3wz/?= =?us-ascii?Q?NWWND0K2388/zhEm+CgoxsPaFlvesMFVAlVF8L6ggyZhHCfC7cRV7M8aad99?= =?us-ascii?Q?TQrsze+JAaqF7PDvOMKPEfm9oFfAy9hLjMC4GrpfysRIW2gJ1Vl/nPZtZLnk?= =?us-ascii?Q?18QnR4aS+0p1YftoJ6s9JIVbbcm/sHIC8fnUE9uKvtpVUaA2gru5DPtune1n?= =?us-ascii?Q?Dp/47Ec/2eoPqb+SFDBzIRaZUHoYdQdIEXLOiCqUSJzZ8cLjAh/T/UmCFLVj?= =?us-ascii?Q?92orJM4T5q2x3Dx/zAIhBogO6IGNbSPFoNcBOv7MA23IVgFTIXn3+9xAv9OS?= =?us-ascii?Q?lztf2j9/+q8wtPZT+g5ImZWMdNIWsccDI0D8nc/klAgXnyQIg65Khq8Dqf0i?= =?us-ascii?Q?IE24JH6IRes3cMBDknbl+d/ODx5yhBTn3M0Jvu3cvRzP5FoJP7rWaH1VmCFZ?= =?us-ascii?Q?7nU3+PzQGZjO+LpQTWnVa6TPxNkXm+yva/S086laTL2/pDueFHBdtBaQBdml?= =?us-ascii?Q?+k2i+A34jFDCXL5M6165L/Y9L/2ZO2/R8BpDgdntXsbQJsrdM?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 6:WBpRctB3xMu/aZjegCBMS5AFJAgzN2gJNxBogy1JvWvuRojHv/9mnFGQVQEr6eGpjvolX/gMdbRVxz1jcGTMaQUFggY7zs6fmoyeubRzfSsGPQ3+kKwIGkTn2G6Q50ihMm17T3R9s7zZMx5IQsiojxa9qxMLIoucVuqFN1VnKkSVM1zk9WFnLKe3KkHGvliwVUZ85wMuwvv8P6H3ymGBO7vdEM3Ncru6ITkoG+IyYKAFgVCa3UyxhPMisX51wf/AKRPk+yp9UkB4t87UlqyWon2zDAF1nID9c1cYcLXPV3UaTxlZ5gX46fmLzGE1RXK0fpX9JRGlGhdTp6b2e95cEAIak49Tpx/dy7yH/yeXMz1cZsptTTkiTlljIwloE4LjE78jAKK163B1tuznFOtZ41jNzD2bWA0PauXtJ+2/glA=; 5:Jv3Ok12cu1BZmUhO+7BGijhoq2vjxrwNXjN7PdFaITGgzPvmKSHPYIGMtKwZgSJ2RypHUSOVWPjPGJK04l4L51zKM14H0pILRMRXW1RZikTqyaMeqcFVkpgJ4+rRVmaMGNmPG26NPglfGjccNXa6Eg==; 24:v6iq95/sANjqx6Gnx/OK92zv1QOCuZdVuizm608HIGfwTI8lfEnUB3QEJwTX08MG1uhqQkOW23a7i+8/yN21BgvhU5B7xvFu9OeKL33knQ0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 7:ViiTP+4iz1IyOoNSjo7KbVRic/tForoWK2XR5Gh0k6Z5oKig6TvNL5ED5rs1QqI5LISWA5vsDWLnmfv7k1tNTe9wE0ARd/oSFR10pW0b/SgERUIemmE6nrVRDFpO6yATkhxm54q+TFpACT+ItWWNRjS55J6LpUmt4bo4fGc5nyUcM4dXKJBWQz4dIj3dq5HC28m2/yqMtQ7hXcJxAwA6czqgG6IkoEq7deuMQqArENBNRoHBvyYiB6B6k7iXJRN9RmfvFL7xP+25JnnJVL/poEULHZfQ0VCyIAP0xVMWT9n9Xf9p3gnu1d1UxZZaHhFtba80/TsFG3n2Lb1ptB+cjKqm1w+k+P3TdhrJRPvr618ZySNho7kJfAUrApTY+SX3e1jztB8HtnEsJB88gmpWfxHbQ2sdVTvdiV28fFEH4VFWK9r8L/ccdR7JdEXUDmrGhr7sPxIGKjTnhPXNtFLkCKxzI036zoN6o5Dym85slu8Kps3PiL9S9mwe6ItoA/Xqo8grBzccLd08rvQMZHfVCz39u1fS3/uuH9Rdvtn0CtilLQf+p4LWwArmxn9xsD/9 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2017 14:32:31.5091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1720 Subject: Re: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 14:32:37 -0000 On Thu, Feb 02, 2017 at 11:19:45AM +0000, Nipun Gupta wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Wednesday, December 21, 2016 14:55 > > To: dev@dpdk.org > > Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant > > Agrawal ; gage.eads@intel.com; > > harry.van.haaren@intel.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs > > > > This patch implements northbound eventdev API interface using southbond > > driver interface > > > > Signed-off-by: Jerin Jacob > > Acked-by: Bruce Richardson > > --- > > config/common_base | 6 + > > lib/Makefile | 1 + > > lib/librte_eal/common/include/rte_log.h | 1 + > > lib/librte_eventdev/Makefile | 57 ++ > > lib/librte_eventdev/rte_eventdev.c | 986 > > +++++++++++++++++++++++++++ > > lib/librte_eventdev/rte_eventdev.h | 106 ++- > > lib/librte_eventdev/rte_eventdev_pmd.h | 109 +++ > > lib/librte_eventdev/rte_eventdev_version.map | 33 + > > mk/rte.app.mk | 1 + > > 9 files changed, 1294 insertions(+), 6 deletions(-) create mode 100644 > > lib/librte_eventdev/Makefile create mode 100644 > > lib/librte_eventdev/rte_eventdev.c > > create mode 100644 lib/librte_eventdev/rte_eventdev_version.map > > > > > > > +static inline int > > +rte_event_dev_port_config(struct rte_eventdev *dev, uint8_t nb_ports) { > > + uint8_t old_nb_ports = dev->data->nb_ports; > > + void **ports; > > + uint16_t *links_map; > > + uint8_t *ports_dequeue_depth; > > + uint8_t *ports_enqueue_depth; > > + unsigned int i; > > + > > + RTE_EDEV_LOG_DEBUG("Setup %d ports on device %u", nb_ports, > > + dev->data->dev_id); > > + > > + /* First time configuration */ > > + if (dev->data->ports == NULL && nb_ports != 0) { > > + dev->data->ports = rte_zmalloc_socket("eventdev->data- > > >ports", > > + sizeof(dev->data->ports[0]) * nb_ports, > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > + if (dev->data->ports == NULL) { > > + dev->data->nb_ports = 0; > > + RTE_EDEV_LOG_ERR("failed to get mem for port meta > > data," > > + "nb_ports %u", nb_ports); > > + return -(ENOMEM); > > + } > > + > > + /* Allocate memory to store ports dequeue depth */ > > + dev->data->ports_dequeue_depth = > > + rte_zmalloc_socket("eventdev- > > >ports_dequeue_depth", > > + sizeof(dev->data->ports_dequeue_depth[0]) * > > nb_ports, > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > + if (dev->data->ports_dequeue_depth == NULL) { > > + dev->data->nb_ports = 0; > > + RTE_EDEV_LOG_ERR("failed to get mem for port deq > > meta," > > + "nb_ports %u", nb_ports); > > + return -(ENOMEM); > > + } > > + > > + /* Allocate memory to store ports enqueue depth */ > > + dev->data->ports_enqueue_depth = > > + rte_zmalloc_socket("eventdev- > > >ports_enqueue_depth", > > + sizeof(dev->data->ports_enqueue_depth[0]) * > > nb_ports, > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > + if (dev->data->ports_enqueue_depth == NULL) { > > + dev->data->nb_ports = 0; > > + RTE_EDEV_LOG_ERR("failed to get mem for port enq > > meta," > > + "nb_ports %u", nb_ports); > > + return -(ENOMEM); > > + } > > + > > + /* Allocate memory to store queue to port link connection */ > > + dev->data->links_map = > > + rte_zmalloc_socket("eventdev->links_map", > > + sizeof(dev->data->links_map[0]) * nb_ports * > > + RTE_EVENT_MAX_QUEUES_PER_DEV, > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > + if (dev->data->links_map == NULL) { > > + dev->data->nb_ports = 0; > > + RTE_EDEV_LOG_ERR("failed to get mem for port_map > > area," > > + "nb_ports %u", nb_ports); > > + return -(ENOMEM); > > + } > > I think we also need to set all the 'links map' to EVENT_QUEUE_SERVICE_PRIORITY_INVALID > on zmalloc. Just after the port_setup, we are setting to EVENT_QUEUE_SERVICE_PRIORITY_INVALID in rte_event_port_unlink(). So it looks OK to me. diag = (*dev->dev_ops->port_setup)(dev, port_id, port_conf); /* Unlink all the queues from this port(default state after * setup) */ if (!diag) diag = rte_event_port_unlink(dev_id, port_id, NULL, 0); > > > + } else if (dev->data->ports != NULL && nb_ports != 0) {/* re-config */ > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->port_release, - > > ENOTSUP); > > + > > + ports = dev->data->ports; > > + ports_dequeue_depth = dev->data->ports_dequeue_depth; > > + ports_enqueue_depth = dev->data->ports_enqueue_depth; > > + links_map = dev->data->links_map; > > + > > > > > +int > > +rte_event_port_setup(uint8_t dev_id, uint8_t port_id, > > + const struct rte_event_port_conf *port_conf) { > > + struct rte_eventdev *dev; > > + struct rte_event_port_conf def_conf; > > + int diag; > > + > > + RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > > + dev = &rte_eventdevs[dev_id]; > > + > > + if (!is_valid_port(dev, port_id)) { > > + RTE_EDEV_LOG_ERR("Invalid port_id=%" PRIu8, port_id); > > + return -EINVAL; > > + } > > + > > + /* Check new_event_threshold limit */ > > + if ((port_conf && !port_conf->new_event_threshold) || > > + (port_conf && port_conf->new_event_threshold > > > + dev->data->dev_conf.nb_events_limit)) { > > As mentioned in 'rte_eventdev.h', the 'new_event_threshold' is valid for *closed systems*, > so is the above check valid for *open systems*? new_event_threshold is valid only for *closed systems*. If you need any change then please suggest. > Or is it implicit that for open systems the 'port_conf->new_event_threshold' should be > set to '-1' by the application just as it is for 'max_num_events' of 'struct rte_event_dev_info'. > > > + RTE_EDEV_LOG_ERR( > > + "dev%d port%d Invalid event_threshold=%d > > nb_events_limit=%d", > > + dev_id, port_id, port_conf->new_event_threshold, > > + dev->data->dev_conf.nb_events_limit); > > + return -EINVAL; > > + } > > + > > > > Regards, > Nipun