From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 9B64FFFA for ; Thu, 2 Feb 2017 17:38:39 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id r141so96941704wmg.1 for ; Thu, 02 Feb 2017 08:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vypZ9ZPtEZ287zIOZln9jdn7sahcG9uXg5NQUxbDUQE=; b=KJQGVRnOlGRvY2F3G6jHBzVPSzdEGH2v3qCKKuhNrCZVbEOfQtEee+iA/RBkAcykev bI6eADdAvPkWWWPAQt06cp6+cwWCUApNeqziJpktlVjdlvMO2cLAMHEBYDoVkdP+YGGQ PZqUvDm9AjyWGGYJ3rf8uOCR9W8y2eKJFrtTTM01kynxGZKCDxo+ZRzGu/wM+q6Wi7/D TZmsEhUZmfyk3ZEsgH8QS7fneSILO/GniHg9bPYU3wpYIaFvDPHK/LUbrffefRLpaGMG pKXiGDiyayEz7s1t5J1Zy2nm9ysdMMiibYFDRVkpQYkzbntLe87uc/ukgehF/DUdbU0A 5Fcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=vypZ9ZPtEZ287zIOZln9jdn7sahcG9uXg5NQUxbDUQE=; b=fKTkjvvLypJNcwRqnMmVxSJGtTc+DqNhQRLRek96qvzzXDGafNxWNdpA3HVzh7dLlB NDXYL9i5LzhFMWmVdfGLUjEZ6ZGwdXDgbg4TEU/zzaPKNL4raH+zEdDwzSz3EvV1fpQP rAMBHRX6R5ery8onuEGERNHCPNMngUnhdRFrDtMuFZAg4kQdodj8zV/7KDnXDu5C9bGo /NwfupgZ5dg8S2D7RP+Bbs5ozP/Xn139NBtC9N5axkFE9aGhsdzl8pM2YT6zYnCIfC8x 3AGe3qDncOz3Y6ox3Rcp/0jEOzISeTgzxNWtKNVL2BMsIMALYxd1cjW1kgXl1SwpDNqS RoWQ== X-Gm-Message-State: AIkVDXLZBPMANJ1j1Gvt62xoyefZGfLEea43fE9oBLAe4NUxpPtMx1jK1pfSSJh/I3ooEoRj X-Received: by 10.223.163.81 with SMTP id d17mr8272596wrb.93.1486053519298; Thu, 02 Feb 2017 08:38:39 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i29sm15412862wrc.25.2017.02.02.08.38.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2017 08:38:38 -0800 (PST) Date: Thu, 2 Feb 2017 17:38:31 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: guillaume.gaudonville@6wind.com, dev@dpdk.org, Adrien Mazarguil , Yongseok Koh Message-ID: <20170202163831.GS16389@autoinstall.dev.6wind.com> References: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix Ethernet header re-writing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 16:38:39 -0000 Hi Ferruh, On Thu, Feb 02, 2017 at 03:34:04PM +0000, Ferruh Yigit wrote: > On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote: > > First two bytes of the Ethernet header was written twice at the same place. > > Is this patch just prevents re-writing 2 bytes of buffer, or changes the > buffer content as well? It only prevents to re-write 2 bytes of the buffer. > If buffer content also updated, I think it would be nice to mention in > the commit log. The buffer is only read. > And if buffer content is not changed, will it be fair to say this patch > is refactor patch instead of fix? Well, I understand that it can be seen as not being a fix as the final behavior remains the same. Is it possible to change it to: "net/mlx5: avoid re-writing first 2 bytes of Ethernet header" > > Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization") > > > > Signed-off-by: Yongseok Koh > > Signed-off-by: Nelio Laranjeiro > > --- > <...> Regards, -- Nélio Laranjeiro 6WIND