From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id BDCB62B96 for ; Fri, 3 Feb 2017 10:47:28 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r141so19210892wmg.1 for ; Fri, 03 Feb 2017 01:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=JmBvSblOqzgc4kHmC8ou2p9QpZpXWzi8xrXww5dXlzI=; b=bX3KFOYOb5n2TaATpykB/jhybuBytHE21Lpa6NiH9JQGQ8ngXd1gL4uwvoOyR+D0oS Ciu0Td36qP0TwwpKeFr2seO1aKGEYC42ke1tDcj4ZiRs5a9sodF/aFmjByOs4AfWhkW1 1oRPhPF+R4IRQ537NGJwyhUT7tqe36rCMaeBsCr6vU8VWFKbVM7DqNhKqDOm41LDEUNj SbwFgAFUFKiLCtl4eY7kTedydGarmLJM72Yu3TKLQZs8jRTMzZeVb8fnpmV9iWBGE+nN ZVBTYWuNGrlSlbHuhOE2k9IbTXurIqgGrigivYGaHfkPNIFlVfBoKem7nQAxFC50i6VC 9vGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=JmBvSblOqzgc4kHmC8ou2p9QpZpXWzi8xrXww5dXlzI=; b=HWZ8hlvoyBqFwKHMo1LSrlF52kU+eK6+JKicV8ol+3IJ2awuaTKnIkTWz9d8YhaHQX Bqcbuss0r+Gy4lM74AeP2YeRrIHkmFyu3k/Ws4vxYv4WdjuvKpSzgCgD4lje30FVJkrm Ek3w4Tx5+zleDnkvKQMpJixR+PtP0p2Vv/p4PV7tAHcQyp9Y4MqbSVo9Lt1D2pjS5OC/ 8kKSwoe3od+VqItCccS5TKyuYTvh7fu5nDPr9eXqNBGtHjT2xLs1mEKoCRnx3FOJnvgz ozRPEPMiSyl1oWwDTKMZF+SmPK5c9/+5E1u1/wEMaQB9SHtU7PTUY61Biu0y7oFv4VDp 3O4g== X-Gm-Message-State: AIkVDXL1LwhSWAic29KxlsgSjepY69pCj9Lm41Czy+HQecnFa8GlwR3yQYvLsYTHs4XaXLPr X-Received: by 10.223.142.208 with SMTP id q74mr11476636wrb.101.1486115247306; Fri, 03 Feb 2017 01:47:27 -0800 (PST) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d14sm2075665wmd.19.2017.02.03.01.47.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 01:47:27 -0800 (PST) Date: Fri, 3 Feb 2017 10:47:18 +0100 From: Pascal Mazon To: Keith Wiles Cc: dev@dpdk.org Message-ID: <20170203104718.66a3eb43@paques.dev.6wind.com> In-Reply-To: <20170202223330.39240-5-keith.wiles@intel.com> References: <20170202223330.39240-1-keith.wiles@intel.com> <20170202223330.39240-5-keith.wiles@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/5] net/tap: remove unused variable and minor cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:47:28 -0000 On Thu, 2 Feb 2017 16:33:30 -0600 Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 4f7eacf..238824e 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -390,9 +390,7 @@ tap_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *tap_stats) tap_stats->q_ibytes[i] = pmd->rxq[i].stats.ibytes; > rx_total += tap_stats->q_ipackets[i]; > rx_bytes_total += tap_stats->q_ibytes[i]; > - } > > - for (i = 0; i < imax; i++) { > tap_stats->q_opackets[i] = pmd->txq[i].stats.opackets; > tap_stats->q_errors[i] = pmd->txq[i].stats.errs; > tap_stats->q_obytes[i] = pmd->txq[i].stats.obytes; > @@ -417,9 +415,7 @@ tap_stats_reset(struct rte_eth_dev *dev) > for (i = 0; i < pmd->nb_queues; i++) { > pmd->rxq[i].stats.ipackets = 0; > pmd->rxq[i].stats.ibytes = 0; > - } > > - for (i = 0; i < pmd->nb_queues; i++) { > pmd->txq[i].stats.opackets = 0; > pmd->txq[i].stats.errs = 0; > pmd->txq[i].stats.obytes = 0; > @@ -633,11 +629,11 @@ static const struct eth_dev_ops ops = { > }; > > static int > -pmd_mac_address(int fd, struct rte_eth_dev *dev, struct ether_addr *addr) > +pmd_mac_address(int fd, struct ether_addr *addr) > { > struct ifreq ifr; > > - if ((fd <= 0) || !dev || !addr) > + if ((fd <= 0) || !addr) > return -1; > > memset(&ifr, 0, sizeof(ifr)); > @@ -725,7 +721,7 @@ eth_dev_tap_create(const char *name, char *tap_name) > pmd->rxq[0].fd = fd; > pmd->txq[0].fd = fd; > > - if (pmd_mac_address(fd, dev, &pmd->eth_addr) < 0) { > + if (pmd_mac_address(fd, &pmd->eth_addr) < 0) { > RTE_LOG(ERR, PMD, "Unable to get MAC address\n"); > goto error_exit; > } Acked-by: Pascal Mazon