From: Stephen Hemminger <stephen@networkplumber.org>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: output details on failure to configure filter
Date: Sat, 4 Feb 2017 13:50:58 -0800 [thread overview]
Message-ID: <20170204135058.1cd43023@xeon-e3> (raw)
In-Reply-To: <1486197474-53099-1-git-send-email-wei.dai@intel.com>
On Sat, 4 Feb 2017 16:37:54 +0800
Wei Dai <wei.dai@intel.com> wrote:
> + PMD_INIT_LOG(ERR, "If ixgbe MAC type is not X550 or X550EM_x or "
> + "X550EM_a, the filter mode must be signature or perfect, other mode "
> + "is not supported ! Current MAC type = %d filter mode = %d",
> + (int)(hw->mac.type), (int)mode);
> return -ENOSYS;
Having better messages is good. Please punctuate correctly, and ! is not necessary.
Please try and keep it to one line, having really long log messages doesn't help.
Also, breaking a string makes it harder to use grep to find the source.
next prev parent reply other threads:[~2017-02-04 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 8:37 Wei Dai
2017-02-04 21:50 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-04 8:28 Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204135058.1cd43023@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).