From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 86206293B for ; Mon, 6 Feb 2017 14:49:09 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 06 Feb 2017 05:49:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="1103663441" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga001.fm.intel.com with SMTP; 06 Feb 2017 05:49:04 -0800 Received: by (sSMTP sendmail emulation); Mon, 06 Feb 2017 13:49:04 +0000 Date: Mon, 6 Feb 2017 13:49:03 +0000 From: Bruce Richardson To: Olivier Matz Cc: dev@dpdk.org, david.marchand@6wind.com Message-ID: <20170206134903.GA256940@bricha3-MOBL3.ger.corp.intel.com> References: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [RFC 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 13:49:09 -0000 On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote: > The objective of this RFC patchset is to introduce a framework to > support dynamic log types in EAL. It also provides one example of use > (in i40e). > > Features: > - log types are identified by a string > - at registration, a uniq identifier is associated to a log type > - each log type can have its level changed dynamically > - extend command line parameters to set the log level of a specific > type, or logs matching a regular expression > - keep compat with other legacy types (eal, malloc, ring, user*, > etc... keep their hardcoded log type value) > > At the end, when, we can expect that all non-dataplane logs are moved to > be dynamic, so we can enable/disable them at runtime, without > recompiling. Many debug options can probably be removed from > configuration: > $ git grep DEBUG config/common_base | wc -l > 89 > > Comments are welcome! > Initial scan through the patches this looks pretty good. However, rather than continuing with our own logging system, have you investigated what other tracing and logging systems might be out there that we could possibly re-use? Could LTTng be a good fit for DPDK, perhaps? /Bruce