From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 718DD3989 for ; Mon, 6 Feb 2017 14:59:03 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id c85so121518682wmi.1 for ; Mon, 06 Feb 2017 05:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fk1/uiliAZyT/XtvmTPPJya8T4q50ae7EylO/Gd4Pf0=; b=TFDOJK45Xd+ATGcw1pZFx7f/IIrVnEpKJo6J3tA0HZxIvdfwztua3hlANIgpDm47bY YcZGPmTzXIP63UA+EVJLGS8f0tzhNqxkjBS+QIN9TvKoj8IN08ggpkl1rYxWwT1lcJIL Wz2YM38R98GzexOWaO09sbeJ03MnIxDvRSrfFYdCwUkNeZkT3RM7njiXgTDr03+sDxQv l0bHFlyra5zP0E0c0aZvPrvA/7PYrOCvRZz+rAg/TqE1HzB/NWthByRp6J/BoRLsMYl0 Bd7OznTttaBDVqLKpZCM6n3S4nHwDVw3km1NS7xnkbKtAJfO7EPuxo3/n91AqAjblAH+ 9dng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fk1/uiliAZyT/XtvmTPPJya8T4q50ae7EylO/Gd4Pf0=; b=tQMfitjeZ6Vn8dchU6a0XqwVDSXXqoS74YhUvI1rQxC4hU0DeIZg+OQ1sQBI2gdzAD 5w8O+E7gk+1zIJDP7dZZH6XN9qzbf/36e1T3AroGRYynJEwEbnNPkvD2uUXG9OWl9dbq gXWYdK5XIkPdfXUHwXHoSSoOh4RdDIU2ayFJ7bD+8kYEfLuvDErWmMPH0YjPTY9xD9pN JmVzNdwpWXdZA5SyL+wyLmZS8Yzmrloa4OdzjeTZi3ngtUwttZVWWI74so6A406ExGqK JH6bquQk5jbVhXoeigRTAwMtWnflKT0Co8l5pLVVXXLA6mg5aHSK6KNuFnV5pyq09IGL lVag== X-Gm-Message-State: AMke39m5WGLzQysAx8g7RHSXyxc94BVTBFCu8pFxHadGXTcqWT8lyrW/nf/yLRpjOQZ9pdw0 X-Received: by 10.28.97.2 with SMTP id v2mr9530082wmb.3.1486389543053; Mon, 06 Feb 2017 05:59:03 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id q5sm1629999wrd.32.2017.02.06.05.59.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Feb 2017 05:59:02 -0800 (PST) Date: Mon, 6 Feb 2017 14:58:57 +0100 From: Olivier Matz To: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com Cc: Guo Fengtian , stable@dpdk.org, David Marchand Message-ID: <20170206145857.34cc54da@platinum> In-Reply-To: <1484153524-19337-1-git-send-email-olivier.matz@6wind.com> References: <1484153524-19337-1-git-send-email-olivier.matz@6wind.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: reset hardware when stopping port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 13:59:03 -0000 Hi, On Wed, 11 Jan 2017 17:52:04 +0100, Olivier Matz wrote: > From: Guo Fengtian > > When PF triggers a reset, VF port must acknowledge it by calling > ixgbe_reset_hw(). > > Before this patch, the port link status, speed and duplex are invalid > (all set to 0). > > The patch move the call to ixgbe_reset_hw() from ixgbevf_dev_close() > to ixgbevf_dev_stop(), so that after a port restart on the VM, the > link status is properly marked down, with correct speed and duplex. > > Fixes: f0160874c041 ("ixgbe: various updates") > > CC: stable@dpdk.org > Signed-off-by: Guo Fengtian > Signed-off-by: David Marchand > Signed-off-by: Olivier Matz > --- > > Hi, > > The use case for this problem was described some time ago, see: > http://dpdk.org/ml/archives/dev/2015-December/030067.html > > It is also part of 2.2 release note: > http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_2_2.rst#n471 > > Regards, > Olivier Ping Thanks, Olivier