From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 92A849E3 for ; Mon, 6 Feb 2017 15:10:36 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id b65so122078147wmf.0 for ; Mon, 06 Feb 2017 06:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VSAVcaztZXys2OBmMcf3xuSlHiNUcD30KLNL/qvG2k8=; b=eafTiWrWZVuxeCQP5jxarDUF+rTaw3f4hKRsozz+DI40IFWzNmnDcX+dGuW1exUcHA oJ9g5SgHkxED/yXfl65lNDgxBiKxG/+lP6rFRJLiDd2HOPMMd6sAFxDhu+weqKAwlV6x ZGVL/JCYbF4mUgMfUGGcTluhA2LnpbQuqi8hNjxnCsMXQET+xgMOrzkb6/BvgOMAhxgg D52VwOZCJFvzP+VpgjQw+mtk6xF40ZcUWahX96LbVfMqnWf8PCiUlP9fvogQ6Xow0N1l oeSS4Q1eXffWtPYy2j4G/E9lwnc/glJ4+H3cmuWD7LVMVyQ+H1RXYUI8nESipHYNVXaG 4YKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VSAVcaztZXys2OBmMcf3xuSlHiNUcD30KLNL/qvG2k8=; b=Jw1Ju1SADSHF8uGBoDN4/iOxwXWPRgl8FzkolMcZjBstd/v/tRW/ufs1ucDuAPhmoY iRKPDjGOhhCmBoN1w73MbzXvYv7I/aIsI7BWfb/hLQMERRKnBXXKVS7/qFjoDGE6cC/R vnt/j5qtopTi/sbx8pByN4tbyQ38T63gL9zNWXuoq/e3TsdYGH3tljOK25dgCc6gbjWg XG/NKUtDwFBq6Ebp4NWRbUbtVO+wbUiJbRHbf/l1TKzCWtH+RLo3s/UZEZsPIbZrdPXM O1GjHOlQlIrMAvM/r11jfuKY8IZvmJSZ5KP3mrBooWeVPaw3p7vB+AjnuVzMo7Cyr2yE R26Q== X-Gm-Message-State: AMke39np/QPMxTjvgFhLztL8eo88HG+SjIOP9XJoouPpX4tUB4F6UhOBddpxK/rCPp3WLQYD X-Received: by 10.28.109.70 with SMTP id i67mr8362970wmc.102.1486390236344; Mon, 06 Feb 2017 06:10:36 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 17sm1704794wru.16.2017.02.06.06.10.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Feb 2017 06:10:36 -0800 (PST) Date: Mon, 6 Feb 2017 15:10:34 +0100 From: Olivier Matz To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@6wind.com Message-ID: <20170206151034.1ae936bc@platinum> In-Reply-To: <20170206134903.GA256940@bricha3-MOBL3.ger.corp.intel.com> References: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com> <20170206134903.GA256940@bricha3-MOBL3.ger.corp.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 14:10:36 -0000 Hi Bruce, On Mon, 6 Feb 2017 13:49:03 +0000, Bruce Richardson wrote: > On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote: > > The objective of this RFC patchset is to introduce a framework to > > support dynamic log types in EAL. It also provides one example of > > use (in i40e). > > > > Features: > > - log types are identified by a string > > - at registration, a uniq identifier is associated to a log type > > - each log type can have its level changed dynamically > > - extend command line parameters to set the log level of a specific > > type, or logs matching a regular expression > > - keep compat with other legacy types (eal, malloc, ring, user*, > > etc... keep their hardcoded log type value) > > > > At the end, when, we can expect that all non-dataplane logs are > > moved to be dynamic, so we can enable/disable them at runtime, > > without recompiling. Many debug options can probably be removed from > > configuration: > > $ git grep DEBUG config/common_base | wc -l > > 89 > > > > Comments are welcome! > > > Initial scan through the patches this looks pretty good. However, > rather than continuing with our own logging system, have you > investigated what other tracing and logging systems might be out > there that we could possibly re-use? Could LTTng be a good fit for > DPDK, perhaps? I did not investigate much about existing logging system. I agree that could be a good alternative too. On the other hand, I'm not really confident in adding a dependency to an external lib for a core component like eal. What if we deicide tomorrow to port dpdk to windows or any baremetal env? Also, as far as I remember, the components that depend on external libraries are disabled today because we don't know how to properly manage the dependency (ex: pmd-pcap, vhost-numa, pmd-mlx, ...). Olivier