From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 145458DA2 for ; Mon, 6 Feb 2017 16:57:10 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id v77so120984236wmv.0 for ; Mon, 06 Feb 2017 07:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=e9beIHkkQAX8um7kihbIukicIgxgWPxzSQof+2+HYE0=; b=BXAga0fn6Z0VX/OXg4pY15fliV7qCf7UotmFg8Axa+IwB+tRSVdgogR5zghY4USAfn MTFXEK5W2/dDiA9/gcylw9KvSz+mIjFX53xHpWHPX5sQ8i6aSSD2xhagRcnM3V9+fTS6 emNNl2bo4y484MkKj1MkkwcuW/TcuClgGM0SQHz+QqM0FgtMAtE1y2K7iEQ4i70yzu1W 3dGUcL91YG8olJmFbZ33KJRnn/5b0YpDb+GXd1FeyJMNLqGb58t1mMTg2Bq6btp0XrY8 ZV4kFPzeLf4tRO5jetvYQ8h38tH+DijeGfFjq33KbJZh3IgiV7tM3y8QxLT7JlV6TUyF y4Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=e9beIHkkQAX8um7kihbIukicIgxgWPxzSQof+2+HYE0=; b=lr66ZV8kS6JD/9CXM0x4jKyz7wmLT1waZIAlnSiG1jDP1dORVRD7FTICx98Fwtobdw pr0TFlnqI+c/I34wn9AHs5KQYvzbddhhPniL+HFNrvCz+7YBgy+Fa2ZAEv4XqG61evvl ZvUHRRXoQk3toXtTh3UrBwjuoHjglOKNX8xai7bkUb4fC/RxTOKLvAExYzWJWJe1hVuM A6WON8/zJ/CL5m8fFQWnMiyh3/rl+Tit8oNrl3G3GZXg9bwBw+IigJpptfCOkAgBcOEY Xj/FoR+ELgdsb7dOfzTxA4fNezVVYHcPn+a/s6CQ9VBPLa4Feko5GrQ425LfsRyD6JNw /q1Q== X-Gm-Message-State: AMke39mCi1DvWDOt+ubNKoab+rUkfc78ur/9N5T39M2wo1efxhKKfbt+giyOFyrSxoAVhIJc X-Received: by 10.28.212.82 with SMTP id l79mr8862794wmg.101.1486396629892; Mon, 06 Feb 2017 07:57:09 -0800 (PST) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 202sm13633070wmp.20.2017.02.06.07.57.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 07:57:09 -0800 (PST) Date: Mon, 6 Feb 2017 16:57:01 +0100 From: Pascal Mazon To: Keith Wiles Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20170206165701.75cceb01@paques.dev.6wind.com> In-Reply-To: <20170205160509.88530-6-keith.wiles@intel.com> References: <20170205160509.88530-1-keith.wiles@intel.com> <20170205160509.88530-6-keith.wiles@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 6/6] net/tap: link set down must be before close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 15:57:10 -0000 On Sun, 5 Feb 2017 10:05:09 -0600 Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 65e4bab..966e91a 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -353,10 +353,11 @@ tap_dev_stop(struct rte_eth_dev *dev) > int i; > struct pmd_internals *internals = dev->data->dev_private; > > + tap_link_set_down(dev); > + > for (i = 0; i < internals->nb_queues; i++) > if (internals->rxq[i].fd != -1) > close(internals->rxq[i].fd); > - tap_link_set_down(dev); > } > > static int There's a word missing in your commit title. Otherwise the patch is absolutely necessary. Could you add this line to your patch, please, for traceability? Fixes: ee418a25b0d3 ("net/tap: implement link up and down callbacks") Thanks for fixing my bug. Regards, Pascal