From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id E10B9F72 for ; Tue, 7 Feb 2017 09:51:20 +0100 (CET) Received: by mail-wr0-f182.google.com with SMTP id o16so36200792wra.1 for ; Tue, 07 Feb 2017 00:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=kCs2z+BxzGA3vovkheIzFAa8ghE3hNpta3S46kBy3K0=; b=aVurkC63KK7tbiREv5zuftT2pyiDKKkQKzaneMnvKto45YVnjCNmAGyDyUjw7Tgqv9 +ro4oQGVBYVtbw3ld5lgNQICBNDSkO3+9wrkZKaUWK5RWyTBqI85RChUpCzWpoELpjmP Kivvx8bHlxE5dgWa7iyJd5ouhyG+jFB0X84wbO49GgII3t3dORegRngalm3CIAD+lTfI 9P4X2/idBpUydpmMAdtfNZcK9npgfMDYHKsYjVAPF4waXKhSg7PPsXqJEjU9nR/KBzMI nMqL3G7qUgBnxgeirVQ/6JebRPKTCpL5qfZgTbVT99ivVMsvsFu4AYn65m3dOKJ9brc0 ZQxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=kCs2z+BxzGA3vovkheIzFAa8ghE3hNpta3S46kBy3K0=; b=YIiVcoR2bCpeekCzymkPHAHSn7frQKiBe4StXXrhevmTU0F+CQtlsmMBXKEqgXrnpS /at7ifNwV01QtX4xVj3gMOsN5xAeOAKzY+WKk5Yw0CmhQZVe1D8OgiMilMb1Jdqog+Wf fIZUHVtkAJGAzxj6gWbvwDci8Nb4BbF5j6Eq+Q4hZo49cHLXhSAcma2HC7Nw7GIMGPBb VOtwJgbzADAmBzOUCuGRNoM0OoRiTlFinlAvybojKfFXG+kMYbExvOB71VMehpoc47lv NxH2i1dXOlgOPs2pJDw4fursfl8tpWZn5qTJ4uJhoaGDzdbM4H0rQ9AE8iLLTiS9cGPU ca3w== X-Gm-Message-State: AIkVDXL9M7KsrP+xPjO7+HtHCKu+kM+WATnmUFkHEhT2JYwJaTNtxqFHWMTdPVSFdFyktp+Z X-Received: by 10.223.139.2 with SMTP id n2mr12703396wra.67.1486457480686; Tue, 07 Feb 2017 00:51:20 -0800 (PST) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e74sm17596907wmd.2.2017.02.07.00.51.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 00:51:20 -0800 (PST) Date: Tue, 7 Feb 2017 09:51:12 +0100 From: Pascal Mazon To: Keith Wiles Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20170207095112.2e7a2551@paques.dev.6wind.com> In-Reply-To: <20170206194038.9246-7-keith.wiles@intel.com> References: <20170206194038.9246-1-keith.wiles@intel.com> <20170206194038.9246-7-keith.wiles@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 7/7] net/tap: move closing fds to pmd close from pmd stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 08:51:21 -0000 On Mon, 6 Feb 2017 13:40:38 -0600 Keith Wiles wrote: > At the same time remove closing fds code from pmd stop routine. > > Signed-off-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 966e91a..0a7f4af 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev) > static void > tap_dev_stop(struct rte_eth_dev *dev) > { > - int i; > - struct pmd_internals *internals = dev->data->dev_private; > - > tap_link_set_down(dev); > - > - for (i = 0; i < internals->nb_queues; i++) > - if (internals->rxq[i].fd != -1) > - close(internals->rxq[i].fd); > } > > static int > @@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev) > static void > tap_dev_close(struct rte_eth_dev *dev __rte_unused) > { > + int i; > + struct pmd_internals *internals = dev->data->dev_private; > + > + tap_link_set_down(dev); > + > + for (i = 0; i < internals->nb_queues; i++) { > + if (internals->rxq[i].fd != -1) > + close(internals->rxq[i].fd); > + internals->rxq[i].fd = -1; > + internals->txq[i].fd = -1; > + } > } > > static void Ok, the series looks good to me. Acked-by: Pascal Mazon