From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id 766B8F72 for ; Wed, 8 Feb 2017 15:28:36 +0100 (CET) Received: by mail-wr0-f176.google.com with SMTP id o16so61615462wra.1 for ; Wed, 08 Feb 2017 06:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PU4J0IS6r03wENxsep4/Rqn0zFfk1Nwjvd96GABI4t0=; b=IOwT+w2d5CFGLKZn5hPTtKCBBzcyRccR02sIFik3vzus43+H5S3eW8xx3+AeCnk++g U5iWTmpLuw3R++in6qnB8xj7aeaRQukGKt6Tqgd/kJquev1g0OU/YtTJ1g+EixvGV20/ 5Sp0Q+ifxtoWRCv0pVsK3sTrpFWIap87AVD019vEvsPRuNGocssvQeuw9nyNBAxvrGgD 1AL3O2XednNebVlrcxKq/40LtRELES1RdhQGvNXiLQExyLA/cZIihZsnRC3/LODPDEuj aLnN/2wY8LU9foHar6hhkbodfQBuU3+cC2wIx4togc5VjJyAUGHWAJK86S7KO6jL8Wew IGcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PU4J0IS6r03wENxsep4/Rqn0zFfk1Nwjvd96GABI4t0=; b=QKXZw/dHR4ufEo1Q4xsyIuD+DGqOK6SFeKxh2zF3487hviGXVtPagJAKYlZG/4fgnR 8pTImKhibwOjTWEOF6m4zRngj5aF+7DlV9zWZ06L4jpvdVh60KP2lT7XtdhcIKN7Rfsj uUB/Pm7kVuvYrel+5jAwyPVyrpKcl3oZUtG5d4ojGOKeeLl/eL4s8YeI//0KL1IfTpmQ TkL2rYNfLHfOXbsNG57PDTo6QK0SjN7XZewTno2bz3zsrmEOxHc7vC/j1/LpIRj/nZlY HhTCEhVdP52Fj23KFi4y4JKnepv4bgs/PsKzBAqfUg0DPhTW3uNiN+utUafXmGMmw88R IY3g== X-Gm-Message-State: AIkVDXJpToDnC3cU3nZm8pPqXd4GbmjFQrhv6BREcysku/QBg2TX7e3bjYFnZdc2HDhuSX1V X-Received: by 10.223.142.1 with SMTP id n1mr19335684wrb.185.1486564116255; Wed, 08 Feb 2017 06:28:36 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b8sm13305630wrb.17.2017.02.08.06.28.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Feb 2017 06:28:35 -0800 (PST) Date: Wed, 8 Feb 2017 15:28:28 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: guillaume.gaudonville@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com, stable@dpdk.org Message-ID: <20170208142828.GH28684@autoinstall.dev.6wind.com> References: <20170202184332.22187-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170202184332.22187-1-yskoh@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 14:28:36 -0000 On Thu, Feb 02, 2017 at 10:43:32AM -0800, Yongseok Koh wrote: > The total length field in descriptor of inlined multi-packet send must be > updated before closing a seesion. There's possibility of updating it > afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets > silently dropped by HW and impact performance, escpecially lossless test. > > Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send") > CC: stable@dpdk.org > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 94fe74763..1043ebbc0 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1046,6 +1046,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, > mpw.data.raw += length; > } > ++mpw.pkts_n; > + mpw.total_len += length; > ++j; > if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) { > mlx5_mpw_inline_close(txq, &mpw); > @@ -1055,7 +1056,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, > inline_room -= length; > } > } > - mpw.total_len += length; > elts_head = elts_head_next; > #ifdef MLX5_PMD_SOFT_COUNTERS > /* Increment sent bytes counter. */ > -- > 2.11.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND