* [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send
@ 2017-02-02 18:43 Yongseok Koh
2017-02-08 14:28 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2017-02-02 18:43 UTC (permalink / raw)
To: ferruh.yigit
Cc: dev, adrien.mazarguil, nelio.laranjeiro, Yongseok Koh, stable
The total length field in descriptor of inlined multi-packet send must be
updated before closing a seesion. There's possibility of updating it
afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets
silently dropped by HW and impact performance, escpecially lossless test.
Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send")
CC: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 94fe74763..1043ebbc0 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -1046,6 +1046,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
mpw.data.raw += length;
}
++mpw.pkts_n;
+ mpw.total_len += length;
++j;
if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) {
mlx5_mpw_inline_close(txq, &mpw);
@@ -1055,7 +1056,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
inline_room -= length;
}
}
- mpw.total_len += length;
elts_head = elts_head_next;
#ifdef MLX5_PMD_SOFT_COUNTERS
/* Increment sent bytes counter. */
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send
2017-02-02 18:43 [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send Yongseok Koh
@ 2017-02-08 14:28 ` Nélio Laranjeiro
2017-02-08 15:37 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2017-02-08 14:28 UTC (permalink / raw)
To: Yongseok Koh
Cc: guillaume.gaudonville, ferruh.yigit, dev, adrien.mazarguil, stable
On Thu, Feb 02, 2017 at 10:43:32AM -0800, Yongseok Koh wrote:
> The total length field in descriptor of inlined multi-packet send must be
> updated before closing a seesion. There's possibility of updating it
> afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets
> silently dropped by HW and impact performance, escpecially lossless test.
>
> Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send")
> CC: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 94fe74763..1043ebbc0 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1046,6 +1046,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
> mpw.data.raw += length;
> }
> ++mpw.pkts_n;
> + mpw.total_len += length;
> ++j;
> if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) {
> mlx5_mpw_inline_close(txq, &mpw);
> @@ -1055,7 +1056,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
> inline_room -= length;
> }
> }
> - mpw.total_len += length;
> elts_head = elts_head_next;
> #ifdef MLX5_PMD_SOFT_COUNTERS
> /* Increment sent bytes counter. */
> --
> 2.11.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send
2017-02-08 14:28 ` Nélio Laranjeiro
@ 2017-02-08 15:37 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-02-08 15:37 UTC (permalink / raw)
To: Nélio Laranjeiro, Yongseok Koh
Cc: guillaume.gaudonville, dev, adrien.mazarguil, stable
On 2/8/2017 2:28 PM, Nélio Laranjeiro wrote:
> On Thu, Feb 02, 2017 at 10:43:32AM -0800, Yongseok Koh wrote:
>> The total length field in descriptor of inlined multi-packet send must be
>> updated before closing a seesion. There's possibility of updating it
>> afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets
>> silently dropped by HW and impact performance, escpecially lossless test.
>>
>> Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send")
>> CC: stable@dpdk.org
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-08 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-02 18:43 [dpdk-dev] [PATCH] net/mlx5: fix updating total length of multi-packet send Yongseok Koh
2017-02-08 14:28 ` Nélio Laranjeiro
2017-02-08 15:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).