From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 7AC9698 for ; Thu, 9 Feb 2017 00:25:17 +0100 (CET) Received: by mail-pf0-f181.google.com with SMTP id e4so44828841pfg.1 for ; Wed, 08 Feb 2017 15:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xa8kKLrSeDVzmmeVYia5xLl2WWFzaJpDR3E3QryYBlU=; b=qOJHAaiULjmrwePuJyxoF6EyS+2ocyrN3jdrq+tGUlDW5lAdfRMSPSjC0dyvKFjsUh b0GvmLE8WmuO5r518OfXDJhuTxkVtBrO+f+S4rBrIudhb2AfwzJS9SZnk8Z1W8YMpPwh GVBym+0X74ndQXHdZ+VGkF2cTzvrxCqsoeUrFGqwVZJGJ4joSniJIL7g8Mr1k5U59T6s ehX8Ex0x4+FoWVawJvweOHUn9JJhSLlkjkdpkBZGNhibYfALR7qbC5lGLkPG/1dcZlgw nhlrw5HfDCX+esF3NRQNLrzgixQEauO8V5AU0yVWGBApfWdWV200C330okvgtigmKcYW ZScQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xa8kKLrSeDVzmmeVYia5xLl2WWFzaJpDR3E3QryYBlU=; b=ekr3CDkk+peVu8yDkUCtdSN+wZiK9QZC1Aw++0eT+eCvbWNRfusCAj47/1FwNSF8SU tn8eNhh6YJpE8mydEx4v8Y4CFFhB1sDzhfKfTrtQ0FoAiO3oJMbl2VXA66oyKISwbCBq 5Mm08/T7Jc7OrReEUecMx9u3+T2inyKYdl2wewbUHTgyl2sNLjURMY4KwYofqDATNYZ6 YWGMpuMsExLuUdtaIS0rPva0kPfDbtiQfat8dq7BtjSyNzXLW38TtNMG3Yro6XzXgMZf YPMUbYVtDjZLHRyVhpuJ65g+oT6jaJE/4N+VXxLsxnqIkBh1SYMsk4+cPyK8g9GWMOjC IIHA== X-Gm-Message-State: AMke39n0XawbxFAsQ0GQoHxqOKN3fHdR1SSHoWSpK22PsyBMxPmLjPFCQsTHSmcrcQN8aA== X-Received: by 10.99.150.10 with SMTP id c10mr127377pge.160.1486596316738; Wed, 08 Feb 2017 15:25:16 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id i21sm22915438pfi.94.2017.02.08.15.25.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Feb 2017 15:25:16 -0800 (PST) Date: Wed, 8 Feb 2017 15:25:08 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: "dev@dpdk.org" , "alexmay@microsoft.com" , Stephen Hemminger Message-ID: <20170208152508.13fc0878@xeon-e3> In-Reply-To: References: <1429637564-5656-1-git-send-email-stephen@networkplumber.org> <1429637564-5656-2-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/7] ether: add function to query for link state interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 23:25:17 -0000 On Wed, 8 Jul 2015 23:42:05 +0000 Thomas Monjalon wrote: > 2015-04-21 10:32, Stephen Hemminger: > > Allow application to query whether link state will work. > > This is also part of abstracting dependency on PCI. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_ether/rte_ethdev.c | 14 ++++++++++++++ > > lib/librte_ether/rte_ethdev.h | 12 ++++++++++++ > [...] > > /** > > + * Test whether device supports link state interrupt mode. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @return > > + * - (1) if link state interrupt is supported > > + * - (0) if link state interrupt is not supported > > + */ > > +extern int > > +rte_eth_has_link_state(uint8_t port_id); > > It requires change in map file to work with shared library. A better way to solve this to move drv_flags out of PCI driver and into generic driver data structure.