From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Gage Eads <gage.eads@intel.com>,
dev@dpdk.org, hemant.agrawal@nxp.com, harry.van.haaren@intel.com,
nipun.gupta@nxp.com
Subject: Re: [dpdk-dev] [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions
Date: Mon, 13 Feb 2017 12:08:11 +0000 [thread overview]
Message-ID: <20170213120811.GA11468@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170213114810.GA32617@localhost.localdomain>
On Mon, Feb 13, 2017 at 05:18:11PM +0530, Jerin Jacob wrote:
> On Mon, Feb 13, 2017 at 10:38:55AM +0000, Bruce Richardson wrote:
> > On Fri, Feb 10, 2017 at 03:02:21PM -0600, Gage Eads wrote:
> > > This change allows user software to differentiate between an invalid argument
> > > (such as an invalid queue_id or sched_type in an enqueued event) and
> > > backpressure from the event device.
> > >
> > > The port and device ID checks are placed in RTE_LIBRTE_EVENTDEV_DEBUG header
> > > guards to avoid the performance hit in non-debug execution.
> > >
> > > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > > ---
> >
> > Do we have some idea of the performance hit from these? It may be too
> > soon to know, given we don't have many drivers to test with, but if
> > there is no perf hit seen with the SW driver, I think we should look to
> > just always do this, rather than having it compile-time off. If it does
>
> IMO, It is better put to under compile-time like ethdev. It is
> difficult predict the performance regression on wide range of cores that DPDK
> runs now. I think we need to add following additional checks based on
> Gage header file change
>
> 1) Per event queue ID is valid or not?
> 2) Per event's sched type doesn't match the capabilities of the destination queue.
>
Ok, if we are expanding the number of checks then I definitely think it
needs to be compile-time selected.
/Bruce
>
> > prove to be a performance problem we can look to #ifdef it out later.
> >
> > /Bruce
next prev parent reply other threads:[~2017-02-13 12:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 21:02 Gage Eads
2017-02-13 10:38 ` Bruce Richardson
2017-02-13 11:48 ` Jerin Jacob
2017-02-13 12:08 ` Bruce Richardson [this message]
2017-02-13 16:05 ` Eads, Gage
2017-02-14 4:10 ` Jerin Jacob
2017-02-15 0:14 ` Eads, Gage
2017-02-15 17:09 ` [dpdk-dev] [PATCH v2] " Gage Eads
2017-03-16 10:28 ` Jerin Jacob
2017-03-16 20:12 ` [dpdk-dev] [PATCH v3] eventdev: add errno-style return values Gage Eads
2017-03-17 3:10 ` Jerin Jacob
2017-03-17 14:34 ` Eads, Gage
2017-03-17 14:51 ` [dpdk-dev] [PATCH v4] " Gage Eads
2017-03-21 11:06 ` Jerin Jacob
2017-03-21 20:38 ` Eads, Gage
2017-03-22 6:53 ` Jerin Jacob
2017-03-22 14:58 ` [dpdk-dev] [PATCH v5] " Gage Eads
2017-03-22 17:17 ` Jerin Jacob
2017-03-23 22:32 ` Eads, Gage
2017-03-23 22:30 ` [dpdk-dev] [PATCH v6] " Gage Eads
2017-03-24 2:38 ` Jerin Jacob
2017-03-25 5:11 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213120811.GA11468@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).