From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1521E11D4; Tue, 14 Feb 2017 07:08:09 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2017 22:08:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,159,1484035200"; d="scan'208";a="44093298" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 13 Feb 2017 22:08:07 -0800 Date: Tue, 14 Feb 2017 14:10:24 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: Rahul Lakkireddy , Emmanuel Roullit , "dev@dpdk.org" , Kumar Sanghvi , Nirranjan Kirubaharan , stable@dpdk.org Message-ID: <20170214061024.GS20916@yliu-dev.sh.intel.com> References: <20170124204859.8998-1-emmanuel.roullit@gmail.com> <20170124204859.8998-2-emmanuel.roullit@gmail.com> <4742eebd-1712-db20-26b0-d2a8e1f9aaf8@intel.com> <20170126044123.GA6590@chelsio.com> <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 06:08:10 -0000 On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote: > On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote: > > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote: > >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: > >>> Found with clang static analysis: > >>> drivers/net/cxgbe/sge.c:900:3: warning: > >>> Value stored to 'in_use' is never read > >>> in_use += q->size; > >>> ^ ~~~~~~~ > >>> > >>> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") > > > > This fixes line seems to be wrong. Should be: > > > > > > >>> > >>> Signed-off-by: Emmanuel Roullit > > > Fixes: 4a01078b4fd1 ("cxgbe: add Tx support") > Cc: stable@dpdk.org I doubt the necessary of picking it to a stable release: it doesn't fix a real bug after all. Therefore, I will drop it for v16.11.1. --yliu > > Acked-by: Rahul Lakkireddy > > > Applied to dpdk-next-net/master, thanks. > > (patch 2/3 and 3/3 merged)