* [dpdk-dev] [PATCH] net/bonding: remove useless assignment
@ 2017-01-24 21:15 Emmanuel Roullit
2017-01-25 12:11 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Emmanuel Roullit @ 2017-01-24 21:15 UTC (permalink / raw)
To: declan.doherty; +Cc: dev
Found with clang static analysis:
drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
warning: Value stored to 'num_not_send' is never read
num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 02e34483f..f3ac9e273 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -900,7 +900,6 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
}
num_tx_total += num_send;
- num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
}
return num_tx_total;
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bonding: remove useless assignment
2017-01-24 21:15 [dpdk-dev] [PATCH] net/bonding: remove useless assignment Emmanuel Roullit
@ 2017-01-25 12:11 ` Ferruh Yigit
2017-01-26 11:08 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-25 12:11 UTC (permalink / raw)
To: Emmanuel Roullit, declan.doherty; +Cc: dev
On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
> warning: Value stored to 'num_not_send' is never read
> num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
>
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bonding: remove useless assignment
2017-01-25 12:11 ` Ferruh Yigit
@ 2017-01-26 11:08 ` Ferruh Yigit
2017-02-14 6:11 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-26 11:08 UTC (permalink / raw)
To: Emmanuel Roullit, declan.doherty; +Cc: dev, dpdk stable
On 1/25/2017 12:11 PM, Ferruh Yigit wrote:
> On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
>> Found with clang static analysis:
>> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
>> warning: Value stored to 'num_not_send' is never read
>> num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
>
> Applied to dpdk-next-net/master, thanks.
Fixes: 06fe78b98ccd ("bond: add mode 6")
Cc: stable@dpdk.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: remove useless assignment
2017-01-26 11:08 ` Ferruh Yigit
@ 2017-02-14 6:11 ` Yuanhan Liu
0 siblings, 0 replies; 4+ messages in thread
From: Yuanhan Liu @ 2017-02-14 6:11 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Emmanuel Roullit, declan.doherty, dev, dpdk stable
On Thu, Jan 26, 2017 at 11:08:29AM +0000, Ferruh Yigit wrote:
> On 1/25/2017 12:11 PM, Ferruh Yigit wrote:
> > On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
> >> Found with clang static analysis:
> >> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
> >> warning: Value stored to 'num_not_send' is never read
> >> num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
> >> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
> >>
> >> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> >
> > Applied to dpdk-next-net/master, thanks.
>
> Fixes: 06fe78b98ccd ("bond: add mode 6")
> Cc: stable@dpdk.org
For the same reason (it didn't fix a real bug), I will drop it to a
stable release.
--yliu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-14 6:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 21:15 [dpdk-dev] [PATCH] net/bonding: remove useless assignment Emmanuel Roullit
2017-01-25 12:11 ` Ferruh Yigit
2017-01-26 11:08 ` Ferruh Yigit
2017-02-14 6:11 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).