From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 28D6DA2F for ; Tue, 14 Feb 2017 16:41:35 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2017 07:41:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,161,1484035200"; d="scan'208";a="1094668221" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga001.jf.intel.com with SMTP; 14 Feb 2017 07:41:32 -0800 Received: by (sSMTP sendmail emulation); Tue, 14 Feb 2017 15:41:32 +0000 Date: Tue, 14 Feb 2017 15:41:31 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20170214154131.GA20524@bricha3-MOBL3.ger.corp.intel.com> References: <20170214151326.7554-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170214151326.7554-1-ferruh.yigit@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 15:41:36 -0000 On Tue, Feb 14, 2017 at 03:13:26PM +0000, Ferruh Yigit wrote: > Tests are part of app folder and compiled with library every time. > Moving tests into a "test" folder which won't be compiled by default. > To compile tests, need to give explicit "make test" command. > > "make test" was previously used to run tests, which renamed to > "make test_run" with this patch. > > This makes default compilation ~30% faster, > [clang, make -j8, old]: real 1m04.355s > [clang, make -j8, new]: real 0m41.740s > > For new case, test needs to built separately, which takes, > [clang, make -j8 test]: real 0m24.293s > > The point is tests are not required always and by every one. > > Signed-off-by: Ferruh Yigit > --- Hi Ferruh, I'm not sure I'm convinced by this, as I think there are advantages to having the test code always compiled. Anything that is not compiled in DPDK by default is more likely to be broken by patch submissions. The speed boost to build is nice, but I'm not sure it's worth it. However, I'm open to being convinced otherwise on this... /Bruce