From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 269252B8E for ; Thu, 16 Feb 2017 10:08:45 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 01:08:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,168,1484035200"; d="scan'208";a="1108694680" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga001.fm.intel.com with SMTP; 16 Feb 2017 01:08:42 -0800 Received: by (sSMTP sendmail emulation); Thu, 16 Feb 2017 09:08:41 +0000 Date: Thu, 16 Feb 2017 09:08:41 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, John McNamara , Keith Wiles Message-ID: <20170216090841.GA92400@bricha3-MOBL3.ger.corp.intel.com> References: <20170214151326.7554-1-ferruh.yigit@intel.com> <20170215152632.25081-1-ferruh.yigit@intel.com> <20170215152632.25081-3-ferruh.yigit@intel.com> <20170215170724.GA89892@bricha3-MOBL3.ger.corp.intel.com> <81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 09:08:46 -0000 On Wed, Feb 15, 2017 at 05:41:08PM +0000, Ferruh Yigit wrote: > On 2/15/2017 5:07 PM, Bruce Richardson wrote: > > On Wed, Feb 15, 2017 at 03:26:31PM +0000, Ferruh Yigit wrote: > >> Since "make test" and "make test-build" does dependency resolving, they > >> check for all dependent components (lib and drivers) which takes a few > >> seconds. > >> > >> This is a good feature during development, but if the target is just > >> running unit test, that step is unnecessary, it is possible to compile > >> onece and run unit test multiple times, without checking any code update > >> > >> For this purpose, a new make rule "make test-run" added. Which just runs > >> the unit test, expects that unit test already compiled. > >> > >> Signed-off-by: Ferruh Yigit > >> --- > > Sorry, I just don't see the point of having an extra command to maintain > > and document for the sake of a few seconds on a unit test run. How long > > does the run itself take compared to the time to check dependencies? > > It is matter of choice, it does not take much time for "make test", but > still I thought it is handy to have a rule only to run the test. > > I don't expect much maintenance cost with this, also I don't have strong > opinion to keep it. > Yes, I suppose it isn't much maintenance cost indeed, so if nobody else cares, I'm ok with it too. /Bruce