From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by dpdk.org (Postfix) with ESMTP id 4DA4B326C for ; Fri, 17 Feb 2017 20:30:23 +0100 (CET) Received: by mail-pg0-f48.google.com with SMTP id y6so14212793pgy.0 for ; Fri, 17 Feb 2017 11:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2cyxc2XUhTSOR/Xsme0VQTazlYDsGz3ug4rPN+nxCgE=; b=Jo+Mhr2+Mj7+UkGwGcZhNhI/kXh03zOZHJkPzpDctuV7zy00kokZeGIjVKNoAZI3aY SUlH5amOxy4N4evqspT8KMXx/OFIdUJGK76HeH8thfjVKHyQo3rGgHviaMc0R+ez0diw zxHiZECZSES5OWEwsqismy9Eo6D00nAsJM7EZoEBKjmNf9yi0vB6S+RHVgCOZV3z3Td/ byM1/ZqVX8klQkpqDWNYxjcK9/A3hHXe/G/2WKdgDfuBML1ZzG3I/FN0EzQWbJcGYZ4S kaT0FujHdQr9m3/7LwO7bnsOLJGCITKYgjJq6fs26bnQXwn2xCunsqefBkPLP/kfXkkd LkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2cyxc2XUhTSOR/Xsme0VQTazlYDsGz3ug4rPN+nxCgE=; b=tLR/kX1mQ7N7+QSBN9wyxL48Y8emJqZHBr0MWEOBwypEAwC50KjBOmUDJfM8EpBo2z Fn5ntnxImMdxrQK1i98BN/AyqPl43tbR6X9T75KvKCcmsK/Y4DNJ0dHeZN/KhWwOVXZg dHcSMy8YzjOUJJGIKcc/C17dCWXG7S6TFFMtKnu97FlhUNMpjOxQhF+fbLwp+Hd9Zufk Qz40BNvYOTI/uAhE39LoCqThiW4zQMqD44hwXf1uPNW63GtKBL9+KI9m58CqtHU4TPln qQarXp6kfjjrBf53VZnwR7gPpaPCmRJf+Q3hB8sNlWZ3oPnU1bKXIYNPjI/c3UppUzYn uKjA== X-Gm-Message-State: AMke39nNRTmd3U/mBXbmY0UC5r0V8cgWE060IF5r5ewyc8nOOs5IJGrh4nTMJOW6EKSC5g== X-Received: by 10.84.232.134 with SMTP id i6mr13446432plk.101.1487359822390; Fri, 17 Feb 2017 11:30:22 -0800 (PST) Received: from plumbers-lap.home.lan ([12.139.153.2]) by smtp.gmail.com with ESMTPSA id c204sm21032460pfb.51.2017.02.17.11.30.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Feb 2017 11:30:22 -0800 (PST) Date: Fri, 17 Feb 2017 11:30:20 -0800 From: Stephen Hemminger To: Nipun Gupta Cc: , , , , , Message-ID: <20170217113020.094e7912@plumbers-lap.home.lan> In-Reply-To: <1487242349-16801-1-git-send-email-nipun.gupta@nxp.com> References: <1487242349-16801-1-git-send-email-nipun.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eventdev: event device to contain rte device holder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 19:30:23 -0000 On Thu, 16 Feb 2017 16:22:29 +0530 Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > > rte_device is a generic device which is available to the applications > and EAL. This patch replaces rte_pci_device in 'struct rte_eventdev' > and in 'struct rte_event_dev_info' with common rte_device. > --- > drivers/event/skeleton/skeleton_eventdev.c | 2 +- > lib/librte_eventdev/rte_eventdev.c | 6 +++--- > lib/librte_eventdev/rte_eventdev.h | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c > index dee0faf..770dce3 100644 > --- a/drivers/event/skeleton/skeleton_eventdev.c > +++ b/drivers/event/skeleton/skeleton_eventdev.c > @@ -383,7 +383,7 @@ > if (rte_eal_process_type() != RTE_PROC_PRIMARY) > return 0; > > - pci_dev = eventdev->pci_dev; > + pci_dev = RTE_DEV_TO_PCI(eventdev->dev); How will this work when there are more than just PCI devices? For example, upcoming patches will add rte_vmbus_device. There is no run time type checking in C.