From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AF4A45597 for ; Fri, 17 Feb 2017 16:02:49 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2017 07:02:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="67057544" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga006.fm.intel.com with SMTP; 17 Feb 2017 07:02:46 -0800 Received: by (sSMTP sendmail emulation); Fri, 17 Feb 2017 15:02:46 +0000 Date: Fri, 17 Feb 2017 15:02:45 +0000 From: Bruce Richardson To: Keith Wiles Cc: dev@dpdk.org Message-ID: <20170217150245.GB8652@bricha3-MOBL3.ger.corp.intel.com> References: <20170217144426.47823-1-keith.wiles@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217144426.47823-1-keith.wiles@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 15:02:50 -0000 On Fri, Feb 17, 2017 at 08:44:26AM -0600, Keith Wiles wrote: > Calling strncpy with a maximum size argument of 16 bytes on destination > array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the > destination string unterminated. > > Signed-off-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index efc4426..f9938d7 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add) > return -1; > } > memset(&ifr, 0, sizeof(ifr)); > - strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ); > + strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ-1); This is why I always prefer to use snprintf for copying strings, you can't avoid null terminating. snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name); /Bruce